Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp1690441rdb; Sat, 20 Jan 2024 09:02:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IHPYwJN8xidP8HT4vFL+HZt3wKnjwgkProNPsyXt/UhZB+JthlFlkaTU4RHidMhaK0co/B0 X-Received: by 2002:a05:6a20:1582:b0:19a:e470:f2cb with SMTP id h2-20020a056a20158200b0019ae470f2cbmr931561pzj.19.1705770138377; Sat, 20 Jan 2024 09:02:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705770138; cv=pass; d=google.com; s=arc-20160816; b=sLpec+5ulm1IqBG47LunyiqPBWKDgsOmD3yu+AzplosbHK/E8EB8ZQXErtV7OHlQIL xdLlKtySaztHnLzedc/4Ud0aE0IDBekml3CXHu58slQnvxtfHMXNuMkLwyFpAY5ocDDM J09M0QfTUvFZhHJUmydT1GSYduhVKUe5J1xrAVoymTpQNSwY3WpXZT3MHzkRogynz3fZ sQH8XrMScCCNBRPEinuJKIWctJNi/bLeygWsXEPT+g7P69nWEWJZqE4i0gVxJrUCH9ew ODcDNoGEdjVMhRsO8VJXa43a3tVcvrj5+vNlXJ5SANwHS7GiniguillV5Ymwmb3FTNnw Zohg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=b8tEllDNlsEDP/jUaFTWEigyTJb7YjOR8aztDaSFSnA=; fh=iobuAXAr014AM2kvYOxcrO2O8XSWqmU6+Than1EwtG4=; b=pvZy0E1ZCkwnLj229C2KJbu+1VpAOBcDoSz0OxZmVRWo8OQzVBJ90+3VoDy/mmRkV6 eyb0POtl1yvEQgCJcu9i7NO64QP3bqpk1Ff3ceRyiFsmpA288ygTfzwAl8uYi/K1N8wV 1csBedW7iOlGxpbq88ARQeUIbvIBUIjKxykuqynaZAJlpoh4LB0uC9NzsKqBNxL5FeXL NqKDS7VdYTSIHxx9OyuEPeuQQ1pGRCw6MKzF8TYuaMbMg6ALZiMX7XO5l/fg3BxvM61U HJ462vUEVXMJlyROPJgylk8LWZa93RaLLYiib8KSN6YNBLmqn8vMrFwIM5tHZ3wWQH1S UBKA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=lU0cjhKv; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-31849-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31849-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id l8-20020a170903244800b001d5be6613f4si5476127pls.173.2024.01.20.09.02.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jan 2024 09:02:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-31849-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=lU0cjhKv; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-31849-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31849-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 73F0FB21045 for ; Sat, 20 Jan 2024 17:02:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C4AFD14AAA; Sat, 20 Jan 2024 17:01:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="lU0cjhKv" Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D87214A85 for ; Sat, 20 Jan 2024 17:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705770117; cv=none; b=F5eTe1AK0Vc7VT5lQV2I30IfLn/ZNXzHCPwGoI9jQSfrhD8f+sUY+CDGdhUKW1e0XjXTsyFTf4LVcG1QsYdiqTMIi2IjhSwfeP09otHdQ8wMUtU+sUsXnXUleGfxnZvOzh3g5gEGkzYjz7+zsjooSQqiiqtExOeYenn+7WkQcWE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705770117; c=relaxed/simple; bh=M0N3JvZSRxhre+AHdg2DAWF69SvD6OJuhG0bltmzIpM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=FDLOu+zSZfzJNxqc/iLgcrhfxzOeItBLYbKIllUmrWatodVBu7ukuCswIBIEGzij4/AH9MqdsW7CRltA8+5YG2sCpBeplRQ4Fs94aXvlF5sjyFk7pUM5iwsqW3bGZNXuUdE2inAA3ftpMIZKNSrJQkf/4Dow+4O3uvGVULURX8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=lU0cjhKv; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-5cdbc42f5efso182855a12.0 for ; Sat, 20 Jan 2024 09:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1705770113; x=1706374913; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b8tEllDNlsEDP/jUaFTWEigyTJb7YjOR8aztDaSFSnA=; b=lU0cjhKviuPCNkyum783IabQBtofZGKZr9rytS6YlD6Qie33jroR872HS56OwoFQe7 ETOPbCjdumfrZ4upqI/j/CN19AJ50ZzkEQwjCd2aExRekSqs0EVcEiqitqNbd0/aYobD hHE9zPJzTFvQAVklNWEDsLLM1ETke9QDRwNo49I5ntUGvJgxGOi7lUG0qn6ExAW9OlvI 2ISj5dC1T7dfVRUcbuGtn857/1nqUNst835oRQgCTxZ2X7uhMeeI8Ww0rx8kpqDk7vNu y+zAd0MYNKMRdeDg6zOq8avVAj45kE4TgTm9V0T9jivEF0TCYIL5H0xt7tBelmhw1xlM IT1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705770113; x=1706374913; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b8tEllDNlsEDP/jUaFTWEigyTJb7YjOR8aztDaSFSnA=; b=Q+akVkmYViGMuE+yNFlF0C9hZu6NfGS+DNHSm/vhDjHjEqV1MXI+kwp9lCXh0Ik9fZ Qk0+Xd1TlGGUARI4UNghMhX5C4+6qXec8aUPUOd1aEL8vFJ16Lv163nn2j8T2qWYBvg6 FNiA9z8F8Rfm19YiUG3yGg1e4m87ueRHgFLkFLFt2AsgeRYr5ky4FrdsNHH+DeBr9R5Y 6VeAz7mSu/hOVVgfxzKr5lEUIGSjQydCcUVxNV2oD2fgACaFtaST+Huvt1g4kidAUcq6 T1NoabvbU7BBJk7eqBzv23O4J6SBEHXvCUVyseLX2wt9bfXz7+NjefXfZ9Pogt0KIpI3 3GgA== X-Gm-Message-State: AOJu0YyKSrZl59cEEDAretnlKph3jsYuuk7fI2SELdlmaIcboakFy74W tjYzMcY++mI0YHigTpjfP527wxNNZBTl8uztx2Nxmq11jDNmA3Bsy8uZvET39kuA6KcvNDQx/Ze uaas= X-Received: by 2002:a05:6a21:398f:b0:19b:20e9:90da with SMTP id ad15-20020a056a21398f00b0019b20e990damr5256618pzc.5.1705770113640; Sat, 20 Jan 2024 09:01:53 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id fi33-20020a056a0039a100b006d9aa6592d0sm6969907pfb.82.2024.01.20.09.01.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jan 2024 09:01:53 -0800 (PST) Message-ID: Date: Sat, 20 Jan 2024 10:01:51 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] iouring:added boundary value check for io_uring_group systl Content-Language: en-US To: Subramanya Swamy , corbet@lwn.net, jmoyer@redhat.com, asml.silence@gmail.com, akpm@linux-foundation.org, bhe@redhat.com, ribalda@chromium.org, rostedt@goodmis.org, sshegde@linux.vnet.ibm.com, alexghiti@rivosinc.com, matteorizzo@google.com, ardb@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org References: <20240120144411.2564-1-subramanya.swamy.linux@gmail.com> From: Jens Axboe In-Reply-To: <20240120144411.2564-1-subramanya.swamy.linux@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/20/24 7:44 AM, Subramanya Swamy wrote: > /proc/sys/kernel/io_uring_group takes gid as input > added boundary value check to accept gid in range of > 0<=gid<=4294967294 & Documentation is updated for same This should have: Fixes: 76d3ccecfa18 ("io_uring: add a sysctl to disable io_uring system-wide") > diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst > index 6584a1f9bfe3..a8b61ab3e118 100644 > --- a/Documentation/admin-guide/sysctl/kernel.rst > +++ b/Documentation/admin-guide/sysctl/kernel.rst > @@ -470,10 +470,8 @@ io_uring_group > ============== > > When io_uring_disabled is set to 1, a process must either be > -privileged (CAP_SYS_ADMIN) or be in the io_uring_group group in order > -to create an io_uring instance. If io_uring_group is set to -1 (the > -default), only processes with the CAP_SYS_ADMIN capability may create > -io_uring instances. > +privledged (CAP_SYS_ADMIN) or be in the io_uring_group group in order privileged. -- Jens Axboe