Received-SPF: pass (google.com: domain of linux-kernel+bounces-31897-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <f27b491c-2f1c-4e68-804c-24eeaa8d10de@redhat.com>
Date: Sat, 20 Jan 2024 21:26:03 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Hans de Goede <hdegoede@redhat.com>
Subject: Re: PS/2 keyboard of laptop Dell XPS 13 9360 goes missing after S3
To: Paul Menzel <pmenzel@molgen.mpg.de>, LKML <linux-kernel@vger.kernel.org>
Cc: linux-input@vger.kernel.org, linux-pm@vger.kernel.org,
 Dell.Client.Kernel@dell.com, regressions@lists.linux.dev
References: <0aa4a61f-c939-46fe-a572-08022e8931c7@molgen.mpg.de>
Content-Language: en-US, nl
In-Reply-To: <0aa4a61f-c939-46fe-a572-08022e8931c7@molgen.mpg.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi Paul,

On 1/18/24 13:57, Paul Menzel wrote:
> #regzbot introduced v6.6.11..v6.7
> 
> Dear Linux folks,
> 
> 
> There seems to be a regression in Linux 6.7 on the Dell XPS 13 9360 (Intel i7-7500U).
> 
>     [    0.000000] DMI: Dell Inc. XPS 13 9360/0596KF, BIOS 2.21.0 06/02/2022
> 
> The PS/2 keyboard goes missing after S3 resume¹. The problem does not happen with Linux 6.6.11.

Thank you for reporting this.

Can you try adding "i8042.dumbkbd=1" to your kernel commandline?

This should at least lead to the device not disappearing from

"sudo libinput list-devices"

The next question is if the keyboard will still actually
work after suspend/resume with "i8042.dumbkbd=1". If it
stays in the list, but no longer works then there is
a problem with the i8042 controller; or interrupt
delivery to the i8042 controller.

If "i8042.dumbkbd=1" somehow fully fixes things, then I guess
my atkbd driver fix for other laptop keyboards is somehow
causing issues for yours.

If "i8042.dumbkbd=1" fully fixes things, can you try building
your own 6.7.0 kernel with commit 936e4d49ecbc:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=936e4d49ecbc8c404790504386e1422b599dec39

reverted?

Regards,

Hans


> 
>     [    1.435071] i8042: PNP: PS/2 Controller [PNP0303:PS2K,PNP0f13:PS2M] at 0x60,0x64 irq 1,12
>     [    1.435409] i8042: Warning: Keylock active
>     [    1.437624] serio: i8042 KBD port at 0x60,0x64 irq 1
>     [    1.437631] serio: i8042 AUX port at 0x60,0x64 irq 12
>     […]
>     [    1.439743] input: AT Translated Set 2 keyboard as /devices/platform/i8042/serio0/input/input0
> 
>     $ sudo libinput list-devices
>     […]
>     Device:           AT Translated Set 2 keyboard
>     Kernel:           /dev/input/event0
>     Group:            15
>     Seat:             seat0, default
>     Capabilities:     keyboard
>     Tap-to-click:     n/a
>     Tap-and-drag:     n/a
>     Tap drag lock:    n/a
>     Left-handed:      n/a
>     Nat.scrolling:    n/a
>     Middle emulation: n/a
>     Calibration:      n/a
>     Scroll methods:   none
>     Click methods:    none
>     Disable-w-typing: n/a
>     Disable-w-trackpointing: n/a
>     Accel profiles:   n/a
>     Rotation:         0.0
> 
> `libinput list-devices` does not list the device after resuming from S3. Some of the function keys, like brightness and airplane mode keys, still work, as the events are probably transmitted over the embedded controller or some other mechanism. An external USB keyboard also still works.
> 
> I haven’t had time to further analyze this, but wanted to report it. No idea
> 
> 
> Kind regards,
> 
> Paul
> 
> 
> ¹ s2idle is not working correctly on the device, in the sense, that energy usage is very high in that state, and the full battery is at 20 % after leaving it for eight hours.