Received-SPF: pass (google.com: domain of linux-kernel+bounces-31952-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 21 Jan 2024 02:00:51 +0000
From: Matthew Wilcox <willy@infradead.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: naoya.horiguchi@nec.com, akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memory-failure: fix crash in split_huge_page_to_list
 from soft_offline_page
Message-ID: <Zax60-Qu14QFuDod@casper.infradead.org>
References: <20240120065729.3276395-1-linmiaohe@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240120065729.3276395-1-linmiaohe@huawei.com>

On Sat, Jan 20, 2024 at 02:57:29PM +0800, Miaohe Lin wrote:
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 636280d04008..20058f7ac3e9 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1377,8 +1377,13 @@ void ClearPageHWPoisonTakenOff(struct page *page)
>   */
>  static inline bool HWPoisonHandlable(struct page *page, unsigned long flags)
>  {
> -	/* Soft offline could migrate non-LRU movable pages */
> -	if ((flags & MF_SOFT_OFFLINE) && __PageMovable(page))
> +	/*
> +	 * Soft offline could migrate non-LRU movable pages.
> +	 * Note that page->mapping is overloaded with slab->slab_list or slabs
> +	 * fields which might make slab pages appear like non-LRU movable pages.
> +	 * So __PageMovable() has to be done after PageSlab() is checked.
> +	 */
> +	if ((flags & MF_SOFT_OFFLINE) && !PageSlab(page) && __PageMovable(page))
>  		return true;
>  
>  	return PageLRU(page) || is_free_buddy_page(page);

I think would make more sense as

+	if (PageSlab(page))
+		return false;

.. and then leave the rest alone (including not touching the comment)