Received-SPF: pass (google.com: domain of linux-kernel+bounces-31984-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 21 Jan 2024 00:05:34 -0800
From: Kees Cook <kees@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
 Al Viro <viro@zeniv.linux.org.uk>
CC: Josh Triplett <josh@joshtriplett.org>, Kees Cook <keescook@chromium.org>,
 linux-kernel@vger.kernel.org, Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [GIT PULL] execve updates for v6.8-rc1
User-Agent: K-9 Mail for Android
In-Reply-To: <CAHk-=whw936qzDLBQdUz-He5WK_0fRSWwKAjtbVsMGfX70Nf_Q@mail.gmail.com>
References: <202401081028.0E908F9E0A@keescook> <CAHk-=wgznerM-xs+x+krDfE7eVBiy_HOam35rbsFMMOwvYuEKQ@mail.gmail.com> <D01C78AC-830C-4D73-9E9F-7FD38CEF2E82@kernel.org> <ZZ2W_xzCSyOgltad@localhost> <CAHk-=wi75tFVtZdzFRr4hsDeUKmeACbgD46rLe+2bcd=4mHBBw@mail.gmail.com> <ZZ3_Jmb1sb2wQWO_@localhost> <CAHk-=whf9qLO8ipps4QhmS0BkM8mtWJhvnuDSdtw5gFjhzvKNA@mail.gmail.com> <20240111094711.GT1674809@ZenIV> <20240111100501.GU1674809@ZenIV> <CAHk-=wi-aMO1GuN1odOz4MZksMNECVdrORuXKfqSS9DoTx0yDg@mail.gmail.com> <CAHk-=whw936qzDLBQdUz-He5WK_0fRSWwKAjtbVsMGfX70Nf_Q@mail.gmail.com>
Message-ID: <F3CF53C5-6423-4DA3-83CA-86B8B8C3862C@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable


On January 20, 2024 2:18:36 PM PST, Linus Torvalds <torvalds@linux-foundat=
ion=2Eorg> wrote:
>End result: I committed my "move do_open_execat() to the beginning of
>execve()" patch, since it's clearly an improvement on the existing
>behavior, and that whole "struct file allocations are unnecessarily
>expensive" issue is a separate thing=2E

Thanks! I'll add the other bits of refactoring I did in my version of the =
clean-up (I created do_close_execat() for the repeated "allow_write_access(=
file); fput(file);" calls, along with some comments):
https://lore=2Ekernel=2Eorg/lkml/202209161637=2E9EDAF6B18@keescook/

I like your removal of the "out" label! :)

-Kees

--=20
Kees Cook