Received-SPF: pass (google.com: domain of linux-kernel+bounces-31997-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sun, 21 Jan 2024 11:02:00 +0100
From: Erick Archer <erick.archer@gmx.com>
To: Hu Haowen <2023002089@link.tyut.edu.cn>,
	Jonathan Corbet <corbet@lwn.net>
Cc: Erick Archer <erick.archer@gmx.com>, Alex Shi <alexs@kernel.org>,
	Yanteng Si <siyanteng@loongson.cn>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH] docs/zh_CN/power: Use kcalloc() instead of kzalloc()
Message-ID: <20240121100200.GA2790@titan>
References: <20240120122204.4287-1-erick.archer@gmx.com>
 <a567932c-d878-44e5-836f-90fa15999ba6@link.tyut.edu.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <a567932c-d878-44e5-836f-90fa15999ba6@link.tyut.edu.cn>
UI-OutboundReport: notjunk:1;M01:P0:+f0LBdijmAA=;RUTWIuVqfR+NAd2kYjIN1CUlEnB
 H3InGi9HvBi0RB90KCz6DV7IZGN3GxaPBX6+uKGrmclTylNYOHIWSKAb032X+QWTZKE00sqXg
 vBxemqr6mF1+Newxeuvu0Q9lkiVZLPMtMMvFZ/vuI3ZwBc8+JXNxvkpcV3Fe8PQ/jRZzZVPQL
 BPOuj5fH8HiycbXQoRYFM+5Ki/MGLbgSA5zEw2nHkqNEvQTwp+46UnnDrE9ZvNq6KVxUQuc6Q
 POr8yNhoLQDEpeRZ1B1RdFm252733DPEPGhVluJPvGeoFVqzaoQGJCiH9GTB3dNpQoQsgo1yr
 cPNK1eW7MdLCaSWWd/oJ0Adv11eda75B2BbPPqO5FbJvOcOWHHm+47IOPToNi+aFQyIyxyp2q
 z7rMxfkgGLyyAuroYThXl9n5CLqPC+ORiV9fsbeVBL2tFr0Varwr3cFoAG3SESFHPAcyEBKdh
 PnGRXPzMVPyGkxFdr5kcQIJ0SrAJG1pdpcxsc5eKMgCu96ZhBc/dtQKVC+UmWQBBlULLjGuOv
 Z9zTnmw9Vrd5EhoX2tWoKspi0p05u4IDptC+P1G8mrT7iL3YTNqwkowq5tk6wo08QCW7PHODQ
 GESDGLHyxNyItYlEv5MGYS+V64jQZmE62PanG86B6Q3Mw/EsBnExoZk+YsR9KF8ZNHEOmaGY+
 GMVQpXcDhPx49Ju78ewjUSx6g2jHpZgKVseYVfCbWdV0Z6cszCH9ViOxf4+fap6WqFJVIzeR4
 NZIFpfV0reyivx1o+zi6yJwiBsrXzfurjwkv7y6aVrCsT6Gg5QqMLSX4X3DV5AvLR+1qewYGM
 PumIJYITvNxoNo4uJTieGRLhEgzHfLsnnkm+qscLS/zh/is0cVGEtIHCCDlVUBXCxbu3/aQ+b
 A0ceYE8kCdy+1DlXcUuUzPf7RGVJgbZ2du10tq0zRHd04LMyU2c5H/j0Utghjbn9o0f8kyfbX
 /02jL/jzM7RO+1DgPuG+hPCzW+Y=

Hi Hu and Jonathan,

On Sat, Jan 20, 2024 at 10:24:42PM +0800, Hu Haowen wrote:
>
> =E5=9C=A8 2024/1/20 20:22, Erick Archer =E5=86=99=E9=81=93:
> > As noted in the "Deprecated Interfaces, Language Features, Attributes,
> > and Conventions" documentation [1], size calculations (especially
> > multiplication) should not be performed in memory allocator (or simila=
r)
> > function arguments due to the risk of them overflowing. This could lea=
d
> > to values wrapping around and a smaller allocation being made than the
> > caller was expecting. Using those allocations could lead to linear
> > overflows of heap memory and other misbehaviors.
> >
> > So, in the example code use the purpose specific kcalloc() function
> > instead of the argument size * count in the kzalloc() function.
> >
> > Link: https://www.kernel.org/doc/html/next/process/deprecated.html#ope=
n-coded-arithmetic-in-allocator-arguments [1]
> > Link: https://github.com/KSPP/linux/issues/162
> > Signed-off-by: Erick Archer <erick.archer@gmx.com>
> > ---
> >   Documentation/translations/zh_CN/power/opp.rst | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/translations/zh_CN/power/opp.rst b/Document=
ation/translations/zh_CN/power/opp.rst
> > index 8d6e3f6f6202..7470fa2d4c43 100644
> > --- a/Documentation/translations/zh_CN/power/opp.rst
> > +++ b/Documentation/translations/zh_CN/power/opp.rst
> > @@ -274,7 +274,7 @@ dev_pm_opp_get_opp_count
> >   	 {
> >   		/* =E5=81=9A=E4=B8=80=E4=BA=9B=E4=BA=8B=E6=83=85 */
> >   		num_available =3D dev_pm_opp_get_opp_count(dev);
> > -		speeds =3D kzalloc(sizeof(u32) * num_available, GFP_KERNEL);
> > +		speeds =3D kcalloc(num_available, sizeof(u32), GFP_KERNEL);
>
>
> If the translated version is modified, I think the original file should
> follow as well at Documentation/power/opp.rst line 308:
>
> diff --git a/Documentation/power/opp.rst b/Documentation/power/opp.rst
> index a7c03c470980..dca35018214a 100644
> --- a/Documentation/power/opp.rst
> +++ b/Documentation/power/opp.rst
> @@ -305,7 +305,7 @@ dev_pm_opp_get_opp_count
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 /* Do things */
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 num_available =3D dev_pm_opp_get_opp_count(dev);
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 speeds =3D kzalloc(sizeof(u32) * num_available, GFP_KERNEL=
);
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 speeds =3D kcalloc(sizeof(u32) * num_available, GFP_KERNEL=
);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 /* populate the table in increasing order */
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 freq =3D 0;
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 while (!IS_ERR(opp =3D dev_pm_opp_find_freq_ceil(dev, &=
freq)))
> {

As you both suggested, this change should be made if the original file is
changed. Therefore, before this patch I already sent another one [1] that
made the proposed changes to the original file.

[1] https://lore.kernel.org/linux-hardening/20240120120527.3866-1-erick.ar=
cher@gmx.com/

But if you prefer, I can send just one patch with the two changes.

Best regards,
Erick

>
> Thanks,
> Hu Haowen
>
>
> >   		/* =E6=8C=89=E5=8D=87=E5=BA=8F=E5=A1=AB=E5=85=85=E8=A1=A8 */
> >   		freq =3D 0;
> >   		while (!IS_ERR(opp =3D dev_pm_opp_find_freq_ceil(dev, &freq))) {
> > --
> > 2.25.1
> >
> >
> >