Received-SPF: pass (google.com: domain of linux-kernel+bounces-32015-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Erick Archer <erick.archer@gmx.com>
To: Viresh Kumar <vireshk@kernel.org>,
	Nishanth Menon <nm@ti.com>,
	Stephen Boyd <sboyd@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <len.brown@intel.com>,
	Pavel Machek <pavel@ucw.cz>,
	Alex Shi <alexs@kernel.org>,
	Yanteng Si <siyanteng@loongson.cn>,
	Jonathan Corbet <corbet@lwn.net>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Hu Haowen <2023002089@link.tyut.edu.cn>
Cc: Erick Archer <erick.archer@gmx.com>,
	linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH v2] Documentation: power: Use kcalloc() instead of kzalloc()
Date: Sun, 21 Jan 2024 11:43:44 +0100
Message-Id: <20240121104344.5001-1-erick.archer@gmx.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:dcIaAJexKl0=;cVNvZ5I8HLKLzFl3wr+iiSeDjzL
 1ZON+ViU7WGhvkuahOyp1h4r4UBuqB5OC5CoZKKwsG1t3ScVoXbdxEMrGDINdaObI/WoCFL2N
 yz73p9WbwsWKEb1bUnuHMpn8D+Cq1aiFsgsC3eh1KN7zQCvswg81KyDHFaBio/YQyTnfnV3SF
 rQvuBX/XA0nlCED+HhYizCKdzmMjfYvR873OZ2sj0Hhq3ox8MrSzH6ggRRp6tXERi7I8yMSyX
 UXYWL8aJx1q2BSunW9N6yX7vYWK47xg0IX9xsu2qpwq1a07vibr5Sbb98MoZTCg5QQlRWBKi4
 r0BdM63UJlnzT2r7Q6WjIuwlVOKUxKIQS09Ic8x0Z5tkQz23rr/DBn47Jv+zk3LkF8tUnnygB
 bKgo5JNEpglKudKEiPrIiXHIyTEtTnkKV0LFB2isaMNE7eN785TFi8eq2QU3+NAIlPsvKzac+
 3GAV3gqGjBFMJIznhOqZi84aB+ZixxCv6BsI8G+G3TIHs+QNokU/EhuXiqMK65+Sa5BKNmGhj
 53PB5gpX3YMM0WvL0dZU0VPEBX46yyF2qEljixNezkmjuLYpmHpU3V6lCpjYIINXkuj3W8ibn
 7HjFfvZSppKmaicaMtXY+TF4Dinerdd3AzxV6C7RmEFugH/Ew5fxX+NQ8D+T1AjlycOPFgP+W
 LxxQe719VgGf8Lr/StLjTEFsIu8D78B7RrQw9bXUFL04SNXB1WvIWRZQX0fTwdUGxlcAGRsUG
 iV0UBYtM1KolLlmS5j+ss5Q5Ri2v2un4lO3XLShrul3dQRQ7DLvuVeU5LOTk0fCkzTGXlCrVe
 xpH6lz2ICvF3H8Qm5vZi/cLODrNGUUAs17hARpOGf/SEtVvcVqDgr47gWJmhdKub6Kca2gJeK
 99fmRa8p8Y7ssYFwVh0qaJkgxAS95bnO7Wrdkw9epoRtfZmya3412COH2F9nQTnHZeDtlVXwI
 IP98Awf77QPnCjWVASpMOTlz8PU=

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, in the example code use the purpose specific kcalloc() function
instead of the argument size * count in the kzalloc() function.

At the same time, modify the translations accordingly.

Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-co=
ded-arithmetic-in-allocator-arguments [1]
Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Erick Archer <erick.archer@gmx.com>
=2D--
Hi,

This patch is a merger of two previous ones [1] [2].
As Hu Haowen and Jonathan Corbet suggested, the translation change
only makes sense if the original file is modified. So, with this
v2 version the original file and the translations are modified at
the same time.

[1] https://lore.kernel.org/linux-hardening/20240120120527.3866-1-erick.ar=
cher@gmx.com/
[2] https://lore.kernel.org/linux-hardening/20240120122204.4287-1-erick.ar=
cher@gmx.com/

Thanks,
Erick
=2D--
 Documentation/power/opp.rst                    | 2 +-
 Documentation/translations/zh_CN/power/opp.rst | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/power/opp.rst b/Documentation/power/opp.rst
index a7c03c470980..1b7f1d854f14 100644
=2D-- a/Documentation/power/opp.rst
+++ b/Documentation/power/opp.rst
@@ -305,7 +305,7 @@ dev_pm_opp_get_opp_count
 	 {
 		/* Do things */
 		num_available =3D dev_pm_opp_get_opp_count(dev);
-		speeds =3D kzalloc(sizeof(u32) * num_available, GFP_KERNEL);
+		speeds =3D kcalloc(num_available, sizeof(u32), GFP_KERNEL);
 		/* populate the table in increasing order */
 		freq =3D 0;
 		while (!IS_ERR(opp =3D dev_pm_opp_find_freq_ceil(dev, &freq))) {
diff --git a/Documentation/translations/zh_CN/power/opp.rst b/Documentatio=
n/translations/zh_CN/power/opp.rst
index 8d6e3f6f6202..7470fa2d4c43 100644
=2D-- a/Documentation/translations/zh_CN/power/opp.rst
+++ b/Documentation/translations/zh_CN/power/opp.rst
@@ -274,7 +274,7 @@ dev_pm_opp_get_opp_count
 	 {
 		/* =E5=81=9A=E4=B8=80=E4=BA=9B=E4=BA=8B=E6=83=85 */
 		num_available =3D dev_pm_opp_get_opp_count(dev);
-		speeds =3D kzalloc(sizeof(u32) * num_available, GFP_KERNEL);
+		speeds =3D kcalloc(num_available, sizeof(u32), GFP_KERNEL);
 		/* =E6=8C=89=E5=8D=87=E5=BA=8F=E5=A1=AB=E5=85=85=E8=A1=A8 */
 		freq =3D 0;
 		while (!IS_ERR(opp =3D dev_pm_opp_find_freq_ceil(dev, &freq))) {
=2D-
2.25.1