Received-SPF: pass (google.com: domain of linux-kernel+bounces-32017-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 21 Jan 2024 12:00:00 +0100 (CET)
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
cc: Li Zhijian <lizhijian@fujitsu.com>, cocci@inria.fr, 
    LKML <linux-kernel@vger.kernel.org>, Nicolas Palix <nicolas.palix@imag.fr>
Subject: Re: [cocci] [v2] coccinelle: device_attr_show: Adapt to the latest
 Documentation/filesystems/sysfs.rst
In-Reply-To: <f34231dc-186b-4cb9-889b-b3be9224c5a9@web.de>
Message-ID: <alpine.DEB.2.22.394.2401211159350.3743@hadrien>
References: <20240119062057.4026888-1-lizhijian@fujitsu.com> <alpine.DEB.2.22.394.2401202217550.3267@hadrien> <f34231dc-186b-4cb9-889b-b3be9224c5a9@web.de>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII


On Sun, 21 Jan 2024, Markus Elfring wrote:

> > I subsequently simplified the patch case to contain the following:
> >
> > -              snprintf(BUF, SZ, FORMAT
> > +              sysfs_emit(BUF, FORMAT
> >                                ,...);
> >
> > This also works for the case where there are only three arguments.
> > It has the benefit that the change is recognized as a line replacement, so
> > no extra {} are added when the call is in an if branch.
>
> Would you like to consider the application of the following SmPL code variant?
>
> -snprintf
> +sysfs_emit
>          (BUF,
> -         SZ,
>           FORMAT,
>           ...
>          );

It's ok too.

julia

>
> Regards,
> Markus
>