Received-SPF: pass (google.com: domain of linux-kernel+bounces-32033-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 21 Jan 2024 12:44:31 +0100
From: Erick Archer <erick.archer@gmx.com>
To: Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
	Stephen Boyd <sboyd@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Erick Archer <erick.archer@gmx.com>, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] Documentation: power: Use kcalloc() instead of kzalloc()
Message-ID: <20240121105143.GA4546@titan>
References: <20240120120527.3866-1-erick.archer@gmx.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240120120527.3866-1-erick.archer@gmx.com>
UI-OutboundReport: notjunk:1;M01:P0:rERkRzJHHsI=;z3yEKJpJHmLXTIz240asfeTKJ5M
 p0RBSc5bFwhpJDdkmwWDSxCtDWe772+ijFYA6gHVXjU1c7UO0KBOBvsygol8S9kkTiA6SMKXu
 KbBdmW5zL7f1vl+xEPBOR1UaSesQcAMNguD+/q1NJxihjuuyks4iqhJP8NtUxSIGbu9hBxCC0
 KAc+zLsErk9qX+5FqU5EJ9H58oYe/QK1vcO6/1lHOPAPzRBYUPZPEABcLIXLpY2tycRsKDT4l
 JQXd2oqEwpvXjvszagOL6VZCGjMU5bXT5TPk/1pH6C3K5XPDe+0FzV/j7gFPEMmVJ2RSkxz5X
 8E8+x+6j7rHZ0gQK6GbjPV64U1YeKVtPzlk9AEs/Zu6P37r0LLS5wu2ebnnLpln+2xQIjNOMA
 39ub25PsstoyU/mDAAQR21Clg2fMoqgmRndD+ptPExwRbn2yPlLMFlnfs1s2achgxifzbYMS+
 D2CHIG1u6obuzReOCDELsLboJzyxFEbYyx51huSfgcnr75JEM3IV/BXMuM/FV3GACEsN9/+90
 nPEY1N9T7xZLmCrd7PLCq4W3weEU4u28zmnHu09ujkuiyDCyQ10SON29xpfjhnmgmcOsDJtm9
 tjhkmGmU0Qf7BSN0LtVsX5xtIaX+3JTb57/k1TshCE+/GQaqUH4Z3+PkticFr+EvlHZoR5GtN
 SXaumvWfM6m1YnCoPvr2gvCsHCgLCFo6AZORCxlBj7Jbnl+KJF8nJh17b/0KDJ7rdFSQm/8A4
 umEkVhud8+gp9u0ftgyvBTa0CmFp21zcn4t0RBIgGqWcrdbTWNFQGE1z533XvkPrHevClwKEz
 vrJXuaYWLyyscqSee313ij6cCwwU3WZwMmcv6MvFiH6i3g62EykLaq+4F2LBFnrY/bargJ2+8
 xfPM8+wlkPnDLfHn7fCGs4GkgBgSJSOtuxXsdQznZmfklTLFGfWYgmEbx0P2WpQcsmuSY4eAk
 ZyOyR1unEgqIaTUXYfi58EpNs78=
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 20, 2024 at 01:05:27PM +0100, Erick Archer wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> So, in the example code use the purpose specific kcalloc() function
> instead of the argument size * count in the kzalloc() function.
>
> Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-=
coded-arithmetic-in-allocator-arguments [1]
> Link: https://github.com/KSPP/linux/issues/162
> Signed-off-by: Erick Archer <erick.archer@gmx.com>

Hi,

Drop this patch as a new version has been sent to change at the
same time the translations.

Thanks,
Erick

> ---
>  Documentation/power/opp.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/power/opp.rst b/Documentation/power/opp.rst
> index a7c03c470980..1b7f1d854f14 100644
> --- a/Documentation/power/opp.rst
> +++ b/Documentation/power/opp.rst
> @@ -305,7 +305,7 @@ dev_pm_opp_get_opp_count
>  	 {
>  		/* Do things */
>  		num_available =3D dev_pm_opp_get_opp_count(dev);
> -		speeds =3D kzalloc(sizeof(u32) * num_available, GFP_KERNEL);
> +		speeds =3D kcalloc(num_available, sizeof(u32), GFP_KERNEL);
>  		/* populate the table in increasing order */
>  		freq =3D 0;
>  		while (!IS_ERR(opp =3D dev_pm_opp_find_freq_ceil(dev, &freq))) {
> --
> 2.25.1
>