Received-SPF: pass (google.com: domain of linux-kernel+bounces-32108-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 21 Jan 2024 16:17:18 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Petar Stoykov
 <pd.pstoykov@gmail.com>, <linux-iio@vger.kernel.org>, Lars-Peter Clausen
 <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>, Andy Shevchenko
 <andriy.shevchenko@linux.intel.com>, Angel Iglesias
 <ang.iglesiasg@gmail.com>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: iio: pressure: Add Sensirion SDP500
Message-ID: <20240121161718.32ffcb38@jic23-huawei>
In-Reply-To: <20240116163713.00006bf3@Huawei.com>
References: <CADFWO8EomrhEgtC+i9ikkcDU1c05kx-8kjrS4usAv-TRKxif+w@mail.gmail.com>
	<4eab426b-f654-4e10-9ffa-5b34016565fb@linaro.org>
	<20240116163713.00006bf3@Huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 16 Jan 2024 16:37:13 +0000
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:

> On Tue, 16 Jan 2024 16:31:55 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
> > On 16/01/2024 16:24, Petar Stoykov wrote:  
> > > Sensirion SDP500 is a digital differential pressure sensor. It provides
> > > a digital I2C output. Add devicetree bindings requiring the compatible
> > > string and I2C slave address (reg).
> > > 
> > > Signed-off-by: Petar Stoykov <pd.pstoykov@gmail.com>
> > > ---
> > >  .../bindings/iio/pressure/sdp500.yaml         | 38 +++++++++++++++++++
> > >  1 file changed, 38 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/iio/pressure/sdp500.yaml    
> > 
> > Filename like compatible.
> >   
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/pressure/sdp500.yaml
> > > b/Documentation/devicetree/bindings/iio/pressure/sdp500.yaml
> > > new file mode 100644
> > > index 000000000000..af01ec7e3802
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/pressure/sdp500.yaml
> > > @@ -0,0 +1,38 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/iio/pressure/sdp500.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: sdp500/sdp510 pressure sensor with I2C bus interface
> > > +
> > > +maintainers:
> > > +  - Petar Stoykov <pd.pstoykov@gmail.com>
> > > +
> > > +description: |    
> > 
> > Do not need '|' unless you need to preserve formatting.
> >   
> > > +  Pressure sensor from Sensirion with I2C bus interface.
> > > +  There is no software difference between sdp500 and sdp510.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: sensirion,sdp500
> > > +    
> > 
> > No resources? No interrupts? No power supply or any pins? No even
> > iio-cells? This looks incomplete.  
> 
> For a pressure sensors, io-channel-cells (which I guess you me you
Gah. Gibberish.

which I guess you mean...

thanks,

J
> mean) would be a new thing. We've never yet had a consumer of this
> data type...  Not necessarily a bad thing to have as one can
> conceive of one, but none of the current pressure sensor bindings
> have that.
> 
> vdd-supply though definitely wants to be in here and required
> given device is unlikely to work without power!
> 
> Jonathan
> 
> 
> >   
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    i2c3 {    
> > 
> > i2c {
> >   
> > > +      #address-cells = <1>;
> > > +      #size-cells = <0>;
> > > +      sdp500@40 {    
> > 
> > Node names should be generic. See also an explanation and list of
> > examples (not exhaustive) in DT specification:
> > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> > 
> > 
> > 
> > Best regards,
> > Krzysztof
> > 
> >   
>