Received-SPF: pass (google.com: domain of linux-kernel+bounces-32117-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Erick Archer <erick.archer@gmx.com>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Erick Archer <erick.archer@gmx.com>,
	Tero Kristo <tero.kristo@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Damian Muszynski <damian.muszynski@intel.com>,
	Shashank Gupta <shashank.gupta@intel.com>,
	Tom Zanussi <tom.zanussi@linux.intel.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: qat-linux@intel.com,
	linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH] crypto: qat - use kcalloc_node() instead of kzalloc_node()
Date: Sun, 21 Jan 2024 17:40:43 +0100
Message-Id: <20240121164043.11222-1-erick.archer@gmx.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:LNvvB4XfrQE=;xm4iJMqcqcW3z9pKqpfiRjQ8hgI
 Rq3/8Yg4GQXoma4V9C/vYZsiydDrsdDVkPtyhi1dBGAp+fW6+jS4zsLh+/2TTUrcbtx1sisC2
 YK6Lus7q+ZZxBwmk2gRc3UwlKLYwPubAZvQW5yGeGvXU4jsarDhPtZiUCJUizu3wU4+DmGTLH
 qkq4UE4zv0LRJ7fp3mG9mAcXFQORPegM3Ig2I2IX3/c7HBfOkEhcGduRThA5seorzjI/xFCf5
 NIM6R9OQMTbs0RzuNd0blNsyhbiUb9u2eHIXtm6h6dXE0jo0mqcz7p/GNNsXL1PJsuatjw4Xh
 q/Sl/RcPMw8zEUwiQd+kTC8+hjI8YZl3ugcs6U2YDep/9Flxyp8XfyiFkqdOuAOGaVLUfsOLv
 2IxgOt8LeUEqc4W6AE1hBgFvKqGLt8nL3IOxB+zS7YxadpQoi8zsrc+ZIWurVluJhVPrfvbj0
 h/WyWnrBYi7CqYYYUu8/KigZ+8VD9BPpdkO/tn6HGDNBPlKr5IJgOswKlgNgPr53k+38MoHrU
 VlHVk1y+kgfyMDPvG3yj5bAJf40iAq6UccIrmdS2wkyTzcSAWdxeEHbyd++7nmYl6hXbxAlJL
 auRbtW5pPwKsEVHtCkT45EWRyM4eQpISoqraF20YaZN8QoXf1A0KG6L34XWFQDELirAgTf7Si
 TKszUHhbfcM4agL+t+IkjhT6gL0SsxsUuamxarMjxt20oIKA5fx1HFWBBOV7a8W2uoxEdEsJx
 T8Ao4m4WBm875WIwsOUT7/U6F1ALJqrD42ON/fTTn+kZLDv5DUozay/ANNQ+lBV/3vk4gxWfY
 x7vklLuVYfXcxMk8hEU+JkKSQ24/bWuMhgKqb4+GqFwytu/TqVzJz/+oW4InB07jR62HXy8qg
 IqNH3JW5MWCuHWnX2nA0uSIqRjn61CF0wDI45RTXoOnOfgYuyYYOXuB2V07mCjRC8DjZ907bJ
 Iw9VSum+LtFnAgB+957SAQ30vFw=

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc_node() function instead of the
argument count * size in the kzalloc_node() function.

Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-co=
ded-arithmetic-in-allocator-arguments [1]
Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Erick Archer <erick.archer@gmx.com>
=2D--
 drivers/crypto/intel/qat/qat_common/adf_isr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/intel/qat/qat_common/adf_isr.c b/drivers/crypt=
o/intel/qat/qat_common/adf_isr.c
index 3557a0d6dea2..a13d9885d60f 100644
=2D-- a/drivers/crypto/intel/qat/qat_common/adf_isr.c
+++ b/drivers/crypto/intel/qat/qat_common/adf_isr.c
@@ -272,7 +272,7 @@ static int adf_isr_alloc_msix_vectors_data(struct adf_=
accel_dev *accel_dev)
 	if (!accel_dev->pf.vf_info)
 		msix_num_entries +=3D hw_data->num_banks;

-	irqs =3D kzalloc_node(msix_num_entries * sizeof(*irqs),
+	irqs =3D kcalloc_node(msix_num_entries, sizeof(*irqs),
 			    GFP_KERNEL, dev_to_node(&GET_DEV(accel_dev)));
 	if (!irqs)
 		return -ENOMEM;
=2D-
2.25.1