Received-SPF: pass (google.com: domain of linux-kernel+bounces-32152-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 21 Jan 2024 11:15:09 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Samuel Ortiz <sameo@rivosinc.com>, <biao.lu@intel.com>
CC: <dan.j.williams@intel.com>, <linux-coco@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v1 0/4] tsm: Runtime measurement registers ABI
Message-ID: <65ad6d3db040d_107423294de@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240114223532.290550-1-sameo@rivosinc.com>
 <20240118033515.2293149-1-biao.lu@intel.com>
 <Za1eXWiKPQp//1CO@vermeer>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Za1eXWiKPQp//1CO@vermeer>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mFCBYtJI1t8edombRi1dMrq5pSVy67xos1CG88vm29ygJ6LAwOgNyOwK2YVd?=
 =?us-ascii?Q?7NXoJvwdnRPTwfXWMOlLQPwPtaknk9nMm0tq52md8Q+4DMTpHJokRgKgSj1w?=
 =?us-ascii?Q?ED7f/gdWXVU0f8qoA8i2uIwWxMdK7GR744rl1rCaHiNkTMuGyHFLwSd4TCIa?=
 =?us-ascii?Q?3pxdGtJ9eOq0+whcRYTLNf7Qjx2kQJMfo3NdTQ9wmr6RC9fy69Rjf4Jirkwx?=
 =?us-ascii?Q?LIG1ecS1AyBn3UrAZ4ZdmWcAb679Ny/kWOFnKsP4IOP5m/CyFb+DJLO0FhFC?=
 =?us-ascii?Q?Ww5PIxcqAgQbaG850Mqu2F+1/PNV+ToVaNyqYscmgv5RMwUjAlY5NrYVlQtm?=
 =?us-ascii?Q?hh6oUuBj8+s/OfloLESHZ+SYboNJiUkZwlZXrRFostlAnXkLZQqaLecm9EQ9?=
 =?us-ascii?Q?Q4hP2GIo2a6f+wj+YP5MvxU6TgRp0e3FPkZ9eMssW75o2FJ4TpFBzHobgYgO?=
 =?us-ascii?Q?381FHnyqy3TCU1ge/MZs01CoqFt8LahnDbNUnCmWa1JfGOr8Rfu2ONI0i6hv?=
 =?us-ascii?Q?EoqxkTAnOcBA7dZo6kD4dM2g/E2JzY0TWCFVGNhj4F7WJzvVWKzkBjkk1k90?=
 =?us-ascii?Q?4aUqd8farYlJmw9UoxCbG8iWJrO8IZvIMpGV8es7CvRMpbCmcjkfE69aBpN4?=
 =?us-ascii?Q?mAlnu2M6LYWaZnWp4l4DUL5t2xYRhmoFdTpVugISfjlM+XVtlocpXNmxRQAb?=
 =?us-ascii?Q?lIB9JDNzvchDqc6VV7rMsFuhJC0qcNs3hU2VsDQsrHNoYM8z29kcPe/caD7o?=
 =?us-ascii?Q?lL1hsMPMDg1DyH5vQCIG/cXkeofsFeBs76v9Id28pGIRNlEo4K1tYw0P64rf?=
 =?us-ascii?Q?0CbDK+vXFULcqJfPyWu3Mh0ixVjHOBZIMEVqudkLkZYQA+kHrNnLULoo+JRn?=
 =?us-ascii?Q?QhSA22U+2TcQ7Yt9N+IIzgVLTZIaR/Q+9JZ93EFAgPBhEhVVvv6HVLTLZZc1?=
 =?us-ascii?Q?LtCrxVOH8iFqdHrpKPoF43OuwdHK4zR81EngHsUK0y3C5FikCplmCN4JqV1Y?=
 =?us-ascii?Q?vjqFc12tLppMeZ/4cYjy/ClLBI87JPqlBFHA8ZC4AxH7Ct5fjLku1EKg4N3O?=
 =?us-ascii?Q?2EiK9lO/j926kfX+by+ICTFLalqHchrnKv1+nrgywU2VHPA/L7UTFxAgb1oY?=
 =?us-ascii?Q?elkIEniU4UcYER28ZO9jpsCfgnaEKNdGkm6GsY+g8TGE1L5PPVCIrkuINNhX?=
 =?us-ascii?Q?QZNEvOhHoipBltqGo3hXtvejF8fy2fYNokgnfcW0DKcz5HEZa6MPc156vk17?=
 =?us-ascii?Q?1nllN8eDmoZtzfBVWZUnPVOnfTdZHtlVWLFaKoaf/drLSfnQRKzxEBJYlFJK?=
 =?us-ascii?Q?F1Lb9An6ADEQWN9fbepQXA82EvMD/MPFA8nPuQ4axU00sGAYnymqA2TINjRT?=
 =?us-ascii?Q?QjysrP/eNn+wJ6PiQM+GHH0HuystYFdYHmsO8126s2OP6tDOLQ+C70zBheeD?=
 =?us-ascii?Q?lkupI41bQROg0vCP+8RX/nl0wGSLZ98Ov6RPHc1TFGcWunz6IJzfFNBPrEiE?=
 =?us-ascii?Q?mlvXHfr6n7zwCHeA9kx4sJWGSH8Iw/QVy2LPLEe/dDS/fjfDPN7TwLuI9arx?=
 =?us-ascii?Q?eYGblWAZ6DhgxCjDhYdUOGljMstCSpZTppcsLFvOfwRurW9gwvUkrg1U6SxJ?=
 =?us-ascii?Q?pg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a88a9ed-2cc2-4a51-ef5c-08dc1ab54a35
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2024 19:15:11.7632
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sBoe0g+g1v1jokyxCkdO2lWjR+lNWJrMhtS77FZesofeSrUchkO3qw6SFNe7CalEi4py5sxgK0O5shQWJQDvBpVV8hrzNpg45azO6t49Zk4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5775
X-OriginatorOrg: intel.com

Samuel Ortiz wrote:
> On Thu, Jan 18, 2024 at 11:35:15AM +0800, biao.lu@intel.com wrote:
> > Samuel Ortiz wrote:
> > > Some confidential computing architectures (Intel TDX, ARM CCA, RISC-V
> > > CoVE) provide their guests with a set of measurements registers that can
> > > be extended at runtime, i.e. after the initial, host-initiated
> > > measurements of the TVM are finalized. Those runtime measurement
> > > registers (RTMR) are isolated from the host accessible ones but TSMs
> > > include them in their signed attestation reports.
> > >
> > > All architectures supporting RTMRs expose a similar interface to their
> > > TVMs: An extension command/call that takes a measurement value and an
> > > RTMR index to extend it with, and a readback command for reading an RTMR
> > > value back (taking an RTMR index as an argument as well). This patch series
> > > builds an architecture agnostic, configfs-based ABI for userspace to extend
> > > and read RTMR values back. It extends the current TSM ops structure and
> > > each confidential computing architecture can implement this extension to
> > > provide RTMR support.
> > 
> > Hi, Samuel
> > The ABI does not include eventlog, but eventlog is usually used with RTMR.
> > What do you think about how to implement eventlog?
> 
> Since the event log is typically maintained in the firmware and not in
> the TSM itself, I don't think we should expose e.g. an event log
> extension ABI through the config-tsm one.
> We could decide to check for an EFI CC protocol availability and extend
> the event log when any RTMR gets extended, and that would be an
> internal, not userspace visible operation. I'm not sure that this
> would scale well with e.g. IMA (a lot more events than pre-OS boot
> afaik).

Another observation after chatting with my colleague Cedric is that the 
TPM layer that builds on RTMR can maintain an event log that forks from
the RTMR log. I.e. instead of the TPM event log containig pre-OS events
starting from 0, it would start from a golden point in the RTMR
measurements.