Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp2214931rdb; Sun, 21 Jan 2024 12:23:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTWjv0WmAee2pM37LLt2ZQcxI+YySl1omVxeqpv/WSiUqMfLW/n4PZ1Y98Nk49QQne+vzK X-Received: by 2002:a05:6358:904e:b0:175:64c5:a900 with SMTP id f14-20020a056358904e00b0017564c5a900mr3471469rwf.60.1705868634434; Sun, 21 Jan 2024 12:23:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705868634; cv=pass; d=google.com; s=arc-20160816; b=ql8hiz2N+2Kbse0NYWsJawijxEa1l4JJcketyKMPuEXhm+1euKaQsw+SLtB2ZCxQNU 2fOnifgI5Z6aqFIBl03FEqwlU1YAOMskpyxPQIxHNoaaWrJAVUALkrsdTQSf2O8jsO2n MIis1wDmuaRGrwotrl5JfasbwyK26HstCtT9aFoC956e/8eYE/MRPbnbAxtYXjPTDc+t LSqf3jbfwGrc2ZcFKeCSY4Yi1j0SvEkFwn0UYkkz17vtx1zwyLFA4AWWDxES9pdn9qhf B533oDT+sOI+1wx69YA9l3Aq6ohpDVBxKW0a78xStU0GFY3g3MLRZBrYw8Fd3AV7aLo1 QzIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=BK3kTu4rO51T+6hQ0GXL+VPtTV0TrbToYj9UeX6NjHI=; fh=Qx5rzi8t3OT5ySocIjA3t5+6Tsi0+E8yCSHJz/2Qnxg=; b=hXBen4XtwzMAU3mjPn2y8NaPNgU1orV2nnmKkzCj9n8xbbzVRkVCxvuT9pMhIP5qIn DQB/Yv+Ufx0FHnQW51lvU1evoOmZQCfuCPQ1+l0WHRRv7XFmRWxa/3Nv7aA4PICeRulj NlJCIKmtQz/10o6I9E5y+LUbU5nLLI10d7NVwxcpJAwzunLXSTuIxPRl4N1za2jL3O88 QKmZZUC/k59jNEdyDDF3gk0rvYjAhVz7qf7RBvc+xKbTdPntVM9WBqnrjAyYAr7Ucm44 W3jWIs7YaQViodaoOyz5MB5Wzg+wJMdd4le2TaFhWT10kgl6e8dVR1p5nIDFSj2i/IRT EZJA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=S8SHx6hP; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-32177-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32177-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ci7-20020a17090afc8700b002900b3297dcsi5592968pjb.69.2024.01.21.12.23.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jan 2024 12:23:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-32177-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=S8SHx6hP; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-32177-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32177-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0AA51281C77 for ; Sun, 21 Jan 2024 20:23:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 077E9383B5; Sun, 21 Jan 2024 20:23:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="S8SHx6hP" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2C8B37713; Sun, 21 Jan 2024 20:23:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705868624; cv=none; b=SROCfzbm1RxhiIgC78WnJR7xk8EldelTXeRY+MklvNEiFu+xQ1JB4akeDYJJeYSfA9x7mBsNgGIPW4WwaXNnXc84wXEaehH87HBdi2mvJMu0J6TOe8uqJxDgQPVmad+mfV/klkvNDU26nGLPKwMsrcIpYK0w9fDXkmO3WmQUbCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705868624; c=relaxed/simple; bh=b1pZyK7FsCUmhPlvju8roc6IUuWpgZNleb3xFjmFVeo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SyBOzSi5w9Cuvfl+AqHKx6A2lrpeQFf9PHWTuyPxwcwI+4T/fpucrvGlQ8iS4deOt0w3EGh3jOfAWKloazv9UETdXF7Ax07jx6sPZugGFf/bZzbn50bmTzS5Wq1Lz58m1y7jxlTZiR6IqsCKG79g8c/5CO2rEw/DVt5d2fBJOww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=S8SHx6hP; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=BK3kTu4rO51T+6hQ0GXL+VPtTV0TrbToYj9UeX6NjHI=; b=S8SHx6hP8PBi2zrMN88BCDT3ma dbfiNVqGFMe40xW7EkpU8oIc39ujKK+0joAWNuDXA6N7eAN624FWu9nclqZ0AQDfwb3vdKPsbVqSd 0/Z2jS5L0mTHBoCynuaZ/VyBgcN/1AJzP8te62cA0Fjr0mhgpcBpj6rdVFF12NQUd+9w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rReLe-005fbq-75; Sun, 21 Jan 2024 21:23:18 +0100 Date: Sun, 21 Jan 2024 21:23:18 +0100 From: Andrew Lunn To: Andre Werner Cc: hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC net-next v4 1/2] net: phy: phy_device: Prevent nullptr exceptions on ISR Message-ID: <645d928b-cd8b-42d0-9f68-fb9b05769cfa@lunn.ch> References: <20240121201511.8997-1-andre.werner@systec-electronic.com> <20240121201511.8997-2-andre.werner@systec-electronic.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240121201511.8997-2-andre.werner@systec-electronic.com> On Sun, Jan 21, 2024 at 08:54:48PM +0100, Andre Werner wrote: > If phydev->irq is set unconditionally, check > for valid interrupt handler or fall back to polling mode to prevent > nullptr exceptions in interrupt service routine. > > Signed-off-by: Andre Werner Reviewed-by: Andrew Lunn Andrew