Received-SPF: pass (google.com: domain of linux-kernel+bounces-32204-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Frank Li <Frank.Li@nxp.com>
To: frank.li@nxp.com,
	mathias.nyman@intel.com
Cc: Thinh.Nguyen@synopsys.com,
	balbi@kernel.org,
	devicetree@vger.kernel.org,
	gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org,
	mark.rutland@arm.com,
	pku.leo@gmail.com,
	ran.wang_1@nxp.com,
	robh+dt@kernel.org,
	sergei.shtylyov@cogentembedded.com,
	imx@lists.linux.dev
Subject: [PATCH v2 2/3] dt-bindings: usb: dwc3: Add snps,host-vbus-glitches-quirk avoid vbus glitch
Date: Sun, 21 Jan 2024 17:24:27 -0500
Message-Id: <20240121222428.3396428-3-Frank.Li@nxp.com>
In-Reply-To: <20240121222428.3396428-1-Frank.Li@nxp.com>
References: <20240121222428.3396428-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?5jPHQSlzNqx2wA+fBBd/L7yZSYigDKsl3GRluCk0VBQh/9MpATP8kdJ7Ubyw?=
 =?us-ascii?Q?OKAvT/4Hx9p6NZuuLYFGwXVlZwQJjBTmkX+UZwL3JrS/ut7rfpsxZ8/+EwBH?=
 =?us-ascii?Q?lTGQOQIUpWiAkEYO4/n1MDgFebaQfVRoJ2vXuQ0S27giHEbflqDkZbvky7Nw?=
 =?us-ascii?Q?sqU2KwyKnI3ndlcOCDCvr7wQMl2XA1Z4XR+U3D/FWj+KKxfKW6Al5jDLWpg1?=
 =?us-ascii?Q?FYGu9TaE3biaGlWI70pXwIyfhTWozhuA4NGD6Xn2k/Q9EL24iVQtI64JMBF4?=
 =?us-ascii?Q?YTSWPUpjOcCBFtmPUDv/1F9LfuiWbJoe1p3RsQI4VJdsrmx6Uneasy0OJUJG?=
 =?us-ascii?Q?Qt4qJHZ+/gDtPWiUJdoSnhVgU99M94tGPnuR2Qg5WcU7qxO/mc8nE0tV4iRT?=
 =?us-ascii?Q?8e0uL2QBB5UyEjsM55e0lfktWKYy1nVoR6jmarqpprn6jvWZDqSbUb/xAcO9?=
 =?us-ascii?Q?zNhv9dBUQCQ0cvKhZ7KPCxEL0P6D24F2CBFmZXbFD6Ub1yAnf/nVkT5CgNaa?=
 =?us-ascii?Q?sz5/rE6pHaI60iBKxcDAiY/cjZCXOEkD0QkkkJl19kGXxBSjd8vp5R6nBU/i?=
 =?us-ascii?Q?3MWIQ3fFXRW1O3Y/sdHDcXUwyLAXyh3WONtQ2FmiKxQsEMcG4cVrSa4QWuuc?=
 =?us-ascii?Q?JUYuPi8/9wMOL3btrbQYTs1ILUGHec5r7E7xCkC3teNjBynN514xnn9bY/2u?=
 =?us-ascii?Q?gKdel/oQn7RRk+hdAG0FsvSmXs3yOWGMQYwfpGfvMjt16toOw+EoKxcTQVCk?=
 =?us-ascii?Q?tq4GMYDAcUjGs01QC7uTyamWcE7Dr9N33wcqsdGohXbxQ6rBH7E3xbc+Q4Fs?=
 =?us-ascii?Q?YIoEUR63IDs+QmtyQYi0YgKol3S1qfiA/Ea+N7wynQPS6S/UyRURWLnYDwLV?=
 =?us-ascii?Q?jzSTFhLbH4NagJFW7BY9H0B8FvZA96u/+nu/cGAEXtZOOgXw/y0tBKCPrZlS?=
 =?us-ascii?Q?4gSaQsFJsrfnTamM8X2BWubSxzFBbb9xZ5B9lfaRj2xvG+kVY94mNb2/TA2t?=
 =?us-ascii?Q?vuGo+pBr6oyzfnaNm/kU5WmPglb12C17vjlNuxNV3zr3SyHMP7KPgjbWiLAF?=
 =?us-ascii?Q?4734HHJNge1V2XruOowM1ep7X1rDjBkYPcdHMRo8tz/0nTQDPRffZu4v9c5r?=
 =?us-ascii?Q?nrmcqEd6WrbrZcvsgrn30G+1CMggNXOZVNs78jgpCdFrwJRoBuNCo0wefZAI?=
 =?us-ascii?Q?t4jk1svSlBYMvj2dY42bLQ1Si7PYM6/yLx54Fnif/4+UGt78LRS6i2eSWl5H?=
 =?us-ascii?Q?ttTxLJ/8RVRBefV4YniUX/SchGmMsLg8NEtFkpR8kfPai3gigHi+aE2zI/yl?=
 =?us-ascii?Q?ufaOrfTrwhYff09GtHU3+D+W2goTS3TuxAR0RXmTSB/roeRkTzV13VZi0Jjb?=
 =?us-ascii?Q?SHWafY7v/aOhTDQYkyJ2oWl7vdaOMbsE88/sYOvcQWD8JQrA124ZKgZEhlsI?=
 =?us-ascii?Q?clh+XDJa4h9YHD4YVkDpfgBWzDDb5sX1bPUG++xAI8fQTC5zU+zJUd5RqTbF?=
 =?us-ascii?Q?dwp8Ut8OAQeSD55U/8NwSN5BVLed//cs8FYj2rBK8vGWY2l1fcgGGsvRLA2d?=
 =?us-ascii?Q?zXLJIIQtU6KlZ9CNo2U=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c59cf9b1-3371-4ac0-f40b-08dc1acfcafe
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2024 22:24:54.7544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ilwekou36ExUzkwM3+2BY6wKytfs1/4s2dGMfKRjwCdJL8nbKB+8GOIf/sy7a5iMyTs4ewQaOZSh24w6yshCRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9074

From: Ran Wang <ran.wang_1@nxp.com>

When DWC3 is set to host mode by programming register DWC3_GCTL, VBUS
(or its control signal) will turn on immediately on related Root Hub
ports. Then the VBUS will be de-asserted for a little while during xhci
reset (conducted by xhci driver) for a little while and back to normal.

This VBUS glitch might cause some USB devices emuration fail if kernel
boot with them connected. One SW workaround which can fix this is to
program all PORTSC[PP] to 0 to turn off VBUS immediately after setting
host mode in DWC3 driver(per signal measurement result, it will be too
late to do it in xhci-plat.c or xhci.c).

Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index 203a1eb66691f..8f5d250070c78 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -273,6 +273,13 @@ properties:
       with an external supply.
     type: boolean
 
+  snps,host-vbus-glitches-quirk:
+    description:
+      When set, power off all Root Hub ports immediately after
+      setting host mode to avoid vbus (negative) glitch happen in later
+      xhci reset. And the vbus will back to 5V automatically when reset done.
+    type: boolean
+
   snps,is-utmi-l1-suspend:
     description:
       True when DWC3 asserts output signal utmi_l1_suspend_n, false when
-- 
2.34.1