Received-SPF: pass (google.com: domain of linux-kernel+bounces-32262-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <CAKLYgeJ1tUuqLcsquwuFqjDXPSJpEiokrWK2gisPKDZLs8Y2TQ@mail.gmail.com>
 <39e3a4fe-d456-4de4-b481-51aabfa02b8d@leemhuis.info> <20240111155056.GG31555@twin.jikos.cz>
 <20240111170644.GK31555@twin.jikos.cz> <f45e5b7c-4354-87d3-c7f1-d8dd5f4d2abd@oracle.com>
 <CAKLYge+x9kxLBaJGyk_gTMK2kQ=+Lhg00jgXe=P=jmBUq=cmfA@mail.gmail.com> <7d28b18c-3477-83ec-ef89-cdaf6ca7ebee@oracle.com>
In-Reply-To: <7d28b18c-3477-83ec-ef89-cdaf6ca7ebee@oracle.com>
From: Alex Romosan <aromosan@gmail.com>
Date: Mon, 22 Jan 2024 02:46:18 +0100
Message-ID: <CAKLYgeKjkCJ2d0_5uDaH6C7wc4YpX9s6TnQVNDuSr8MsiYbujw@mail.gmail.com>
Subject: Re: [btrfs] commit bc27d6f0aa0e4de184b617aceeaf25818cc646de breaks update-grub
To: Anand Jain <anand.jain@oracle.com>
Cc: CHECK_1234543212345@protonmail.com, brauner@kernel.org, 
	Thorsten Leemhuis <regressions@leemhuis.info>, linux-btrfs <linux-btrfs@vger.kernel.org>, 
	Linux kernel regressions list <regressions@lists.linux.dev>, linux-kernel@vger.kernel.org, 
	Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>, David Sterba <dsterba@suse.com>, dsterba@suse.cz
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 22, 2024 at 2:35=E2=80=AFAM Anand Jain <anand.jain@oracle.com> =
wrote:
>
>
>
> On 22/01/2024 08:07, Alex Romosan wrote:
> > update-grub still doesn't work 6.8-rc1
> >
> > so i did:
> >
> > # cat /proc/self/mountinfo | grep btrfs
> > 21 1 0:19 / / rw,relatime shared:1 - btrfs /dev/root
> > rw,ssd,discard=3Dasync,space_cache,subvolid=3D5,subvol=3D/
> >
>
> The latest Btrfs kernel expect one MAJ:MIN for a block device,
> but multiple nodes here point to the same root device:
>
>    /dev/root MAJ1:MIN1 \___ root-device
>    /dev/sda1 MAJ2:MIN2 /
>
> To fix, I'm exploring communication through block-device nodes
> with a temporary signature tag on the superblock for identification.
> Community feedback is pending, and potentially synchronization issues
> maybe a concer.
>
> > the difference from your test case is that it doesn't reference
> > the disk device but /dev/root which on my system doesn't exist. could t=
his
> > be the problem?
> >
>
> How are you reproducing this? I tried with Oracle Linux (OL), Fedora,
> and Arch Linux, but they didn't show /dev/root as the root device.

i'm running debian on a lenovo x1. this is my /etc/fstab

# <file system> <mount point>   <type>  <options>       <dump>  <pass>
# / was on /dev/nvme0n1p3 during installation
#UUID=3D695aa7ac-862a-4de3-ae59-c96f784600a0 /               btrfs
defaults        0       0
PARTUUID=3D43094f42-5f54-4456-9d14-3c41e92326e1 /               btrfs
defaults        0       0
# /boot/efi was on /dev/nvme0n1p1 during installation
#UUID=3DA4A3-9199  /boot/efi       vfat    umask=3D0077      0       1
PARTUUID=3D05e00aed-a6ad-4cdc-9a40-4b775dbf87a9  /boot/efi       vfat
umask=3D0077      0       1
# swap was on /dev/nvme0n1p2 during installation
#UUID=3D6b9a36ed-14d8-458d-8575-c8d29dc80bdf none            swap    sw
            0       0
PARTUUID=3Ddb40aeb2-88b4-46eb-970f-58a410bf272e none            swap
sw              0       0

i'm running my own compiled kernel without initrd. the disk with the btrfs
filesystem is the only disk on that laptop. i'm just booting the kernel
(everything works fine there) but when i try to run update-grub i get:

# update-grub
/usr/sbin/grub-probe: error: cannot find a device for / (is /dev mounted?).

--alex--