Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp79632rdb; Sun, 21 Jan 2024 18:34:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHn5tU5IFWINEp/XUWOgYeqDUa5FzbhDpKMOSFnzxe3/45LnKia2txXBjiwc99kU5VLB1ku X-Received: by 2002:a05:6a20:7187:b0:199:a725:9b59 with SMTP id s7-20020a056a20718700b00199a7259b59mr3177211pzb.114.1705890851552; Sun, 21 Jan 2024 18:34:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705890851; cv=pass; d=google.com; s=arc-20160816; b=Xiv+bTK6TafShgNsPoiwefG+aemhq7oK17fM7WuwehsputQtE6vNf8N41dsbE5nbZ+ 9c4UJeL2Gm/c7ofVqFTpKQJDu4lr5UivLKpEQTd7xiBRE+9WCbD1k9f64MFzgd41yHEM 75EbjPQ7PRE37NyueyjqroPGHiF3ZsPg9S9rKg4guDuSxsSBV7p3pUgbDrmkwM7RELRQ YMa1hOjsrP6zM7u4xK/6FNhqfKhPgPEzs1sxslNGR6YzHUZlVEMV26WHmedkWOBuzFPB /Fo794687AOXFPx3tbgOlwg8M+s7svAuT7Qy7A/VKp5XN/mNXiIqVoaWghNfxcTaKLQm uksg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=Y8ZAkSZPuVeAXfWGukIrq42qR8CkdhknoCkyQ+rp9eU=; fh=zQ4KyqolXqQO+yNFGVuXxCeSvQq3rubOak+k9IB2PKU=; b=kMOarp7/cXcXiPMJXMz7gT7bek/h8KlhwWdfdV/CyzfiPbf5rxVQdvw2eaJ3delq4b wt7ENeRU+73cRR0mm4J0EfrBGJn5+ZpTiKqxgkTEjWryicWVhj94sBSZGrvMUwmT2vXk 26TrV3i+awmp8IrAluph3Wb/4mhzfllFp09YkdCdLG16ZGMvkFNl4p4SVmxw1ufUrGs7 1Py27Nq/gvRRRSYEpdrcPDRrbAZUFJPJ/2vsIRTvDd165wABeREj9rfKqlMdZ4p47hDa kQJhobDUPc2MzgTJyMaKzRVbHhWcGJ7nseqCNjFPK9hpHcRWyebT1jWvH6m2vi+G9qJ2 FkNw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CjKh7hPc; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-32281-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32281-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id mh1-20020a17090b4ac100b002907a178c9bsi2635099pjb.167.2024.01.21.18.34.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jan 2024 18:34:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-32281-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CjKh7hPc; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-32281-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32281-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2C6A32825AA for ; Mon, 22 Jan 2024 02:34:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B9E7B4A39; Mon, 22 Jan 2024 02:34:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CjKh7hPc" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFD114A28 for ; Mon, 22 Jan 2024 02:34:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705890844; cv=none; b=rTjjb0jCN8kVGT6UjD7dQqJNEhjWYBW7MqwZJmE6we2UaxD0SQHRRmE1EkEHDSs/58bmLk25/ORoa+CoZ1F44wgBzPFx0faxmo5wYsQOPNYEYrxrVTL6VmMynwVdjQE43txpbtK/tiYcURZIldHd4zP+M/i6shD+zNJ6zt4GyXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705890844; c=relaxed/simple; bh=UwYjuWCbVnv0zBlVv4pkaoZN54Ie0tuuwcikr3lhwrs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sa9CZZhfTrAmbV8fAsXt/IdNokZq1lRnYFnXqvih61EmVzKzVWbKFEpUZ3yp1/Poz3HEfTPeUpY2Tresj/GTRMTZ5n8ikayNVxSsCP0pkt03y3mJe3a21+AmCkGTvFXnTPcy4YQqslrtfkELE8skaBjC5RmVW1gAb50oc1Ykmns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CjKh7hPc; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33838C43399; Mon, 22 Jan 2024 02:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705890843; bh=UwYjuWCbVnv0zBlVv4pkaoZN54Ie0tuuwcikr3lhwrs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CjKh7hPcTBDqHYMLfNQpz9/Z2qZkvb93qRtGT0X+yAP9NvycurHw06E5cXy99DsOt hNw9CvjJe/vGBGbTDCIRRYp9ll9benWf8kxXNYG7dG9B/oodaNfmcuE7KF0dPhOAg8 60SHvHtZlnWLq6rRfLoCi/xfj/ColIugpe9B9s8MWjmTOjK/Uq34JSTbhfu5Qn2CJ+ IficEbrANFTUzdWQN2ExtDnrtYhrskuKeT6+xBIPMUTzAtiEQ9+Q2905JSalG2qqwM dGnKANcb/LnUzKIQrbpqxQGUnBZCbQv0UE3gFGfe6YBpl+W1V7EateITjXKhzTaR46 aRIb2kUbTuDYQ== Message-ID: Date: Mon, 22 Jan 2024 10:33:58 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] f2fs: use IS_INODE replace IS_DNODE in f2fs_flush_inline_data Content-Language: en-US To: Zhiguo Niu , jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, niuzhiguo84@gmail.com, ke.wang@unisoc.com References: <1705478398-10890-1-git-send-email-zhiguo.niu@unisoc.com> From: Chao Yu In-Reply-To: <1705478398-10890-1-git-send-email-zhiguo.niu@unisoc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/1/17 15:59, Zhiguo Niu wrote: > Now IS_DNODE is used in f2fs_flush_inline_data and it has some problems: > 1. Just only inodes may include inline data,not all direct nodes > 2. When system IO is busy, it is inefficient to lock a direct node page > but not an inode page. Besides, if this direct node page is being > locked by others for IO, f2fs_flush_inline_data will be blocked here, > which will affects the checkpoint process, this is unreasonable. > > So IS_INODE should be used in f2fs_flush_inline_data. > > Signed-off-by: Zhiguo Niu Reviewed-by: Chao Yu Thanks,