Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp98110rdb; Sun, 21 Jan 2024 19:40:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNgWwTEvEBbVE0jJU06rRRylOaRjUn2vwUvsGFD1cSGS9/YmDRAiecimi4TuuAFq9Zoo01 X-Received: by 2002:a17:906:3b96:b0:a2c:a9c3:e405 with SMTP id u22-20020a1709063b9600b00a2ca9c3e405mr1734475ejf.127.1705894845047; Sun, 21 Jan 2024 19:40:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705894845; cv=pass; d=google.com; s=arc-20160816; b=t3uqhBX9NbEQHt5C6X8MHS+0DixMieuIOTbBQTqncf4N/VE2ufdchpfh7LwOC3V6u3 sRgxqJMtl30w01UtdO5tGZ4x28Ec7zxvofrF7IsT53dpBNEGVEMcSPc5jsw9zrU6axNz a79Ug70FfQdg4eevnLtM1pWhISpeqRtNePoXi5a85FMuF3DO9rv+MCREX5GyGuZdS2P7 hejgYpVBefnGqC0wBTon+Z4vkXc3hy6n/di+eXgYQo/a8vC62ofOLV1yR/Fa3YObG58j 7tF4m6EcB0Cs1mVW5IGFkzQuh75NExcE5cXVAvv9KD4VLc8TlIMAZISVd1WiPXBzySnP sGJQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=S5KdSBGo/OQbzXmjf/Oy55uC4cHDaOjB+p3jTQZ1gGA=; fh=2HlWI7Ofih2joQJnPJybCTnbA0iQu/NUOf+BfBa3weY=; b=n2wXR4jhl45VhJIdjvFaCgr9lzC68W54i/78f83ryVuVsko8oFJxF7kibxY2TD5Kex UDdp7ea2z7loc2yI9LQvkCijxDf8CeLUAq5hzWqtpfg2my/SNHuHTdROIYYeXjcqQnch ggVJHa32dOOOInXUMuIVda3kMy0je+oBp4zHVgmw2VusY2DKzj2udMpqFpdzKEIoG1St vHQ/aqCM4F4GzB5t76SzgDwz4nhcdqia1RJ5k6TmqJ9TkTKfg1muTVtxeD2wnubXoZpy a2FPlCWMfAs2IxXr8Sg0mlirdlTw3Ddz8ZwgCjUJ3I2gozqe+FyG+1XFIZYDtCOHKqFE hlSw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RgnVhY6d; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-32305-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32305-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id p5-20020a1709061b4500b00a2d357afac6si8137883ejg.300.2024.01.21.19.40.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jan 2024 19:40:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-32305-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RgnVhY6d; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-32305-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32305-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CD43B1F238E1 for ; Mon, 22 Jan 2024 03:40:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AFFD91865; Mon, 22 Jan 2024 03:40:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RgnVhY6d" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 750DF17F8 for ; Mon, 22 Jan 2024 03:40:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705894837; cv=none; b=Y/JIIhcE0kQ6e0eTT75Z76kqoyOdz6RJ96GrERqK8g+BwOShRMpTq479S4m+ZDHDGW7qcLlqr849svpxDpW2qwFZUHkqehhGQ40EJZXAHJUUyhIn26Nee+SK9Vxqndq9eSutO5N2zQuIEucBKHfuCUjcEP3i0TYBQT/AFzTiV3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705894837; c=relaxed/simple; bh=S5KdSBGo/OQbzXmjf/Oy55uC4cHDaOjB+p3jTQZ1gGA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=YukE3kPlqhCp43J2z3Xr+CKwBZbdrmj3l1thEjnsHqkMfaKJt3FRWCfbA5XeCc5lt4rQLds+GoyVn4eEOEfrti3L1NLRK/OopP6n+0ur94L9QiMoCKN4T5+WvkB1t4rOr0NdlNY/NIzY+snypNwnvLuIXCYyIXKgQzfzPoyAVSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RgnVhY6d; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705894835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S5KdSBGo/OQbzXmjf/Oy55uC4cHDaOjB+p3jTQZ1gGA=; b=RgnVhY6dHWB9jANk6aj0dwbmpSdMNYWK9Wua9lSKFiTXskILcBzkQcL9/a3DxVuoKTtlqH WSOktLQl6Al8YMGeHUG9+cn4OXrbVx58EXNsJKQLT4/QX2sKAg/NgqE1nOYX/1+zExMCZ+ 5ufJqeM6VDPUp+omfhEANIziqF692wM= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-204-pTgLdHi8NjiA4L6AYSP2DQ-1; Sun, 21 Jan 2024 22:40:33 -0500 X-MC-Unique: pTgLdHi8NjiA4L6AYSP2DQ-1 Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-5993598d215so2432368eaf.1 for ; Sun, 21 Jan 2024 19:40:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705894832; x=1706499632; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S5KdSBGo/OQbzXmjf/Oy55uC4cHDaOjB+p3jTQZ1gGA=; b=w+SZFy8Pm6jaJT/hR0WaP6jAWjRXH/8cOVXkKk9SzqiAe8qgjrzftNO9IdLeKwzEMd MjIFcBEsAzDFobR/X7xaxkShyY25Ic+W0IjDt4L9aPy/ayOrw8EOArAwnOx3SK1lK6uG 6/mR7fi3YVSvYQM66wQNYBury9BvzYyBE5Hvqrb8xdQcEzSjL5QG9J/pRAeieSqSNJOq 4yrsustPdZbuArk8n8MYYeatR+GqNVSGkL/S2VjEpoRK6iXmVj7Enri4PHBDykVVCNqO svq23SlgG79BJLQgSblI08xf1PkZVVeDl2dWV+SpfQdnglzmrPhJzbDyQqYrO6oRqJkv D1og== X-Gm-Message-State: AOJu0YyuKm+6KJaS37YbUg66pq42q2AkcgT5eltOA3agjCrsYlZDVN0X 5jFJIWHu5yDPr3QeQc3eiMpJ6y0SUWY8RejOsirXYpVC9m6wd+JT+3IakRqJKBoq7Os4SHGE3Jc QpyhZabcm4YUHPETEqv9aikCh3P7sCwkMF7uARQMEhho4ZO3++eOcUHTT/mGRgRvlcHOH/PQDrm OnIKcW6xLJE+Vr4m7WsEz4cNuvt1w6QnJED2hH X-Received: by 2002:a05:6358:6f97:b0:176:2c3d:fb35 with SMTP id s23-20020a0563586f9700b001762c3dfb35mr1884394rwn.20.1705894832475; Sun, 21 Jan 2024 19:40:32 -0800 (PST) X-Received: by 2002:a05:6358:6f97:b0:176:2c3d:fb35 with SMTP id s23-20020a0563586f9700b001762c3dfb35mr1884382rwn.20.1705894831978; Sun, 21 Jan 2024 19:40:31 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <1705659755-39828-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1705659755-39828-1-git-send-email-wangyunjian@huawei.com> From: Jason Wang Date: Mon, 22 Jan 2024 11:40:20 +0800 Message-ID: Subject: Re: [PATCH net 1/2] tun: fix missing dropped counter in tun_xdp_act To: Yunjian Wang Cc: willemdebruijn.kernel@gmail.com, kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xudingke@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 19, 2024 at 6:22=E2=80=AFPM Yunjian Wang wrote: > > The commit 8ae1aff0b331 ("tuntap: split out XDP logic") includes > dropped counter for XDP_DROP, XDP_ABORTED, and invalid XDP actions. > Unfortunately, that commit missed the dropped counter when error > occurs during XDP_TX and XDP_REDIRECT actions. This patch fixes > this issue. > > Fixes: 8ae1aff0b331 ("tuntap: split out XDP logic") > Signed-off-by: Yunjian Wang Acked-by: Jason Wang Thanks