Received-SPF: pass (google.com: domain of linux-kernel+bounces-32307-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID:
 <MA0P287MB28225C6758E08536CC495B48FE752@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Mon, 22 Jan 2024 11:41:28 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 2/5] dt-bindings: soc: sophgo: Add Sophgo system
 control module
From: Chen Wang <unicorn_wang@outlook.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Chen Wang <unicornxw@gmail.com>, aou@eecs.berkeley.edu, chao.wei@sophgo.com,
 conor@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 mturquette@baylibre.com, palmer@dabbelt.com, paul.walmsley@sifive.com,
 richardcochran@gmail.com, robh+dt@kernel.org, sboyd@kernel.org,
 devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
 haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com, guoren@kernel.org,
 jszhang@kernel.org, inochiama@outlook.com, samuel.holland@sifive.com
References: <cover.1705388518.git.unicorn_wang@outlook.com>
 <598b1026fdf9989bc48e5e10d1034b37947d3b80.1705388518.git.unicorn_wang@outlook.com>
 <f4a46311-2e12-458b-98a8-d3caa2c95517@linaro.org>
 <MA0P287MB282232DC6DF6290F5520BA89FE732@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
 <MA0P287MB2822FBA18674540BA85035BDFE712@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
In-Reply-To: <MA0P287MB2822FBA18674540BA85035BDFE712@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MA0P287MB2822:EE_|PN3P287MB1618:EE_
X-MS-Office365-Filtering-Correlation-Id: 7d60b22d-8026-4752-2020-08dc1afc0936
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	f1XtjZ8A202dczqQKLKNCiQ71/F2j6OG5d8K4Ca+EfPJWfvMvuYJQ6kirX4vhy5JfgTg3l4Iuud7zSXm8GEBNZe44tlCXiNimb+nDlvGyXBg8Q0QuYQIk5ERPiE5I0XNuNbUwsj7IWOxWo+4dVl3NbgnOdGhKIJr3CPhw6Z4z3YEjkFp4TccutskPmx/kk0sGsDxu0Q3YMHaV5xbZ9wAanMeena+CbNI5nM1SXvfBQCqaBf8FCqzBUeVNUXiUwuZW8O0ideMGdHc9f9R56C4M9G0jxFkdpHsKYF2/eIU6r/uJDglsv7n2pNX7v28O1l0ret2kqCJXr2yM3rFyxLf2BXDSjjuyGKAJoGkuBDP8V+JM+tCTIxYrzW83Z46sADKbrUvdIFxT6jMOxty74bAa//K2ZaJaAK8LqNVYdNlKuclWTeY+/1fIk5YXQcyNJPgqW0qyhNLwrldmaaG5asqg4OquKR2tGg5/vCOILU/fK2VbNSsLWgw9EGnmVLF581NnD0r7f2C3HqkgWUre/1hCc61zhpvtMOiRRYORz+cvagTcQmPMM/RfEoUMaCLT23H7O55qTxF5VGjQBOQt6bi7CdC+j3C+Bo+KF6U0R2Ds2oYfSaUqwSRLmmHOC8a3BN6Nm/wHdByqhp6FUnXqCXTlw==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Vm5pZENOcklqcUN6ajRPTitESGU2VW4vUUE3VFVOaDcwOGZvWVBDUFlJRGUy?=
 =?utf-8?B?UjNsV0xjS1d0Sm1MZjhaa1V2VFJ3ZTNuSm9ndU15NE1Xc1IzdjlRZW9JT2dX?=
 =?utf-8?B?VUkvRWRjSm9DRlVKUytEcnR0blRxSXFQT2FJYjdFZk5pQ3N3Q3J5OWRBY2lF?=
 =?utf-8?B?OCtpTVU1cWJSNFFPVWZUajkvNnlLMzNMMnNNQVdMa2lZbDVGd2pkREwveUNp?=
 =?utf-8?B?M1lSY0RTWGt1Zkp1UXRENHltUU8yK3VkeVVLakxrVitCeW1aL2toN0ZyVGUy?=
 =?utf-8?B?M0ZOYWNWTSt4aFVsYVg1TS9Rb2VqOCt1SXVmMWFyZnQ2NVMwalNyclhyWDNK?=
 =?utf-8?B?Tll0OTdXempEZ2tZU05xMUwrdi91WUY1OXFCMk1SUm1FcmhJdmtnSVZOYjFI?=
 =?utf-8?B?YlYzNW1mRG1yM241MlN0UTVsd0UwMGVDOGtTdkpQSEtWaUs4b25PYnZaalBB?=
 =?utf-8?B?VXFlV0tqRlpQeG5IV0diQVJMVXd3dXBXOUkzbFdLUHMrcXhBVS9ONlNVNWdO?=
 =?utf-8?B?dTZhT3V4RDhuVGhueVpHYTFZVldIdkR6Y0NIZXU2c3VzTTFpeVhHd0lzL3Nv?=
 =?utf-8?B?ODkrMm5OcjZPTzVEV0YxTEV1TlF0a2dEa3VzYjdpRGRyN2NyY3JEYmFFK0Fn?=
 =?utf-8?B?dkxoaDN2R3BoWWF6YmJGSFVnUm1jQ1BWdWxYWmV6dTJ1VnpYbER2Z1ViM2NT?=
 =?utf-8?B?cW5NWjZSVVV5Q1FZVWs2VmhZYm5RSGdXNXhsMExUSmEvOTB4MExtNVdKZDd6?=
 =?utf-8?B?cDFrdTNtMlZiYkNPQWwrdFRkTGo1U0cyUkk2eUV5Lzh4RFpSWFRoblNiOUdV?=
 =?utf-8?B?WWJ6dlo3bFo1SjRFTWlzOFdMRFBmQUtHUEx6Q1k0TUlLbERweGkrMzk3SkJD?=
 =?utf-8?B?WHZGZWhSM2RtS0NmMm9uTTNjVDNiWTVIcml4UkUwUTJ6TngxNkk5NXA5OWk4?=
 =?utf-8?B?bWNFTUNLTDlDanJxZUI0ZlQwekRITi9FSUo3aU1nNTgvclB5RlNJb0NUYVB1?=
 =?utf-8?B?Um5NZEMxT1pNWUNXbW52dDc4YVloK0kvcVJRMUZKTFZaeFhxZU1hcCtudFh2?=
 =?utf-8?B?VlY2R1JXL1ZGS3hsSUV1OUN3ZUpyaWl6TFhVMlFITHd1V0xPNVA5a01JaEVh?=
 =?utf-8?B?dWV3SG5nNlJOY0lIU0hnZ01SN3N1R1VqSEFyWkIzOVNnVVNaT25nYkNkS2pG?=
 =?utf-8?B?UDVyRHl6MDIwRG9kdElReE1rWFBsN3hiaXR0ajEzS2lLOXp6ZlY4cGw1RzYx?=
 =?utf-8?B?ZWM4dUFXdzh1YmVLOHk0cjNWQzU0dndNTk1aZDlKOTc3RzF6VlEybnVaWG5U?=
 =?utf-8?B?K0lyMU94YmZhY0xhVnVpSEltMWVjMnhrKzlUS01sWWJEMVRuQytlUG1BVCtR?=
 =?utf-8?B?SG9oZ1BXNC9odTU2RVhRSmQzRlZTajNDd2tHaEtwdkhOWnMyVDlyemFWQ28z?=
 =?utf-8?B?Tm0yT3JrM1ZVUkpHSS9EUVNPbEphVnVCU2plM3JiVkgreVdWb0psamR0YTQ3?=
 =?utf-8?B?aU54M2xsSUNlTE9sWHhkbm8zaUxiYTFLZ21iS1RnU1E5b1VOMVpRR0RvL2VF?=
 =?utf-8?B?N1lWNHlhc25Cb08vRFdrYnVCT2d2b1o3WnlNY004YXNQMlVzR2hyUzR6NnQ5?=
 =?utf-8?Q?M7HF9Xht+QwsaiKkzGx05Xn5l+CkmEhJ7G5vrte6ot5Y=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d60b22d-8026-4752-2020-08dc1afc0936
X-MS-Exchange-CrossTenant-AuthSource: MA0P287MB2822.INDP287.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2024 03:41:39.0004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3P287MB1618


On 2024/1/18 13:29, Chen Wang wrote:
>
> On 2024/1/16 19:37, Chen Wang wrote:
>>
>> On 2024/1/16 18:06, Krzysztof Kozlowski wrote:
>>> On 16/01/2024 08:21, Chen Wang wrote:
>>>> From: Chen Wang <unicorn_wang@outlook.com>
>>>>
>>>> Add documentation to describe Sophgo System Control for SG2042.
>>>>
>>>> Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
>>>> ---
>>>>   .../soc/sophgo/sophgo,sg2042-sysctrl.yaml     | 46 
>>>> +++++++++++++++++++
>>>>   1 file changed, 46 insertions(+)
>>>>   create mode 100644 
>>>> Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml 
>>>>
>>>>
>>>> diff --git 
>>>> a/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml 
>>>> b/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml 
>>>>
>>>> new file mode 100644
>>>> index 000000000000..7b50bb56b4cf
>>>> --- /dev/null
>>>> +++ 
>>>> b/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml
>>>> @@ -0,0 +1,46 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: 
>>>> http://devicetree.org/schemas/soc/sophgo/sophgo,sg2042-sysctrl.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Sophgo SG2042 SoC system control
>>>> +
>>>> +maintainers:
>>>> +  - Chen Wang <unicorn_wang@outlook.com>
>>>> +
>>>> +description:
>>>> +  The Sophgo system control is a registers block (SYS_CTRL), 
>>>> providing multiple
>>>> +  low level platform functions like chip configuration, clock 
>>>> control, etc.
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    const: sophgo,sg2042-sysctrl
>>>> +
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +  clock-controller:
>>>> +    # Child node
>>> Drop the comment, it is obvious. It cannot be anything else.
>>>
>>>> +    $ref: /schemas/clock/sophgo,sg2042-sysclk.yaml#
>>>> +    type: object
>>> Why isn't this merged here? You do not need the child node really...
>>> unless the clock inputs are specific to that clock controller and you
>>> will have here more devices? But where are they in such case?
>> I don't see more devices will be included later. It should be ok to 
>> merge them into one.
>
> hi, Krzysztof,
>
> After some double check, I find we will have more devices in 
> system-control. For example, in the SYS_CTRL area, there is also a 
> section of registers used to control the "General Purpose Interrupt". 
> The pcie controller of sg2042 will use this interrupt controller which 
> is defined in SYS_CTRL, we will add it in later work.
>
> Specifically, the distribution (offset) of registers in SYS_CTRL is as 
> follows:
>
> - 0x0C0 ~ 0x0FC: for some PLL clocks :
>
> - ......
>
> - 0x2E0 ~ 0x30C: for General Purpose Interrupt:
>
> - ......
>
> - 0x368 ~ 0x3FC: For some gate clocks
>
> So it seems that it is still necessary to keep the current child node 
> method, and it will also facilitate future expansion.
>
> What do you think, please feel free let me know.
>
> Thanks,
>
> Chen

hi, Krzysztof,

Can you please take a look if you have time, looking forward to your reply.

Thanks,

Chen


>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv