Received-SPF: pass (google.com: domain of linux-kernel+bounces-32386-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <1d948daf-1495-4208-a85f-6bd798091d82@quicinc.com>
Date: Mon, 22 Jan 2024 14:25:58 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for
 three LEDs
From: hui liu <quic_huliu@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross
	<agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_fenglinw@quicinc.com>
References: <20240115-lpg-v5-1-3c56f77f9cec@quicinc.com>
 <CAA8EJpoemnXTmshWrArVOCm0GRSkWZ5tH557nbAjRL1Tgg-Dig@mail.gmail.com>
 <e16f5ff1-9b12-4f90-89d5-f95cbfb859e7@quicinc.com>
 <6c29ce72-e303-406a-bb75-5b36b0cd8ee4@linaro.org>
 <44ab50c4-c63b-436c-af46-9b4543181446@quicinc.com>
 <CAA8EJpq8exe6n3OQnreLCsV+BnZKcu24d==rEKup=+n28nnDHw@mail.gmail.com>
 <4c82f1f0-1c5a-498f-9845-b5b26cd76468@quicinc.com>
 <5f6c2be1-faf9-4e64-ab3a-88046d75e2cf@quicinc.com>
In-Reply-To: <5f6c2be1-faf9-4e64-ab3a-88046d75e2cf@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 1/22/2024 1:42 PM, hui liu wrote:
> 
> 
> On 1/18/2024 10:06 AM, hui liu wrote:
>>
>>
>> On 1/17/2024 11:41 AM, Dmitry Baryshkov wrote:
>>> On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote:
>>>>
>>>>
>>>>
>>>> On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote:
>>>>> On 15/01/2024 11:18, hui liu wrote:
>>>>>>
>>>>>>
>>>>>> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote:
>>>>>>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay
>>>>>>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote:
>>>>>>>>
>>>>>>>> From: Hui Liu <quic_huliu@quicinc.com>
>>>>>>>>
>>>>>>>> Add definition for three LEDs to make sure they can
>>>>>>>> be enabled base on QCOM LPG LED driver.
>>>>>>>
>>>>>>> The "function" property is still placed incorrectly. Posting the 
>>>>>>> next
>>>>>>> iteration before concluding the discussion on the previous one is 
>>>>>>> not
>>>>>>> the best idea.
>>>>>> Do you mean I should update it as below? Seems there is no 
>>>>>> consumer to
>>>>>> use the function config, do we need to add now?
>>>>>
>>>>> Paste the output of dtbs_check for your board (or CHECK_DTBS=y for 
>>>>> your
>>>>> Makefile target).
>>>> I checked the dt-binding file of LPG LED, I will update the dts as
>>>> below, if you think it's correct, I will push v6.
>>>
>>> Is there any reason why you are defining three different LEDs instead
>>> of multi-led with three components?
> 
>> In the HW design, they are three seprete LEDs, there are three LEDs on 
>> device. why do we need to add for multi-led?
>>
>> Thanks,
>> Hui

I double confirmed the HW design, for IDP devcie, we should set it to 
multi led, for another similar device(RB3-GEN2, I will push LED change 
for this device later), it should be set to seperate LED.
They are different, so I will push V6 to set it for multi-led for 
QCM6490-IDP device. Thanks for your review.

>>>
>>>>
>>>> +&pm8350c_pwm {
>>>> +       #address-cells = <1>;
>>>> +       #size-cells = <0>;
>>>> +       status = "okay";
>>>> +
>>>> +       led@1 {
>>>> +               reg = <1>;
>>>> +               color = <LED_COLOR_ID_RED>;
>>>> +               function = LED_FUNCTION_STATUS;
>>>> +       };
>>>> +
>>>> +       led@2 {
>>>> +               reg = <2>;
>>>> +               color = <LED_COLOR_ID_GREEN>;
>>>> +               function = LED_FUNCTION_STATUS;
>>>> +       };
>>>> +
>>>> +       led@3 {
>>>> +               reg = <3>;
>>>> +               color = <LED_COLOR_ID_BLUE>;
>>>> +               function = LED_FUNCTION_STATUS;
>>>> +       };
>>>> +};
>>>
>>>
>>>