Received-SPF: pass (google.com: domain of linux-kernel+bounces-32406-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 22 Jan 2024 07:56:18 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Erick Archer <erick.archer@gmx.com>
Cc: Michael Turquette <mturquette@baylibre.com>, 
	Stephen Boyd <sboyd@kernel.org>, Conor Dooley <conor.dooley@microchip.com>, 
	Heiko Stuebner <heiko@sntech.de>, Dinh Nguyen <dinguyen@kernel.org>, Rob Herring <robh@kernel.org>, 
	Nick Alcock <nick.alcock@oracle.com>, "Gustavo A. R. Silva" <gustavoars@kernel.org>, 
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] clk: hisilicon: Use devm_kcalloc() instead of
 devm_kzalloc()
Message-ID: <ikfbonqfodfiq2hpqibb23ctaq6nxwynjjytfygonpncdkcfct@ygfjvunzkn7c>
References: <20240121142946.2796-1-erick.archer@gmx.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ssqmcul6zy7posmr"
Content-Disposition: inline
In-Reply-To: <20240121142946.2796-1-erick.archer@gmx.com>


--ssqmcul6zy7posmr
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 21, 2024 at 03:29:46PM +0100, Erick Archer wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>=20
> So, use the purpose specific devm_kcalloc() function instead of the
> argument size * count in the devm_kzalloc() function.
>=20
> Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-c=
oded-arithmetic-in-allocator-arguments [1]
> Link: https://github.com/KSPP/linux/issues/162
> Signed-off-by: Erick Archer <erick.archer@gmx.com>
> ---
>  drivers/clk/hisilicon/clk-hi3559a.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/clk/hisilicon/clk-hi3559a.c b/drivers/clk/hisilicon/=
clk-hi3559a.c
> index ff4ca0edce06..da476f940326 100644
> --- a/drivers/clk/hisilicon/clk-hi3559a.c
> +++ b/drivers/clk/hisilicon/clk-hi3559a.c
> @@ -461,8 +461,7 @@ static void hisi_clk_register_pll(struct hi3559av100_=
pll_clock *clks,
>  	struct clk_init_data init;
>  	int i;
>=20
> -	p_clk =3D devm_kzalloc(dev, sizeof(*p_clk) * nums, GFP_KERNEL);
> -
> +	p_clk =3D devm_kcalloc(dev, nums, sizeof(*p_clk), GFP_KERNEL);
>  	if (!p_clk)
>  		return;

Looks good,

Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

My first impulse was to ask why hisi_clk_register_pll doesn't return an
error if the allocation fails, but I guess that happens so early that no
sensible error handling is possible?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--ssqmcul6zy7posmr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmWuEZEACgkQj4D7WH0S
/k5Whgf+IryHEKthLbUXpxCs9TrkdjTk2tWZpkoZoz0Hk+Fzyp1PTLnzYoRkBCr2
AdqbpkeTvpfg9++BZu61V5OBCk0SnfaLgBFi/hUa7tOpcEMbrriJxgZNrb4x2HK0
g5RQWR4Yxj1zdkdGHu1ErYLLDBUg+DhpsIFLZGhLR2f6B2yEGFXT3EgKoUP59xpP
hNbEoARWh2N135qifza2toHuMVju9X9anph73dq2a+FWup+oKFyL2j7zKgEtJkO1
fX/c2c/oFZoDXFmQOAHEpeihL9DFyOBlBp4rQktixbyzIDLjqbK7VjK/dx7DBUCw
8omlOgsxwtmAuO6r7A6eNlLpzFbK4g==
=p4Xd
-----END PGP SIGNATURE-----

--ssqmcul6zy7posmr--