Received-SPF: pass (google.com: domain of linux-kernel+bounces-32418-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <1703556550-2858-1-git-send-email-dongliang.cui@unisoc.com>
In-Reply-To: <1703556550-2858-1-git-send-email-dongliang.cui@unisoc.com>
From: dongliang cui <cuidongliang390@gmail.com>
Date: Mon, 22 Jan 2024 15:16:24 +0800
Message-ID: <CAPqOJe0H2h+ObwpP=05OtwOTE254kV3LZTVXE6jdNawT1EVzFQ@mail.gmail.com>
Subject: Re: [PATCH] block: Add ioprio to block_rq tracepoint
To: Dongliang Cui <dongliang.cui@unisoc.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, Masami Hiramatsu <mhiramat@kernel.org>, 
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, linux-kernel@vger.kernel.org, 
	linux-trace-kernel@vger.kernel.org, Hongyu Jin <hongyu.jin@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Can this submission be uploaded=EF=BC=8Cor is there anything that needs to =
be modified=EF=BC=9F

On Tue, Dec 26, 2023 at 10:10=E2=80=AFAM Dongliang Cui <dongliang.cui@uniso=
c.com> wrote:
>
> Sometimes we need to track the processing order of
> requests with ioprio set, especially when using
> mq-deadline. So the ioprio of request can be useful
> information.
>
> Signed-off-by: Dongliang Cui <dongliang.cui@unisoc.com>
> ---
>  include/trace/events/block.h | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/include/trace/events/block.h b/include/trace/events/block.h
> index 0e128ad..e84ff93 100644
> --- a/include/trace/events/block.h
> +++ b/include/trace/events/block.h
> @@ -82,6 +82,7 @@
>                 __field(  dev_t,        dev                     )
>                 __field(  sector_t,     sector                  )
>                 __field(  unsigned int, nr_sector               )
> +               __field(  unsigned int, ioprio                  )
>                 __array(  char,         rwbs,   RWBS_LEN        )
>                 __dynamic_array( char,  cmd,    1               )
>         ),
> @@ -90,16 +91,17 @@
>                 __entry->dev       =3D rq->q->disk ? disk_devt(rq->q->dis=
k) : 0;
>                 __entry->sector    =3D blk_rq_trace_sector(rq);
>                 __entry->nr_sector =3D blk_rq_trace_nr_sectors(rq);
> +               __entry->ioprio    =3D rq->ioprio;
>
>                 blk_fill_rwbs(__entry->rwbs, rq->cmd_flags);
>                 __get_str(cmd)[0] =3D '\0';
>         ),
>
> -       TP_printk("%d,%d %s (%s) %llu + %u [%d]",
> +       TP_printk("%d,%d %s (%s) %llu + %u 0x%x [%d]",
>                   MAJOR(__entry->dev), MINOR(__entry->dev),
>                   __entry->rwbs, __get_str(cmd),
>                   (unsigned long long)__entry->sector,
> -                 __entry->nr_sector, 0)
> +                 __entry->nr_sector, __entry->ioprio, 0)
>  );
>
>  DECLARE_EVENT_CLASS(block_rq_completion,
> @@ -112,6 +114,7 @@
>                 __field(  dev_t,        dev                     )
>                 __field(  sector_t,     sector                  )
>                 __field(  unsigned int, nr_sector               )
> +               __field(  unsigned int, ioprio                  )
>                 __field(  int   ,       error                   )
>                 __array(  char,         rwbs,   RWBS_LEN        )
>                 __dynamic_array( char,  cmd,    1               )
> @@ -121,17 +124,19 @@
>                 __entry->dev       =3D rq->q->disk ? disk_devt(rq->q->dis=
k) : 0;
>                 __entry->sector    =3D blk_rq_pos(rq);
>                 __entry->nr_sector =3D nr_bytes >> 9;
> +               __entry->ioprio    =3D rq->ioprio;
>                 __entry->error     =3D blk_status_to_errno(error);
>
>                 blk_fill_rwbs(__entry->rwbs, rq->cmd_flags);
>                 __get_str(cmd)[0] =3D '\0';
>         ),
>
> -       TP_printk("%d,%d %s (%s) %llu + %u [%d]",
> +       TP_printk("%d,%d %s (%s) %llu + %u 0x%x [%d]",
>                   MAJOR(__entry->dev), MINOR(__entry->dev),
>                   __entry->rwbs, __get_str(cmd),
>                   (unsigned long long)__entry->sector,
> -                 __entry->nr_sector, __entry->error)
> +                 __entry->nr_sector, __entry->ioprio,
> +                 __entry->error)
>  );
>
>  /**
> @@ -180,6 +185,7 @@
>                 __field(  sector_t,     sector                  )
>                 __field(  unsigned int, nr_sector               )
>                 __field(  unsigned int, bytes                   )
> +               __field(  unsigned int, ioprio                  )
>                 __array(  char,         rwbs,   RWBS_LEN        )
>                 __array(  char,         comm,   TASK_COMM_LEN   )
>                 __dynamic_array( char,  cmd,    1               )
> @@ -190,17 +196,19 @@
>                 __entry->sector    =3D blk_rq_trace_sector(rq);
>                 __entry->nr_sector =3D blk_rq_trace_nr_sectors(rq);
>                 __entry->bytes     =3D blk_rq_bytes(rq);
> +               __entry->ioprio    =3D rq->ioprio;
>
>                 blk_fill_rwbs(__entry->rwbs, rq->cmd_flags);
>                 __get_str(cmd)[0] =3D '\0';
>                 memcpy(__entry->comm, current->comm, TASK_COMM_LEN);
>         ),
>
> -       TP_printk("%d,%d %s %u (%s) %llu + %u [%s]",
> +       TP_printk("%d,%d %s %u (%s) %llu + %u 0x%x [%s]",
>                   MAJOR(__entry->dev), MINOR(__entry->dev),
>                   __entry->rwbs, __entry->bytes, __get_str(cmd),
>                   (unsigned long long)__entry->sector,
> -                 __entry->nr_sector, __entry->comm)
> +                 __entry->nr_sector, __entry->ioprio,
> +                 __entry->comm)
>  );
>
>  /**
> --
> 1.9.1
>