Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp165370rdb; Sun, 21 Jan 2024 23:21:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IGujtOpQixsdS9f1whpqWRfDfCubnd+GBlTdzAinX/XSIt3it7T3BAuENzNSZyX85iQ54rH X-Received: by 2002:a05:6871:5885:b0:214:4188:3583 with SMTP id ok5-20020a056871588500b0021441883583mr600503oac.62.1705908078231; Sun, 21 Jan 2024 23:21:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705908078; cv=pass; d=google.com; s=arc-20160816; b=QpDXA8wliBf54hQFxmaVsMifqe554RmCyNA1o+AD5pFrkPM0E8duDKeWSbJG523AXu CwvdSFnM/hEYvcQmK29fU9Iwe5mdDyp8oBXFPn42nHIFcUCTJmu9lYqQMFbirzXBf+jP x5N/BzUHAbi7q4Iu7voa8F+2s+7X/J4rTY0i+c6wOHkwEFVuSxvAeFwPcC434JxtKw2g /HPYqnSmVAgb8JSt+S7qkFQ+JG4lPNwRgujh1z4haiN/5I0wPBKtCBFW9EflJGNvyXt5 XDb8KiQW3LhKuUiG1GB+UoloI2Z4wXfb+NY92om5yn8Onz3F1vhkkSw+FLOxqaBnA/wU FuGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=N2xoYW3vwrZLwzBr/kjmxRicWAWxAyGeYufVkjpsFQ0=; fh=7i2QflYaT1mUJlx99HEw7vzb4EEQ41wLmVdfUfupiNU=; b=rIe+mF0vnOwJT+9SD4WID0NiWlwKwsNqXMpJ31OdX3pYf5apuG598WRMLs2mqXZKNQ Hs7Kk2TA8KquhoufSXxP+UFIlnQk/iKmx9VKPLTNUJNtNW7hMJq9VGTMgHehUATVeyhv CHfh4BdqvDSNfwTOMEoUlIKCPIEOi6bvfpJoD+wn27Q5YWwv8RO2fSEDPyAONFKqggVn Ltb7Tm2NqIgr+olzeWzwPPuwu6m2FKfjC92mvCqaI9u+cQjykgOsdbIrHwrfWFsmGkIW D/uUG499tcd0p2zKLLMCdLPvFLf1Qr8wyE0gUTtW39t0AZ7LwCiOys406qdEkSSKhrqs OzBg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Yn24y9u+; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-32422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32422-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id m10-20020a656a0a000000b005cdc07fbef4si8144747pgu.736.2024.01.21.23.21.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jan 2024 23:21:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-32422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Yn24y9u+; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-32422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32422-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C980928983F for ; Mon, 22 Jan 2024 07:21:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7E534F9DE; Mon, 22 Jan 2024 07:21:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yn24y9u+" Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2F5FDF54; Mon, 22 Jan 2024 07:21:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705908070; cv=none; b=mbA6ajFgmHpfWIsOLCiKI0P9dhCZJ8+WMdtIzQo2xxgfR+xgVwCFE9yYJXuvKyemVgTKzylUh/tr4SJv9eitRZ6p8mNN6tVtG8U6RGjkmx4fNKMLTF6K7IPJxgsXTs7Y/4Q7VJXArcrY082txb/TIYJS3B51UQkpM+9iz/oAPyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705908070; c=relaxed/simple; bh=QGBSrTkTEzZNL7ZqFhZ+QkNfueNiptTWKimZ4YEt/n4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AGaBvj8erg08W7F5/NcTIM1ZTSj1wW9w+6BzTYVmYSal54E8OXp9ikNk/fxy9ZGXCBYBkmw6k/hCe2+X8YOPrcG/+8rSLPwk6QpLosy27jQZu5ekATs3JW7GCT3Wo7uOgGTZwA3wJ6MO8K2KsKkynv44/Q2ATh/QiGILM3sWFaU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yn24y9u+; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-337b8da1f49so2595384f8f.0; Sun, 21 Jan 2024 23:21:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705908067; x=1706512867; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N2xoYW3vwrZLwzBr/kjmxRicWAWxAyGeYufVkjpsFQ0=; b=Yn24y9u+4cTfKD1QaHpwlw8PAz7Btf4jKJGkz2vk57WmTDi4dKDPWk/Ww+xTV+NuZ7 W4Lmjzl7rMWVdGYV63W0g+cEnDbBXQfFREmfS5SbTVfZ5Dd+BHnYUzE77xXgzzqtcRU8 uyfnagQ9zU3XDNEhMAtcVd8O+/bbHjQpu0YyvkHDE6DFulrIROsfp8wR8Skqo2XxAawt jimdGI0VNxHD4GKAByj944Z6t4sYGO/uZKaeGQ7EE8pQyVdkI8A+svkBpmmf7nH+z5bG 6y9GIoo5mYLbeSHzeLrAXn4uXbnaJwVp56/8MyacWLtBVcN1JGJdyeMhY9IrY5VVu2z/ fS+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705908067; x=1706512867; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N2xoYW3vwrZLwzBr/kjmxRicWAWxAyGeYufVkjpsFQ0=; b=VLCr/BleCTmD7p7ytoTzKCMtSg0/zFJIGryShf4y24YuOE7DwDLiFI1JLo3wYvL8ak JyOyhG421clT8yORsAPoznIL8Qa9PCj9u/dh3yn/cRJpPqr2Hmrz/ZkARcid8zKuf814 da5KCyFZBiPtYW89GHM9mFIXT0YhY/reqPRqguQ/0KYsmtFRuySj4H6CXtXlVivQYmOZ rNNBaTbKhSNeCY/h2tTxv0qEPE4uki5Fwqc6p+nfxEXRTGIXwPr6pl4zfsCc5Rv+xy8n VbkSP1Ma0iDfCB5t2AeizaHpU2ELtENmKtGTUBAAtmXPdf7YD/ZxLOPlqmWBwWiz+a4A dUkw== X-Gm-Message-State: AOJu0YzFJ7VwayRHXfqkGImGlo54Qlw+hwBXUtBgV6xZmAU4zZjpjLBy EyzBHCOvDD6jJmjAnsJfdPF9Dx40vjigixsyiZBuaf0vVs2PXcrOayMVJsEM X-Received: by 2002:a5d:5752:0:b0:337:a76c:84fb with SMTP id q18-20020a5d5752000000b00337a76c84fbmr954441wrw.38.1705908066561; Sun, 21 Jan 2024 23:21:06 -0800 (PST) Received: from [192.168.2.177] ([207.188.161.188]) by smtp.gmail.com with ESMTPSA id d12-20020adfe88c000000b00337be3b02aasm13076149wrm.100.2024.01.21.23.21.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jan 2024 23:21:05 -0800 (PST) Message-ID: Date: Mon, 22 Jan 2024 08:21:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] arm64: dts: mt8183: Move CrosEC base detection node to kukui-based DTs Content-Language: en-US, ca-ES, es-ES To: AngeloGioacchino Del Regno , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Enric Balletbo i Serra , Ikjoon Jang , Stephen Boyd , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com References: <20240116-mt8183-kukui-cbas-remove-v3-1-055e21406e86@collabora.com> <720dc418-16f7-473c-b33c-f0c9786c02e2@collabora.com> From: Matthias Brugger Autocrypt: addr=matthias.bgg@gmail.com; keydata= xsFNBFP1zgUBEAC21D6hk7//0kOmsUrE3eZ55kjc9DmFPKIz6l4NggqwQjBNRHIMh04BbCMY fL3eT7ZsYV5nur7zctmJ+vbszoOASXUpfq8M+S5hU2w7sBaVk5rpH9yW8CUWz2+ZpQXPJcFa OhLZuSKB1F5JcvLbETRjNzNU7B3TdS2+zkgQQdEyt7Ij2HXGLJ2w+yG2GuR9/iyCJRf10Okq gTh//XESJZ8S6KlOWbLXRE+yfkKDXQx2Jr1XuVvM3zPqH5FMg8reRVFsQ+vI0b+OlyekT/Xe 0Hwvqkev95GG6x7yseJwI+2ydDH6M5O7fPKFW5mzAdDE2g/K9B4e2tYK6/rA7Fq4cqiAw1+u EgO44+eFgv082xtBez5WNkGn18vtw0LW3ESmKh19u6kEGoi0WZwslCNaGFrS4M7OH+aOJeqK fx5dIv2CEbxc6xnHY7dwkcHikTA4QdbdFeUSuj4YhIZ+0QlDVtS1QEXyvZbZky7ur9rHkZvP ZqlUsLJ2nOqsmahMTIQ8Mgx9SLEShWqD4kOF4zNfPJsgEMB49KbS2o9jxbGB+JKupjNddfxZ HlH1KF8QwCMZEYaTNogrVazuEJzx6JdRpR3sFda/0x5qjTadwIW6Cl9tkqe2h391dOGX1eOA 1ntn9O/39KqSrWNGvm+1raHK+Ev1yPtn0Wxn+0oy1tl67TxUjQARAQABzSlNYXR0aGlhcyBC cnVnZ2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPsLBkgQTAQIAPAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCWt3scQIZAQAKCRDZFAuy VhMC8WzRD/4onkC+gCxG+dvui5SXCJ7bGLCu0xVtiGC673Kz5Aq3heITsERHBV0BqqctOEBy ZozQQe2Hindu9lasOmwfH8+vfTK+2teCgWesoE3g3XKbrOCB4RSrQmXGC3JYx6rcvMlLV/Ch YMRR3qv04BOchnjkGtvm9aZWH52/6XfChyh7XYndTe5F2bqeTjt+kF/ql+xMc4E6pniqIfkv c0wsH4CkBHqoZl9w5e/b9MspTqsU9NszTEOFhy7p2CYw6JEa/vmzR6YDzGs8AihieIXDOfpT DUr0YUlDrwDSrlm/2MjNIPTmSGHH94ScOqu/XmGW/0q1iar/Yr0leomUOeeEzCqQtunqShtE 4Mn2uEixFL+9jiVtMjujr6mphznwpEqObPCZ3IcWqOFEz77rSL+oqFiEA03A2WBDlMm++Sve 9jpkJBLosJRhAYmQ6ey6MFO6Krylw1LXcq5z1XQQavtFRgZoruHZ3XlhT5wcfLJtAqrtfCe0 aQ0kJW+4zj9/So0uxJDAtGuOpDYnmK26dgFN0tAhVuNInEVhtErtLJHeJzFKJzNyQ4GlCaLw jKcwWcqDJcrx9R7LsCu4l2XpKiyxY6fO4O8DnSleVll9NPfAZFZvf8AIy3EQ8BokUsiuUYHz wUo6pclk55PZRaAsHDX/fNr24uC6Eh5oNQ+v4Pax/gtyyc7BTQRd1TlIARAAm78mTny44Hwd IYNK4ZQH6U5pxcJtU45LLBmSr4DK/7er9chpvJ5pgzCGuI25ceNTEg5FChYcgfNMKqwCAekk V9Iegzi6UK448W1eOp8QeQDS6sHpLSOe8np6/zvmUvhiLokk7tZBhGz+Xs5qQmJPXcag7AMi fuEcf88ZSpChmUB3WflJV2DpxF3sSon5Ew2i53umXLqdRIJEw1Zs2puDJaMqwP3wIyMdrfdI H1ZBBJDIWV/53P52mKtYQ0Khje+/AolpKl96opi6o9VLGeqkpeqrKM2cb1bjo5Zmn4lXl6Nv JRH/ZT68zBtOKUtwhSlOB2bE8IDonQZCOYo2w0opiAgyfpbij8uiI7siBE6bWx2fQpsmi4Jr ZBmhDT6n/uYleGW0DRcZmE2UjeekPWUumN13jaVZuhThV65SnhU05chZT8vU1nATAwirMVeX geZGLwxhscduk3nNb5VSsV95EM/KOtilrH69ZL6Xrnw88f6xaaGPdVyUigBTWc/fcWuw1+nk GJDNqjfSvB7ie114R08Q28aYt8LCJRXYM1WuYloTcIhRSXUohGgHmh7usl469/Ra5CFaMhT3 yCVciuHdZh3u+x+O1sRcOhaFW3BkxKEy+ntxw8J7ZzhgFOgi2HGkOGgM9R03A6ywc0sPwbgk gF7HCLirshP2U/qxWy3C8DkAEQEAAcLBdgQYAQgAIBYhBOa5khjA8sMlHCw6F9kUC7JWEwLx BQJd1TlIAhsMAAoJENkUC7JWEwLxtdcP/jHJ9vI8adFi1HQoWUKCQbZdZ5ZJHayFKIzU9kZE /FHzzzMDZYFgcCTs2kmUVyGloStXpZ0WtdCMMB31jBoQe5x9LtICHEip0irNXm80WsyPCEHU 3wx91QkOmDJftm6T8+F3lqhlc3CwJGpoPY7AVlevzXNJfATZR0+Yh9NhON5Ww4AjsZntqQKx E8rrieLRd+he57ZdRKtRRNGKZOS4wetNhodjfnjhr4Z25BAssD5q+x4uaO8ofGxTjOdrSnRh vhzPCgmP7BKRUZA0wNvFxjboIw8rbTiOFGb1Ebrzuqrrr3WFuK4C1YAF4CyXUBL6Z1Lto//i 44ziQUK9diAgfE/8GhXP0JlMwRUBlXNtErJgItR/XAuFwfO6BOI43P19YwEsuyQq+rubW2Wv rWY2Bj2dXDAKUxS4TuLUf2v/b9Rct36ljzbNxeEWt+Yq4IOY6QHnE+w4xVAkfwjT+Vup8sCp +zFJv9fVUpo/bjePOL4PMP1y+PYrp4PmPmRwoklBpy1ep8m8XURv46fGUHUEIsTwPWs2Q87k 7vjYyrcyAOarX2X5pvMQvpAMADGf2Z3wrCsDdG25w2HztweUNd9QEprtJG8GNNzMOD4cQ82T a7eGvPWPeXauWJDLVR9jHtWT9Ot3BQgmApLxACvwvD1a69jaFKov28SPHxUCQ9Y1Y/Ct In-Reply-To: <720dc418-16f7-473c-b33c-f0c9786c02e2@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 17/01/2024 11:14, AngeloGioacchino Del Regno wrote: > Il 16/01/24 22:38, Nícolas F. R. A. Prado ha scritto: >> The cbas node is used to describe base detection functionality in the >> ChromeOS EC, which is used for units that have a detachable keyboard and >> thus rely on this functionality to switch between tablet and laptop >> mode. >> >> Despite the original commit having added the cbas node to the >> mt8183-kukui.dtsi, not all machines that include it are detachables. In >> fact all machines that include from mt8183-kukui-jacuzzi.dtsi are either >> clamshells (ie normal laptops) or convertibles, meaning the keyboard can >> be flipped but not detached. The detection for the keyboard getting >> flipped is handled by the driver bound to the keyboard-controller node >> in the EC. >> >> Move the base detection node from the base kukui dtsi to the dtsis where >> all machines are detachables, and thus actually make use of the node. >> >> Fixes: 4fa8492d1e5b ("arm64: dts: mt8183: add cbas node under cros_ec") >> Signed-off-by: Nícolas F. R. A. Prado > > Reviewed-by: AngeloGioacchino Del Regno > Applied, thanks! >> --- >> Changes in v3: >> - Instead of deleting the node in jacuzzi, moved the node from kukui to >>    the dtsis including kukui that are detachables >> >> Changes in v2: >> - Moved cbas node removal to jacuzzi dtsi >> --- >>   arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 ++++ >>   arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 4 ++++ >>   arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi  | 4 ++++ >>   arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi        | 4 ---- >>   4 files changed, 12 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi >> b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi >> index b6a9830af269..bfb9e42c8aca 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi >> @@ -360,6 +360,10 @@ pen_eject { >>   }; >>   &cros_ec { >> +    cbas { >> +        compatible = "google,cros-cbas"; >> +    }; >> + >>       keyboard-controller { >>           compatible = "google,cros-ec-keyb-switches"; >>       }; >> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi >> b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi >> index 306c95166f3f..5c1bf6a1e475 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi >> @@ -339,6 +339,10 @@ touch_pin_reset: pin_reset { >>   }; >>   &cros_ec { >> +    cbas { >> +        compatible = "google,cros-cbas"; >> +    }; >> + >>       keyboard-controller { >>           compatible = "google,cros-ec-keyb-switches"; >>       }; >> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi >> b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi >> index 382e4c6d7191..0f5fa893a774 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi >> @@ -343,6 +343,10 @@ rst_pin { >>   }; >>   &cros_ec { >> +    cbas { >> +        compatible = "google,cros-cbas"; >> +    }; >> + >>       keyboard-controller { >>           compatible = "google,cros-ec-keyb-switches"; >>       }; >> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi >> b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi >> index 5506de83f61d..66eb099e15f0 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi >> @@ -937,10 +937,6 @@ usbc_extcon: extcon0 { >>               google,usb-port-id = <0>; >>           }; >> -        cbas { >> -            compatible = "google,cros-cbas"; >> -        }; >> - >>           typec { >>               compatible = "google,cros-ec-typec"; >>               #address-cells = <1>; >> >> --- >> base-commit: 0f067394dd3b2af3263339cf7183bdb6ee0ac1f8 >> change-id: 20240116-mt8183-kukui-cbas-remove-657b62aeced6 >> >> Best regards, >