Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759964AbXLOGqY (ORCPT ); Sat, 15 Dec 2007 01:46:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753431AbXLOGqP (ORCPT ); Sat, 15 Dec 2007 01:46:15 -0500 Received: from mx1.redhat.com ([66.187.233.31]:39236 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752252AbXLOGqP (ORCPT ); Sat, 15 Dec 2007 01:46:15 -0500 Date: Sat, 15 Dec 2007 01:45:55 -0500 From: Dave Jones To: Matt Mackall Cc: Herbert Xu , Andrew Morton , Linux Kernel Mailing List Subject: Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off Message-ID: <20071215064555.GA7211@redhat.com> Mail-Followup-To: Dave Jones , Matt Mackall , Herbert Xu , Andrew Morton , Linux Kernel Mailing List References: <20071214132755.GA18309@gondor.apana.org.au> <20071214180246.GT17536@waste.org> <20071215041659.GB25324@gondor.apana.org.au> <20071215055218.GM19691@waste.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071215055218.GM19691@waste.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 761 Lines: 21 On Fri, Dec 14, 2007 at 11:52:18PM -0600, Matt Mackall wrote: > Then I kindly submit that you should instead withdraw the code that > allows you to use WARN_ON in a condition in the first place. > > Note that Dave Jones is currently poking at making WARN_ON > out-of-line, so you're liable to collide with him. Actually I'm not likely to get back to this until post xmas. I'm on vacation until then from today, so I'll be paying less attention to stuff than usual. Dave -- http://www.codemonkey.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/