Received-SPF: pass (google.com: domain of linux-kernel+bounces-32575-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Feedback-ID: ie8e14432:Fastmail
Date: Mon, 22 Jan 2024 17:56:04 +0900
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2] firewire: Kill unnecessary buf check in
 device_attribute.show
Message-ID: <20240122085604.GA254251@workstation.local>
Mail-Followup-To: Li Zhijian <lizhijian@fujitsu.com>,
	linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net
References: <20240122053942.80648-1-lizhijian@fujitsu.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240122053942.80648-1-lizhijian@fujitsu.com>

Hi,

On Mon, Jan 22, 2024 at 01:39:41PM +0800, Li Zhijian wrote:
> Per Documentation/filesystems/sysfs.rst:
> > sysfs allocates a buffer of size (PAGE_SIZE) and passes it to the
> > method.
> 
> So we can kill the unnecessary buf check safely.
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
>  drivers/firewire/core-device.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)

Applied both patches to linux-next branch, since they are not so-urgent 
fixes.


Thanks

Takashi Sakamoto