Received-SPF: pass (google.com: domain of linux-kernel+bounces-32662-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 22 Jan 2024 09:47:50 +0000
From: Conor Dooley <conor@kernel.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
	robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, afd@ti.com,
	srk@ti.com
Subject: Re: [PATCH v2] dt-bindings: PCI: ti,j721e-pci-host: Add support for
 J722S SoC
Message-ID: <20240122-getting-drippy-bb22a0634092@spud>
References: <20240122064457.664542-1-s-vadapalli@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="MB4v+1ZTataoFot5"
Content-Disposition: inline
In-Reply-To: <20240122064457.664542-1-s-vadapalli@ti.com>


--MB4v+1ZTataoFot5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 22, 2024 at 12:14:57PM +0530, Siddharth Vadapalli wrote:
> TI's J722S SoC has one instance of a Gen3 Single-Lane PCIe controller.
> The controller on J722S SoC is similar to the one present on TI's AM64
> SoC, with the difference being that the controller on AM64 SoC supports
> up to Gen2 link speed while the one on J722S SoC supports Gen3 link speed.
>=20
> Update the bindings with a new compatible for J722S SoC.

Since the difference is just that this device supports a higher link
speed, should it not have a fallback compatible to the am64 variant?
Or is the programming model different for this device for the lower link
speeds different?

Thanks,
Conor.

>=20
> Technical Reference Manual of J722S SoC: https://www.ti.com/lit/zip/spruj=
b3
>=20
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
>=20
> Hello,
>=20
> This patch is based on linux-next tagged next-20240122.
>=20
> v1:
> https://lore.kernel.org/r/20240117102526.557006-1-s-vadapalli@ti.com/
> Changes since v1:
> - Dropped patches 1/3 and 2/3 of the v1 series as discussed in the v1
>   thread.
> - Updated patch 3/3 which is the v1 for this patch by dropping the checks
>   for the "num-lanes" property and "max-link-speed" property since the PCI
>   driver already validates the "num-lanes" property.
>=20
> Regards,
> Siddharth.
>=20
>  Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml=
 b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index b7a534cef24d..a7b5c4ce2744 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -14,6 +14,7 @@ properties:
>    compatible:
>      oneOf:
>        - const: ti,j721e-pcie-host
> +      - const: ti,j722s-pcie-host
>        - const: ti,j784s4-pcie-host
>        - description: PCIe controller in AM64
>          items:
> --=20
> 2.34.1
>=20

--MB4v+1ZTataoFot5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZa45xgAKCRB4tDGHoIJi
0gPPAP9r7u6mPuwvim0hfPgkksx+qLpzH4bCYXoMh2kBRkzN3gEAov+DNvSIQ2nN
GPKc5v4ISfqN1mZtrXvCkZsKU22obAU=
=avKc
-----END PGP SIGNATURE-----

--MB4v+1ZTataoFot5--