Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp222794rdb; Mon, 22 Jan 2024 01:53:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHnkUO8Xch1juCFcRgPiICeS9L3KVK0aNtivvFvwGX4JKU1ko9y1dsnF8KGF/I8XgUkIl/K X-Received: by 2002:a17:906:99ca:b0:a2e:d314:fc2b with SMTP id s10-20020a17090699ca00b00a2ed314fc2bmr2281059ejn.23.1705917181227; Mon, 22 Jan 2024 01:53:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705917181; cv=pass; d=google.com; s=arc-20160816; b=PdpaDIOFXneo6UmgovwTM31RCrs34cIH7OUZbAix2DryiTBF1TONoRcFf2LKqAtOeB 6+NmIqC3slbLErHoFpS9ShsXZrtO83z42Tg6h+QAXVKfnSfQjOWUI591aG/NXvuplccu ody2VZif+5qPuWwzxefXKyfsZWYASqhm6tEVZj5vV0DzL10FN50BI3eZg5WzQExJWkeY yPq7vCF1VOh10n1avGRxEryOeMOr7vuXrKcF2SCyHRml7enJnnaO2HqipQWGHl++SApZ d68qGzZlQWDoh1EDOm8JsISZfWaZRHEa3SUmLh9onkvc4Ba00q7pdX/V53oOln8E/Ko+ WtDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=+nGU7Loi1Do4zrvl/0l3JM9LGLlkYeGwWtlVmkNopIo=; fh=X3MRZdkeYxK5Oe5AQ83Y4efAPr7MhPoTPxaw2GjEGFw=; b=WrncBgxETyUQnb9ZKUWF8F67nvtNcEp6zbygDBNeFuTsCiG8/dVLSKuYv/Hu2Ftajf gQzuuctWNCRU+Xc5epcD+hSWMQsrZZdm+ntKRJIL2U6iUerwSsyfCCRDlBenJxvoO6VT TlsWFhukbA8hszmCeCJy1BDUOIqcu1TpJoNQ6Ew1GQExeSwM8v5DAxU/9F6lzQKTdH2L VztY53vfiEfvu7SH8WhJOhqnjis9uVahpDl48j4R0pki6e6CK1P86LyXYxqfuhuEe83h ZOgekdTcb4wutU7iw2FsjGal9Sv+ikVsPESN08/EnQjPNBauCgFinkEv0jKYHgzWyIy/ Kadw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=VWGHCJKZ; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-32672-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32672-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id z16-20020a170906241000b00a28d190f5e6si9990957eja.782.2024.01.22.01.53.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 01:53:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-32672-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=VWGHCJKZ; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-32672-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32672-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 03F511F213AA for ; Mon, 22 Jan 2024 09:53:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A87B33A1C4; Mon, 22 Jan 2024 09:51:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="VWGHCJKZ" Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A57CA3A8CD; Mon, 22 Jan 2024 09:51:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705917099; cv=none; b=nmXtm5HR/aNx0xEEhBisvEQsddEECfZCALZ5ercQGMUJ8+E9c20l5ysODetWqPYGnchZ3N5171mF2nt9aXmKDM6SC0+WUGN1Ifc0AujqxMCbAExh1djEWb+Wfc507yQjOXlXHsTFU0bMh0Yy8ZjvthkAEDh/612TQfdvhcK6yBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705917099; c=relaxed/simple; bh=+nGU7Loi1Do4zrvl/0l3JM9LGLlkYeGwWtlVmkNopIo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uF93udTBiJNZL0WmoGN7uT6/z/ceofz7pBaQQ/zFedhcv/6VBqnqsyMEoW3jYW00lzS6WPw/hUKkyDF1GD3IOoT5TY26sDxoBdFrhRTnFYHHTLFk38lqcXM9ka6J/F1aPA7wgT8SWbodphI2DToXfdTX5JI15o9y+IXLp5U7YtI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=VWGHCJKZ; arc=none smtp.client-ip=212.227.15.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1705917029; x=1706521829; i=markus.elfring@web.de; bh=+nGU7Loi1Do4zrvl/0l3JM9LGLlkYeGwWtlVmkNopIo=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=VWGHCJKZ5HKy2AH+oYWepCu+OuIY6blJAyg/bPpK6HLRSvSs5yxnPOamVrbshYt3 uFDRo42NOZQlpWOEVUirGYt63kEPx3Jwf8edReMYZn5S2yrqwHxGCGAEqCUjJ+eGh 7HmMcdbfbS7l1C8VpYrGCyqnWjEUe62hkessfmc7JGr7xXBraVh+sskyFcbuCod+/ WxpA3XARTvBuVJsVhnHl2ZHDSegqGJTIkI2mg7wEArOFO76vkxglOnvP5V57CvPHj 6vixEG8r7EyF0sPjk2YdlOKZdtix2xxslEHjJbPVuf564UoxRCYp60L4i1wnmz93N tWb8kf9WBed/7ntMCw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.87.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MSIJA-1rYThF27UO-00Sh0e; Mon, 22 Jan 2024 10:50:29 +0100 Message-ID: <6d40b95e-2ed7-4f32-895e-a2174236ee65@web.de> Date: Mon, 22 Jan 2024 10:50:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v3] x86/xen: Add some null pointer checking to smp.c Content-Language: en-GB To: Kunwu Chan , xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org, Boris Ostrovsky , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Thomas Gleixner , x86@kernel.org Cc: kernel test robot , LKML , Ilya Dryomov , Jean Delvare , Jonathan Corbet References: <20240119094948.275390-1-chentao@kylinos.cn> <26ef811d-214c-4ce4-a9f8-4fa4cfdefe29@web.de> <6f25f54f-eecc-4765-bdc4-248674836e77@kylinos.cn> From: Markus Elfring In-Reply-To: <6f25f54f-eecc-4765-bdc4-248674836e77@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:7PuQIQ+STP1HEpxBb1F71REntJZh+zhVfsHo3QNQ2Y97EaG7Chu YZg+NMHWD7a8cWoCqPBaqIuW/1RiZ95h0IExGFidpRCIOSY9cJLbrYPImqSSO+d8zBIdfye 9szF1wZYZ/itaJHlMQ6w4DJUIsyBBuQ9qZ0nDe2Vb4wVFQ4MwNGbMZ4YvY1TmWAZaA+dkWA +S8b9V2h+w2RuVKyoIqlw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:yEsnbDcYv3s=;ZPb2Mu+H2XGola6RbrIcyQWyz/T ok93+jBiDKnY1DDXbD0Zifx5nXuoctjgIftPZMgZIr6+J0Ok/V4IQWfIX3rww8eDuhSWmqlvK 9qJflq3k1x97bT/azeoHOkoWJzI8tXhkHDYdN+ev96ILzZ9EL/wY5GeaUIcQHlekUDOjpfyTR OrGxEC3jyfaeGjdDH8Gn9CeDy27YGgHXSOrT+eHHQj77p6Gp0wzaPxB2+rW8TJ2ff2aRsw6aY pXIS+5vkwsSPVKxG5GjojJuUvcZl5XVGkNMAQgqX6BqSFIo/GXB/kqFgNwSgNbMM/p0DNdoun iaqRQcsiwb/XbIrR7D6zSTkMayqKL86oxZSEbdlX3qNfUOfYRF2wgoQhOxv0lHiPEm/itrbso tB7NEyziFnGFmr93Zee7Z9dOaTLbAGuZ/IIHTnsRhvShgIoqHO1fEo4Z5FolxJahE+tmdfxP3 1opwbsVgSPUTIONZ5Zmwx62rBUYhcvY/vd2w1paAXsD9dE9qBA8O4E4+TLxuUFrUVwpSf63tT RKyImNKQvIJMqAmltIcOcrgQpf/85/YxZCnfNsleS1TWANHUv87awcKOhicDB+6uzzTABEHaX V9ikk5FvhrtGe6B5f/8qrrzmW/rqFlbbIEk/T3zgJvWuLVL4Hm39kHppviwwcqh3hQAwRSuNW Q7B6/h7M+ykbB2NgaxDQKF6DqccJHP1nGAgz4J/5dqXsHJA7/VR4g/gVk+U1eJbX+A6hhlNeH h+XVBcSG7JPULvFvS99MaPwQK038pKGKeS8Fzu030ExOECSB2qT8UcQCnl3MwgRb/TWfU+pJu V8GAGqQuivpqsX0lj4ceZ5RV8s9BC1V4i1m/BNBYbwiddhzLYE//O2Hp0ptm32iebTaCGkpWr qBBVRgCm3h4iXgOrInS6rrAS/SDpbOsiCBz/oZkvu8TtRs9zrtkFfHsozotb0ujHHHsj9xzs1 GH3CTA== >> How do you think about to refer to the function name >> instead of the file name in the patch subject? >> > The main goal is to assign a errno to rc. So use 'fail_mem is good to understand. You responded with information which can fit to the patch body. How do you think about consequences for a subject variant like the following? x86/xen: Add some null pointer checks in xen_smp_intr_init() Regards, Markus