Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp229617rdb; Mon, 22 Jan 2024 02:09:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWxkWOF1VqL9hSyW8Wj8Dvw0KMouUrXraGY4eGcBn7ZflDJKFj7gyuYCrZyx56V/GEgAl2 X-Received: by 2002:a05:6402:4313:b0:55a:4959:a2e4 with SMTP id m19-20020a056402431300b0055a4959a2e4mr1905572edc.52.1705918142323; Mon, 22 Jan 2024 02:09:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705918142; cv=pass; d=google.com; s=arc-20160816; b=xsqXPTN1czAixp9lohEfS0SHBf+sxWAH6o1KyKxVymWaUQGwrhH34IApyTls0DTD3y ymyiFdnXjCMRDbJqNzU8Z1hU0x3dcV6MtCQXAH8gHyCzEwy0IoGhKlYU9QXGhFZVvHDX 9EBbqQfGClbFE1clieVvDrJPtt3g7MVJb+BnMqAonI7cBOv+DtgRRqmD2px2cPXzJkmI VjVZNtDOEaDtLDllHjP/KaI/Kss2pE2LLI58StFiquQDX9GydgmE1BDrFoAZbnAHW0x9 Ss+KDM+nhY52JR+twCtEnSR+GpEPpSfRTigoNWKS0rdvLAEcQrfGkNUrx87yvH2p91xD 0RlA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=fTg1GKoElQXtI92ElzyjxQkY95Oc2Gw5CPCoF4BKwq8=; fh=wxXivCMwTzRjm/TpN0CC4h2+1Uo71hhmby9OPggQFUU=; b=ZthyQglWu1GXCLEilLOrY+nO/XiULadny0LAjqLCZMsxo52901ZSxwlfE1ZD8kUgBp r2C/+EI1te9B0qV8Yf+YrAeoxtl/qgLKYvbV1GVYYsUd54IRZNVpy6P1YNVfpAPE3lMj wltBF9RqC8WvMKJkCohFNnnj+6fagDMfMv6AghkMs3X2XMlSlKFvrN7KcKszhzqzESDy Y9SninIASd5a34KBETBxrs+8QktmJDw9bB+29Ij5UsJJfj3wUm0GGMjE8cGsj5mZceQH Z+jkhuPEEZY4APSeKzECK7gk8t4WWX9v/btS777VDEhGY/ynd/WKvSmcBzBlX5kAMpvy D3sQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=XbLTyj35; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-32706-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32706-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id s12-20020a50d48c000000b0055c3b913bc4si798200edi.192.2024.01.22.02.09.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 02:09:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-32706-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=XbLTyj35; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-32706-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32706-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 15CEE1F26435 for ; Mon, 22 Jan 2024 10:09:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3A48F3A278; Mon, 22 Jan 2024 10:08:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="XbLTyj35" Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CF323A1C3; Mon, 22 Jan 2024 10:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.72.192.78 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705918098; cv=none; b=Bi0pHRAkXJEsWN3ZTJUYI9dUg5VcuBNRl8uGqTgGrAD5O8ZuyIa/P8Kb4xKjEOlh1nEhpl4A3Vqq+KoOriK0X0JjLZHf84kcifeVlzlt4XCGqMqZxyEFLXyPo1g3zWEj91VOsTAaymt/TD4lzR4/u5DDvp26GbH25zu9YMUz2IE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705918098; c=relaxed/simple; bh=fTg1GKoElQXtI92ElzyjxQkY95Oc2Gw5CPCoF4BKwq8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GSD2bWD1a3RXa/BDZeVyixQu1+BqldzHLA5NhQFspDKA/cy8RNuhOE+6thugGiwfkRP849RUXWtFmGnoG4uKy/k3MLdm9WdXO/PCwuKxeNlwwuVwp6w7fmAzUOqT6EKK6ilsMBWO+AKeY6DsC+3tYAeT+rMaaiILFugFOlRVI7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=XbLTyj35; arc=none smtp.client-ip=217.72.192.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1705918023; x=1706522823; i=markus.elfring@web.de; bh=fTg1GKoElQXtI92ElzyjxQkY95Oc2Gw5CPCoF4BKwq8=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=XbLTyj35Lb7jl1Yxk5KWnYotJUTzEV/OahrmTGAuvwBNAl3a+VwS5Yj6WbV0eTWT F8XF4+XunIdby/uzCcMOOXrbW1nz0ynfe+q8vz86czFsJHriEmDKJWjHye5gDjekJ 3zJdBiB8SvV6FuY74cI9jSzvCGCSRC5rAZdb8vLb9G06jExBKLSY6l4PqdiFcDwB8 Ce3nIBc9znPGdYrOIH8xCam1LgCpl7GlXMfteTWW3HyMt7yYNleZj0VLEuSafpBJX LdY5ZefXx197/9mhH7YnobqgSJ8w7SeTv9fyjuS3g01X41Md/kH696KNsDSTb+nmR fDZwscOeNJL4O01/SA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.87.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N1d7i-1qzQGl1nD6-011tRs; Mon, 22 Jan 2024 11:07:03 +0100 Message-ID: Date: Mon, 22 Jan 2024 11:06:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v2] x86/xen: Add some null pointer checking to smp.c Content-Language: en-GB To: Dan Carpenter , Kunwu Chan , xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org Cc: LKML , kernel test robot , Boris Ostrovsky , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Thomas Gleixner , x86@kernel.org, Jonathan Corbet References: <20240117090018.152031-1-chentao@kylinos.cn> <1705655941162581.825.seg@mailgw> <517fae75-c4e7-4576-81ff-6a14a3eb9cd7@kylinos.cn> From: Markus Elfring In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:TVWkH58C8d+xxHWHzHB64epa3s2plijd4rtx+6kS7ddQj8Suzvv naMuUTuD5EWLL2maurgo9AVz+dfWzvKtULBa/5Ve/rZFZcwKc9G46OszjBW7AP9yBR2RipX lK43Pd+vVigt/FjZRtStKTTDI5ju3W3XLb/WimEdl4OICVTk1/YmHkjTr/9CBQ1xYQ94yFA aDAE639lz9NSS4qWe7X9A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:dU6CzvMVSpk=;fSHtYB/+Ly6z8pY0YGpGVG3ymD3 S5R+AQd74kyXPO7x6bf/abdvDEWT2fFiA5grBn0s2z1asUGulEyqknQZVKJwf0tKu2SFstgor C/k1kCa4Q1jtgtl3ehPa0kPjTNaru70z78epFuFQTTS6fKSCe3ZrV7ekGai8+G8Hk7yOgiQXU FgIixZkdWM3rkJ54x8VUy6DnkxGN1mIkWIVQT87i2xg/BRetp7hS+LYad+RpxlHzxvABYaFMS yTWm8/CYgyNkKb64NqBPX/4EETyRZmoh4Pg/ONAtpFP6K6RRshD3XLN+LTIsf/dt4hPZ/OO6K zhJ3Jcd1jHt3rZbRkLwlP1aQTms2E3DXa/sPOTYIHuawGiZL43TXPy1nvG5Qu5XUD+uLR3UcV MSUBMqfOBKib4NuW2aKzkwhtbtHAoj5OPdJkdO0KL00ZXjJYha9ar9z4FwFEyZ1uJuyeyouRP /RqzuWH97IyQeevzIJ4G4ujdTPtemaWdj8C97cgBcFTGQaxF+AjXHFLnDnOeGwka7ehoySB4X WEQB4wDsnXTCEppwuZwANErLkf/0Pvy94yrRC2T6DmIt6v2LaBYQMXpvj02MO/hbZgv3mS7VR WC+u/TOo2Es1jI67Vg0HD/nGJCfItmhF37j4A2V3sXpaVksjIlhhi0btsiu+4OQdcvfv5633N daXMmq0nbOUPsumFU3SHFodudI05p3k4JBAYBudav4Z2nhG+sPc9ZQWskqP+FkFUVkln+jFT3 nhXJMMD1BxRr77e5AdkLzRBhX7B63C6MBSR9TfPXbS0+4aAQs2fzLWb9SsX3rDAPwldNNrgpa C3enyvAYKhgNNxSEoKwSHU0BTHyxrTSyvXXnSABRXE+7SqHuxuNl5W1vih1+iMORigNwPmFqs w0CgqXRGAAG4XNsHi8qw5xoGBkcwrbwWz964mjZpoza6mVBLAMBLcTHqiNvV8IEoGtqzH/hV/ lNYuYA== >>> How do you think about to use another label like =E2=80=9Ce_nomem=E2= =80=9D? >> I'll add a new label to simply the code. > > I'm not a Xen maintainer so I can't really comment on their style choice= s. Linux contributors can discuss various implementation details. > However, as one of the kernel-janitors list people, I would > say that not everyone agrees with Markus's style preferences. Can a corresponding document be improved accordingly? Centralized exiting of functions https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/coding-style.rst?h=3Dv6.8-rc1#n526 Do you find a related information source helpful? https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+go= to+chain+when+leaving+a+function+on+error+when+using+and+releasing+resourc= es Regards, Markus