Received-SPF: pass (google.com: domain of linux-kernel+bounces-32785-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <ad5c31cc-7cb6-4791-86fe-b2ba30abf33e@ti.com>
Date: Mon, 22 Jan 2024 16:18:43 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v2 1/3] net: ti: icssg-prueth: Add helper functions to
 configure FDB
Content-Language: en-US
To: Andrew Lunn <andrew@lunn.ch>
CC: Rob Herring <robh@kernel.org>, Dan Carpenter <dan.carpenter@linaro.org>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Vladimir Oltean
	<vladimir.oltean@nxp.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Arnd Bergmann <arnd@arndb.de>, Vignesh Raghavendra <vigneshr@ti.com>,
        Roger
 Quadros <rogerq@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski
	<kuba@kernel.org>, Eric Dumazet <edumazet@google.com>,
        "David S. Miller"
	<davem@davemloft.net>,
        <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <srk@ti.com>, <r-gunasekaran@ti.com>
References: <20240118071005.1514498-1-danishanwar@ti.com>
 <20240118071005.1514498-2-danishanwar@ti.com>
 <a9c18466-7d7d-4a63-8096-d832bd9e455f@lunn.ch>
From: MD Danish Anwar <danishanwar@ti.com>
In-Reply-To: <a9c18466-7d7d-4a63-8096-d832bd9e455f@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 19/01/24 7:25 pm, Andrew Lunn wrote:
>> +int icssg_fdb_add_del(struct prueth_emac *emac, const unsigned char *addr,
>> +		      u8 vid, u8 fid_c2, bool add)
>> +{
>> +
>> +	for (i = 0; i < ETH_ALEN; i++)
>> +		mac_fid[i] = addr[i];
> 
> ether_addr_copy()

Sure.

> 
>> +
>> +	/* 1-1 VID-FID mapping is already setup */
>> +	mac_fid[ETH_ALEN] = fid;
>> +	mac_fid[ETH_ALEN + 1] = 0;
>> +
>> +	fdb_slot = bitrev32(crc32_le(0, mac_fid, 8)) & PRUETH_SWITCH_FDB_MASK;
>> +
> 
>> +	fid_c2 |= ICSSG_FDB_ENTRY_VALID;
>> +	memcpy(&fdb_cmd.cmd_args[0], addr, 4);
>> +	memcpy(&fdb_cmd.cmd_args[1], &addr[4], 2);
>> +	fdb_cmd.cmd_args[1] |= ((fid << 16) | (fid_c2 << 24));
>> +	fdb_cmd.cmd_args[2] = fdb_slot;
> 
>> +int icssg_fdb_lookup(struct prueth_emac *emac, const unsigned char *addr,
>> +		     u8 vid)
>> +{
> 
>> +	for (i = 0; i < ETH_ALEN; i++)
>> +		mac_fid[i] = addr[i];
>> +
>> +	/* 1-1 VID-FID mapping is already setup */
>> +	mac_fid[ETH_ALEN] = fid;
>> +	mac_fid[ETH_ALEN + 1] = 0;
> 
>> +	memcpy(&fdb_cmd.cmd_args[0], addr, 4);
>> +	memcpy(&fdb_cmd.cmd_args[1], &addr[4], 2);
>> +	fdb_cmd.cmd_args[1] |= fid << 16;
>> +	fdb_cmd.cmd_args[2] = fdb_slot;
> 
> Maybe add some helpers to reduce the amount of duplicated code?
> 

Some codes are duplicated in icssg_fdb_add_del() and icssg_fdb_lookup().
I'll try to add helpers in next version to minimize this.

>       Andrew

-- 
Thanks and Regards,
Danish