Date: Sat, 15 Dec 2007 09:50:15 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: FInal kprobes rollup patches
Message-ID: <20071215085015.GA9720@elte.hu>
References: <1197708350.898.87.camel@brick>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1197708350.898.87.camel@brick>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 853
Lines: 28


* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> Further unification work.  There is a possible behavior change on 
> X86_32 here.
> 
> is_IF_modifier(p->opcode)
> 
> to
> 
> is_IF_modifier(p->ainsn.insn)
> 
> Which should be equivalent, but is not purely cosmetic as the rest of 
> the unification so far.

hm, could you split this into two, the pure-equivalence and the 
possibly-modifying patch? (that way any potential breakage becomes 
bisectable) Same end result, just two commits instead of one.

also, did you manage to run/test kprobes (on 32-bit or 64-bit x86), and 
it worked fine?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/