Received-SPF: pass (google.com: domain of linux-kernel+bounces-32864-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Paller, Kim Seer" <KimSeer.Paller@analog.com>
To: Conor Dooley <conor@kernel.org>
CC: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jonathan
 Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        "Hennerich,
 Michael" <Michael.Hennerich@analog.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>, Crt Mori <cmo@melexis.com>,
        Linus Walleij
	<linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        =?iso-8859-1?Q?Nuno_S=E1?= <noname.nuno@gmail.com>
Subject: RE: [PATCH v7 1/2] dt-bindings: iio: frequency: add admfm2000
Thread-Topic: [PATCH v7 1/2] dt-bindings: iio: frequency: add admfm2000
Thread-Index: AQHaTRHL38sLnWxA1EGaHMlrfAP5/LDllQgAgAAHLsA=
Date: Mon, 22 Jan 2024 11:06:08 +0000
Message-ID: 
 <PH0PR03MB7141A46C8DD0041775CD0E96F9752@PH0PR03MB7141.namprd03.prod.outlook.com>
References: <20240122090228.28363-1-kimseer.paller@analog.com>
 <20240122-legible-fossil-25349ef9ad6c@spud>
In-Reply-To: <20240122-legible-fossil-25349ef9ad6c@spud>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?kJ1I6SSqsnh6fBTkSZjEBKx5BFAnbtL0+a7BDYQXWB8i41Zml3+HQyi8lI?=
 =?iso-8859-1?Q?+d8pBgdHKzCUGxS+WsE3iUpmNL0jOISxvGcR8jC9HLYTtIO6ceakA2nTZm?=
 =?iso-8859-1?Q?8Payj0rOyQeUDQxzfWMQSbBlMNvzwBSbHmRrGABj1qIK4Yly/8iaOU6syV?=
 =?iso-8859-1?Q?qxrHQwKhlNStxB3xheDVeHIZjmlPEQSJ3AluVZX5HAkZN8SuQewm/cTBzu?=
 =?iso-8859-1?Q?YToxBJcJH3Dw069rNJEAK73OMtK6QayFkkvS6c47LafxLlxKBaVb0Q/9nN?=
 =?iso-8859-1?Q?H0ezTyxtzGmxE4CnJpl0/Wkl+d/5n2EFSW8fUZnoHojG9xNSuv8sNVq2so?=
 =?iso-8859-1?Q?RXWgdKcj1wLf0k+FB7B7qw6tcGDqx6r1Sn7gX22+L2DgNS6w25LYKAksVM?=
 =?iso-8859-1?Q?vOZO3B+UArzpMo++JOUc+tLqN9FfKJ7WF7Cqb8tikyc8J/hcFAUbBhsPbU?=
 =?iso-8859-1?Q?in9WYNuEPhnMdfQS0xHv4tgxzVvn5sYhwKWBY9SD3vANwUZZHrj7Mue41Q?=
 =?iso-8859-1?Q?6iJvNnVujJg8h4YR1i6gbL24DcnKzzjSnJ/wsgzLPVeimBh7asreuEEuYE?=
 =?iso-8859-1?Q?DXbtdyJ7HZGMX8uU26YiC/+0S8edMzDuzgnN+Qlj3AIba62/lSi3pmRa4/?=
 =?iso-8859-1?Q?BpWFRAunqhE+xsJ3qe/0saQFa0RlY7KmISKwp5zphWqr/3t0g+aSKG92np?=
 =?iso-8859-1?Q?oa4/+W5ihZdtSwb7DQbw2LLhPOcWPH4buLPSjeYp2+tCR6Bz3epmzJ2F3X?=
 =?iso-8859-1?Q?cBMYrj+pKJYKdTNKM17gsm+Z6XPRcwySQSYT7Uqgl7EVi2CWo4Prau6Six?=
 =?iso-8859-1?Q?wdT1+dNpDDrzSZ+jBDPktIRD9SgF+7uBXZwaMESe9tP12blRxpc8KkKCAR?=
 =?iso-8859-1?Q?opdeCWh+gJmk83Z2P/Id3q/T8sT9yAyi4X8aqVC+7OrPCgbJjnJsU/x4OQ?=
 =?iso-8859-1?Q?I7PdGPqhOf4LbNdNn8KeL6W/f2RtblhjHkQLl07AvfMhzivcyNOfUrPv9J?=
 =?iso-8859-1?Q?Slr2Z4mTLEHpY/cux5ky4L8xN61WcHfKUK1R3USoQlT8UDd/mtspxhw/mn?=
 =?iso-8859-1?Q?e3e17kCAE5eaAta24vRrcvL/ymnrQnl+9cY7hTOspfeTbfmDA8kEwcYwX0?=
 =?iso-8859-1?Q?1ra80YJvrKg/c6npgQUE6oNxngG839tzJpedMAlhZk+WqSepGNbKxumwF8?=
 =?iso-8859-1?Q?kKzn3n1OVsTtTM54NfAwJ7PgLBFHJIcFdBGyb8IbJmOC91ytBleErLbbPX?=
 =?iso-8859-1?Q?hgWqjHgP1JEh05wtsChqMO+b1TgZaXEQypo5u4XCxfLbc0mAxODIlfamWG?=
 =?iso-8859-1?Q?5P+ELia8cSE1qqVvGFFhlaJrmlii4VWyrJrx2NxGc9jnftSMpLPuc1dCTo?=
 =?iso-8859-1?Q?KyxWmjTSnOi0xn3WFdBufnT/5YQWqTA+TfQQyjeVbCjfTgViDpPpc4nkzc?=
 =?iso-8859-1?Q?pBGRhVpvmWprCmJa+R0q8kTyOdUduz60dnFpmz5Wxz5ZWM0kxrAx9QPfpi?=
 =?iso-8859-1?Q?YeJQz8QwP5MTZGtg5VQOsUXv7qL7Txmuhmv1K4uulKbmz4NfUaWxKzl17f?=
 =?iso-8859-1?Q?4UCpfXtptaGLy8I6cCHsut4/jxNm9z7oAYa/D0Yi9VX+Kw2raUl382sv0P?=
 =?iso-8859-1?Q?yMCpnPsnX2UIVJimBgkiltKnEY2FKtLjnk?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB7141.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c65b4c97-f7e1-4d33-db53-08dc1b3a22e6
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2024 11:06:08.6867
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZIKiefBJ85sfQtZXFmjAKIbyY/aOAmv+W2E/xbxRLYcca7IANWr8JZrOYz+YT8p0KE8PQ3YEvQBL3kr0+tvA+EXj0I0U1m+fGe+KX5Q4+eM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6750
X-Proofpoint-GUID: BksP4qGj7YGOpP0_6MQHapVcC5I3a4gA
X-Proofpoint-ORIG-GUID: BksP4qGj7YGOpP0_6MQHapVcC5I3a4gA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-22_01,2024-01-22_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015
 lowpriorityscore=0 impostorscore=0 priorityscore=1501 phishscore=0
 spamscore=0 adultscore=0 mlxscore=0 suspectscore=0 bulkscore=0
 mlxlogscore=980 malwarescore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.19.0-2311290000 definitions=main-2401220079

> > +      adi,mixer-mode:
> > +        description:
> > +          Enable mixer mode.
> > +        type: boolean
> > +
> > +      switch-gpios:
> > +        description: |
> > +          GPIOs to select the RF path for the channel.
> > +          SW-CH1   CTRL-A   CTRL-B
> > +          SW-CH2   CTRL-A   CTRL-B    CH1 Status        CH2 Status
> > +                   1        0         Direct IF mode    Mixer mode
> > +                   0        1         Mixer mode        Direct IF mode
>=20
> I cannot make sense of this table you have here, the double header row yo=
u
> have going on is hard to follow. There's also no mention here of what hap=
pens
> when both GPIOs are 0 or both GPIO are 1. Are these configurations permit=
ted?

I also feel that it's quite hard to understand without the gridlines. In th=
e preliminary
datasheet, it's a switch control table, and I'm trying to replicate the way=
 it is presented.

On the table, each channel has control pins (CTRL-A and CTRL-B). For a mixe=
r mode
configuration on channel 1, CTRL-A GPIO should be 0, and CTRL-B GPIO should=
 be 1.
It's not permitted when both GPIOs are 0 or both GPIOs are 1. The state for=
 the GPIO
should strictly follow the truth table.

I'm considering making it much easier to understand by creating two separat=
e tables for
each channel, just like the example below. Or is it preferred if it could b=
e discussed in=20
a sort of paragraph form?

SW-CH1   CTRL-A   CTRL-B    CH1 Status            CH2 Status
	   1              0              Direct IF mode     Mixer

SW-CH2   CTRL-A   CTRL-B    CH1 Status            CH2 Status
          	    0            1               Direct IF mode     Mixer

Best regards,
Kim