Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp259426rdb; Mon, 22 Jan 2024 03:24:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IH4TlGHs24EIevyScuzvmA8NaY0yYQD5AHj32z7b8Gz+tJXrLLlTz+YmmkCtQjP4l/n+O7B X-Received: by 2002:a17:902:c94e:b0:1d5:3100:5365 with SMTP id i14-20020a170902c94e00b001d531005365mr1681552pla.27.1705922669095; Mon, 22 Jan 2024 03:24:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705922669; cv=pass; d=google.com; s=arc-20160816; b=e//xcpmKXZWhL+RF8iWf8aWNXeg0PJRoCuJScYsVSjwAy0Tjv/k3F/avxYaoq078dS r4xqi/zrCrMspGWNc3cbCFEwlwii626zWAyn6AtGsnixO7E4/6JznWFir91iK4jmUev1 UmqBBNti36asCSnuelOy5A4cKFSd/SHrx2XUDqU3nQG9IpA0xH2Rdm4fA/no2xER4BwB xSdDffkfugkpG6B4Z9GdCUuHDStNEVBCi6sGUieI3Qh0sucUO1vP+y3VZYC7XfJuijfM JMh5CddSz8VnsuljGNRJ2WTL6tPUSqdCEnqFscSz4mLicVrgGMA2+0cMklYkHiA0aw9B BgTQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=BomGdr3zph+RbyeW62SV+s3dc8I4NnnTpRyEiySaDz8=; fh=v15Klx5Q3JsK1gKWZ56E03S8MjDlDUl7sLu8KrxexMg=; b=uqPu2YA+bl2NB4tZEK4PICf0BWk8NhyljtCY75eQcnM5XewsD9vQ00CQ2qwwoEG2cN xlIW+sFUf/8N97m4j0YfDE5pABjmhxwnrpiqBeFWrkE+vLJbMVoJB1TnUBZSjN/Ic8Eb nZfktdBu4Yv3UPVWru4I0/hwmy1KHw+uCfug1dlu23UuIyRsdgnUeARw8t6dAHGOKuxS vbiQbiSaypevxDGBrWwRGX5I1mOF934iYnErg4mgIss9l0kBCRjZlM4sJmEdDPtz3L9N n935wulqAaOnW7YOq9gqXNbIsfbigYa7bmg23le0OcBuykGNsXxDamQWjMXFGgDziaOU A/iA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@rock-chips.com header.s=default header.b=JcARR62G; arc=pass (i=1 spf=pass spfdomain=rock-chips.com dkim=pass dkdomain=rock-chips.com dmarc=pass fromdomain=rock-chips.com); spf=pass (google.com: domain of linux-kernel+bounces-32784-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32784-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id iz5-20020a170902ef8500b001d723a0f48dsi5349296plb.136.2024.01.22.03.24.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 03:24:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-32784-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@rock-chips.com header.s=default header.b=JcARR62G; arc=pass (i=1 spf=pass spfdomain=rock-chips.com dkim=pass dkdomain=rock-chips.com dmarc=pass fromdomain=rock-chips.com); spf=pass (google.com: domain of linux-kernel+bounces-32784-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32784-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 37248B28490 for ; Mon, 22 Jan 2024 10:48:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E8DC3A262; Mon, 22 Jan 2024 10:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="JcARR62G" Received: from mail-m12772.qiye.163.com (mail-m12772.qiye.163.com [115.236.127.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75BB939863; Mon, 22 Jan 2024 10:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.236.127.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705920525; cv=none; b=DxWsuncJZzZCy0+ygX5fw2tsnC7PH8AabmL77aLpQqbCSsq3BGQeZm6woLHogNvUu+A6Lz3hLwjrPIAHG++2huhEXVVdGB2KvIZek7plxhjltcyn+tTCjnr1XwzX98xHin/smuVt9PfDcwq5GnRvBPbi0AWtiXrSy8v+cYLBdzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705920525; c=relaxed/simple; bh=2D2Bz6kHSRQ55n//fD6i/rFr8iCWh5oGDoAjdduw0V8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Whe4I+WCpWtLFYmWEnVke/rUa74wvg7+IOZEHD2YqvFjI2EFuqLnVUjguvayzjRQabiXtvosQuDm2usoFgkskg2i1zl+GKlP/32LAMqFnkRiHM0zOU8nw0p4AGaIAQSiYGGToHN28V2hP5fxbCy0rmt90MX85o9MmeDqo74RYkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=JcARR62G; arc=none smtp.client-ip=115.236.127.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com DKIM-Signature: a=rsa-sha256; b=JcARR62G5KtOTczFX/WYMFJwV/BvIRt2AmOWqsI1F5xn2azbR1xwfIQam//ayqB3aKfspGrMC9fY0tBB9FZzT3sHJBj+EPjveLpBsCzGMyHfQlzypNXyQiP9gFsfBZu93//q/pt3zAbRPddIoN9HshO+YNMClt/SwMbIfbfH+ZI=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=BomGdr3zph+RbyeW62SV+s3dc8I4NnnTpRyEiySaDz8=; h=date:mime-version:subject:message-id:from; Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m12758.qiye.163.com (Hmail) with ESMTPA id E3EF3AE04E2; Mon, 22 Jan 2024 18:10:13 +0800 (CST) Message-ID: Date: Mon, 22 Jan 2024 18:10:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Add support for RK3588 HDMI/DP Combo PHY To: Cristian Ciocaltea , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , Johan Jonker , Sebastian Reichel , Sascha Hauer , Algea Cao Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20240119193806.1030214-1-cristian.ciocaltea@collabora.com> <417281cd-23b1-4948-8c5a-b9820dff65aa@collabora.com> Content-Language: en-US From: Andy Yan In-Reply-To: <417281cd-23b1-4948-8c5a-b9820dff65aa@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGUxIGlZDSEwdGU1LHkodSxlVEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSk1PSU5IVUpLS1VKQk tLWQY+ X-HM-Tid: 0a8d30a6318cb225kuuue3ef3ae04e2 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6KzY6FRw*HTwhEA83TjcdMxAS TAFPCTNVSlVKTEtOQkpDSUpOS0pLVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBSEpJSjcG Hi Cristian: On 1/20/24 07:41, Cristian Ciocaltea wrote: > On 1/19/24 21:38, Cristian Ciocaltea wrote: >> Add driver and bindings to support the Rockchip HDMI/eDP TX Combo PHY >> found on RK3588 SoC. >> >> The PHY is based on a Samsung IP block and supports HDMI 2.1 TMDS, FRL >> and eDP links. >> >> The HDMI link has been tested on Rock 5B and EVB1 boards. > > I missed to highlight there is no eDP support provided by the current > implementation. Downstream kernel has a separate driver for that and at > the moment I don't have the hardware to wire this up. > > Will include this statement in v2. The PHY is used for HDMI and eDP on rk3588, and should used be exclusively. so I think should s/DP/eDP/ in all description.