Received-SPF: pass (google.com: domain of linux-kernel+bounces-32910-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240122092338.25047-2-rsalvaterra@gmail.com> <0b6f3998-135f-4059-a8a8-e924281353f8@linux.intel.com>
In-Reply-To: <0b6f3998-135f-4059-a8a8-e924281353f8@linux.intel.com>
From: Rui Salvaterra <rsalvaterra@gmail.com>
Date: Mon, 22 Jan 2024 11:21:40 +0000
Message-ID: <CALjTZvZoH-+yZz5Z7237rhM5BxknFbG_Bt-dkperpgfLKfcAuQ@mail.gmail.com>
Subject: Re: [PATCH] ALSA: hda: Increase default bdl_pos_adj for Apollo Lake
To: =?UTF-8?B?QW1hZGV1c3ogU8WCYXdpxYRza2k=?= <amadeuszx.slawinski@linux.intel.com>
Cc: tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi, Amadeusz,

On Mon, 22 Jan 2024 at 11:05, Amadeusz S=C5=82awi=C5=84ski
<amadeuszx.slawinski@linux.intel.com> wrote:
>

[snipped]

> And seems like I've missed some IDs, when doing PCI IDs conversion.
> Anyway, can you use PCI_DEVICE_ID_INTEL_HDA_APL instead of 0x5a98 as it
> is self describing (no need for comment)?

Oh, of course! I would have done it if I knew we had those constants define=
d. :)

> And if you want more patches in kernel - convert first 0x0f04 & 0x2284
> to PCI_DEVICE_ID_INTEL_HDA_BYT & PCI_DEVICE_ID_INTEL_HDA_BSW and then do
> the above change ;)

Killing magic numbers is always a worthwhile goal. Expect a two-patch
series soon, then. ;)

Cheers,
Rui