Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp267596rdb; Mon, 22 Jan 2024 03:43:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHTPMh6Hze0OTIaUorhBkf2Oq4bgLJ6tq0hRVE//bROMTeEYhT1n6WluraelleQZIbQdgO7 X-Received: by 2002:a05:6358:2241:b0:175:8ebb:11d4 with SMTP id i1-20020a056358224100b001758ebb11d4mr954562rwc.26.1705923826637; Mon, 22 Jan 2024 03:43:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705923826; cv=pass; d=google.com; s=arc-20160816; b=HM12ST/TlyKTclNo6TnTVfEMrEebIxtZGg3TS9pqZl8Zv8pONVHDBoWVpaE2O0/BzW L5ZMoc4mRJtOO1oOFiLGVOfAJzgs5adVQI+159ReeQAJH/WAgFAEF4/TuBT8zbF7SAcK I2KvlxnbSh+gvqkBAWKlq5IxsvobIKAPPhuOZEXemnCLzkX3edTfcey/rwF5FoZm1468 TKHn2057e8UTlkPnwPzVu3ALsVPbNxq4d/ekbeNhkW6X64yp9SYuCqBZjeIqgFWOOLK7 Z2MPTfEGLLJfbfJQoOO3isIfB6am19e0inqg7Ge57Iezm90tI8bHWMKcBKX9Lppesp1C x+Lw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MTi7xmgGiBFP8+dokgoZHp2fZz8TpLZjM5ORW+014tk=; fh=N+Fpb1/d4Y+2u4FHRPUzj5VNGKYa3w3Fp9XVUwiFZtQ=; b=THyoQjk2SB3BblXmoQqTcatoUweIRk3DIm10mWYsvJqNbVe3I48l6BmT8k0/R6NF44 dSOS2K1S2pkPhFMgnusjYHOAKkQKpze4k+Q05ZcEfoNU+TV86df1rJlcH7+ycCw7ZXMp QT6dBsVoT4ncT42M1rH3XQbOezSWRnPQwNVmudYZSrvjKExq5vv9sNFpwKohuKBf/0pD R+jOIWTSKEyiMblEGkTMr4o6xEal1hRjDxeuUszvsNAzP+NNy+MKm/OpfdmBuyOb2FWY mUgaz1ngbkS6gq2BAp2sPIPfjCpsHqRM6Z1Q23TmTGD3PSGwHVmfNIFJFBbawFU+cjC4 k31Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LeZRFDWB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-32935-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32935-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z27-20020a637e1b000000b005ceca1c9d14si7851982pgc.260.2024.01.22.03.43.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 03:43:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-32935-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LeZRFDWB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-32935-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32935-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3A8FC28F010 for ; Mon, 22 Jan 2024 11:41:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A05AF3BB38; Mon, 22 Jan 2024 11:32:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LeZRFDWB" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C28B71DFF3; Mon, 22 Jan 2024 11:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705923168; cv=none; b=s/LmjE9JzY7lqup1Q0D5PrF7NXUjjOKmnXly8VXx3nxKjdaBAvPe01K7J+gkD/eteXQmOQhe+ZM7zajJZpRk/esFRPEZDx4VqKXmqc4VMJnqIMoo9X7+2F7dLLK1YPUsATX2w15H/0J4i4DwA3hRM+fOsVrKJCCmXB2My/4f5Vg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705923168; c=relaxed/simple; bh=uDy/5VBSa8J4k7spOOc9VWyfuTTwmCdLUf/HonS9y3w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DhmmARDm+pQR5n/WsaulL2MnGU3kFPsMg2lEOFIvpgAa1RNWONhpMG7mRY3PQgvLLe1qCxcN/t4L0jvuc7XLmSzRLFSkhpjxnWGe3QIoHgi0zFlI+dZBnpJjxBE9ND3SOVjMXGk9kfSZxRTziC3oR+w3h9p/BGTGnF2bCHBjqWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LeZRFDWB; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC6FAC433C7; Mon, 22 Jan 2024 11:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705923168; bh=uDy/5VBSa8J4k7spOOc9VWyfuTTwmCdLUf/HonS9y3w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LeZRFDWBtG4m+vzh0CM0FpBZgpXzK+0ecxKH/VyLqiQSj+G+Je7HBvO5vGED9OJHg 9sV4xhBBF9IIS432+5yOTFnMllWWtFeRih1BT8Bs0GymuFHpuQgAhAnFUBNUFNLl6c 8CUzve+N4QmRypTLWrJTu6ZqFZjfEPHOuXIlQBBEB7BrBqZ9KE84HwTWiE9NTVO3hY XloT+zFbYb02uk7LZoGvKVZ3C5+0nOhH19+8VTfojS/VOorMPLtJAJEsuxDJAtm8dd L7iJoht57ux6s3bdQEHbelQmhYzMsz4+iZ3hTx0MGsZfll9oTbkhKjem9svnbkhHQV FymWMC0lYTdgA== Date: Mon, 22 Jan 2024 17:02:43 +0530 From: Vinod Koul To: Markus Elfring Cc: dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org, LKML , cocci@inria.fr Subject: Re: [PATCH 0/3] dmaengine: timb_dma: Adjustments for td_alloc_init_desc() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 25-12-23, 11:15, Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 25 Dec 2023 11:05:45 +0100 > > A few update suggestions were taken into account > from static source code analysis. was this anaysis done by you or some tool reported this. Frabkly I dont see much value in these patches, can you fix something real please > > Markus Elfring (3): > Return directly after a failed kzalloc() > Improve a size determination > One function call less after error detection > > drivers/dma/timb_dma.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > -- > 2.43.0 -- ~Vinod