Received-SPF: pass (google.com: domain of linux-kernel+bounces-32968-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Luis Henriques <lhenriques@suse.de>
To: "Jarkko Sakkinen" <jarkko@kernel.org>
Cc: "David Howells" <dhowells@redhat.com>,  "Eric Biggers"
 <ebiggers@kernel.org>,  <keyrings@vger.kernel.org>,
  <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2] keys: update key quotas in key_put()
In-Reply-To: <CYIZP2D9FS0N.1XY2F5VX9STEY@seitikki> (Jarkko Sakkinen's message
	of "Fri, 19 Jan 2024 21:10:15 +0000")
References: <2744563.1702303367@warthog.procyon.org.uk>
	<20240115120300.27606-1-lhenriques@suse.de>
	<CYIZP2D9FS0N.1XY2F5VX9STEY@seitikki>
Date: Mon, 22 Jan 2024 11:50:11 +0000
Message-ID: <87il3llh8s.fsf@suse.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

"Jarkko Sakkinen" <jarkko@kernel.org> writes:

> On Mon Jan 15, 2024 at 12:03 PM UTC, Luis Henriques wrote:
>> Delaying key quotas update when key's refcount reaches 0 in key_put() has
>> been causing some issues in fscrypt testing.  This patches fixes this te=
st
>                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~=
~~~
> 						This commit fixes the test
>
>> flakiness by dealing with the quotas immediately, but leaving all the ot=
her
>> clean-ups to the key garbage collector.  Unfortunately, this means that =
we
>> also need to switch to the irq-version of the spinlock that protects quo=
ta.
>
> The commit message fails to describe the implementation changes.
>
> You have a motivation paragraph but you also need to add implementation
> paragraph, which describes how the code changes reflect the motivation.

Thank you for your feedback, Jarkko.  I'll address your comments in v3.

But before sending another rev, I'll wait a bit more, maybe David also has
some feedback on the implementation.

Cheers,
--=20
Lu=C3=ADs