Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp301164rdb; Mon, 22 Jan 2024 04:52:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFaTTBpyK4kPZ6urPBgTOl1loOrkRcu1SGf4ZhWtz22dvyesA/rT5ugzmXyOz6LXBChfXdc X-Received: by 2002:a0d:d849:0:b0:5ff:82dd:35d2 with SMTP id a70-20020a0dd849000000b005ff82dd35d2mr3221918ywe.10.1705927933039; Mon, 22 Jan 2024 04:52:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705927933; cv=pass; d=google.com; s=arc-20160816; b=KNsiZAniS1L4kHy2U8gNDViH2zNCpESr1Jh0lQjwwrlvxg3tjRZgc2mieTFqV66sAD TBRYx+6UnCmhmiIJYex+1aX+R5GITwMpX+O/0F3q/MQI0bmvHvVILaypdqrwbbBPGrBS uf0wOFhMJjJeb1Grl6+Ai9GZbAbfMQaNdm/QQZ0rgyDovzzHwAHc11jl+I+F4mAz8PQt 3H2gqdeBpvz2HPEsVqz2tVYZyNXHwdxs4+KQpXDUSofciq8OxcCE5wiwgG+Cx436/KKu SNNKpsEG+BnFVeuaG041kTunOr06B2yioEfX4PKoFuOtgaK5ZOLiFgNpLvD78fLJ4MTr 3Bmg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:in-reply-to:date:subject:cc:to:from:user-agent :references:dkim-signature; bh=oYs+OyRygTZUxxYWa0xQLieUOiH7k2b7WLVgy3jTVKA=; fh=1962S2OrCo0Hx276EneUmu8Qacghmz0hsc302oMIFwU=; b=H+n6W8pe3mi1vcd+zbl65oUXauItIDWaQ560CYbq/TOUgVSq1b3MKmcz8rfOwUrmj7 SRyZKgd3MBPaFKqVIARx3VVlrPtDzuL+uY9PcldS1h1Hsvb071fEJ5mB1l0TNS1w9CsG zerWb9RWUKV+6fDQOjd0mmBS09/lhjfKAsdMFCnZqx8IPnfYsJJtVyySnAl7PyLcL32h 7kB7n7bH4g+C5Fttiq0h6x+57akHPpAVUVQZss45zUrjNfjGFahQ2ylsetvHw8Kq/li9 tw6ZvvT+VQSG2kabrowIXKuvoL5m+Mw8DpGTdniPcmu+Ag677tKXZEPBxPh8Ql7UrunN y+yg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NpDuKI7y; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-33052-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33052-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h4-20020a05622a170400b0042a35029caesi4138939qtk.774.2024.01.22.04.52.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 04:52:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-33052-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NpDuKI7y; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-33052-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33052-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C4E631C23224 for ; Mon, 22 Jan 2024 12:52:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6C4F53BB50; Mon, 22 Jan 2024 12:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NpDuKI7y" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 985716FC6; Mon, 22 Jan 2024 12:52:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705927923; cv=none; b=lbXq2Wd2rhZqn5Uqqkkq+939jysHBMX4Ndg8GMjlPU+bqwVS7ju0Iv/wtSbVbqPsJM5d1bi3RQAV+XKjdB/gLjynCFaWqNKk4mxc5PhBUcz1sCRif664C+omeNNeeh+y3EV4VBbu8IfJTBKu3boDkjKZGwKihA+RE1E4BHxeDiM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705927923; c=relaxed/simple; bh=ek12Fo9+h/4gxnTkeDIXoNZF4jS2nFpEnjFmagMNSVw=; h=References:From:To:Cc:Subject:Date:In-reply-to:Message-ID: MIME-Version:Content-Type; b=mzL2zGMpGyvv8HlehrkarYNP1H4zYwj/eQqtEsyg/OcL2x6z0p+Xl9pRNOWEYbG+thoC1hB41W5KyDk9syceg+R7c14+K6BahYFhwqBaqbUqX2kfLK7fss5gU/7z5sX/rvUcvD+0xpRMPOO5MR/JO0R6zmfg7hYHuI9vGp+/Cco= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NpDuKI7y; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92C93C433C7; Mon, 22 Jan 2024 12:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705927923; bh=ek12Fo9+h/4gxnTkeDIXoNZF4jS2nFpEnjFmagMNSVw=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=NpDuKI7yKNYuy8wthqSQwDgQQBYVZqJvcFqo3awd88GUCmPF9FN0Fxb4UWuev00Pt 8Ili9LGviWHYYkkR5jr7h1ejQf7khSKkLS/lFZ+2bQ8/gZZDN9N9IiB5k9HF57G51i C8hOjqvIXYakMF9uQbsa2COrnB8cwbbFbMwOZn1X5FWIsXZaYPkh4c5MllkP4zPdhV 07jL4lUzKOZ93chhgwXdAmTKfvVeU8gSUNdvdQ6NJTWGhnV9Onj4155hB8GZmM55VA 7b8go8un2NnBrAQPhWikohnHF906uYAUBQ5yA0k+QVV4nAe+mmyUMYzlc2qlAPh8NU 0nbV1Nz5pAs2A== References: <20240118080326.13137-1-sshegde@linux.ibm.com> <20240118080326.13137-3-sshegde@linux.ibm.com> User-agent: mu4e 1.10.8; emacs 27.1 From: Chandan Babu R To: Shrikanth Hegde Cc: linux-kernel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, linux-xfs@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, mingo@kernel.org, peterz@infradead.org, anton@tuxera.com Subject: Re: [RFC PATCH 2/3] fs: remove duplicate ifdefs Date: Mon, 22 Jan 2024 18:20:13 +0530 In-reply-to: <20240118080326.13137-3-sshegde@linux.ibm.com> Message-ID: <87cyttedjj.fsf@debian-BULLSEYE-live-builder-AMD64> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Jan 18, 2024 at 01:33:25 PM +0530, Shrikanth Hegde wrote: > when a ifdef is used in the below manner, second one could be considered as > duplicate. > > ifdef DEFINE_A > ...code block... > ifdef DEFINE_A > ...code block... > endif > ...code block... > endif > > There are few places in fs code where above pattern was seen. > No functional change is intended here. It only aims to improve code > readability. > Can you please post the xfs changes as a separate patch along with Darrick's RVB tag? This will make it easy for me to apply the resulting patch to the XFS tree. -- Chandan