Received-SPF: pass (google.com: domain of linux-kernel+bounces-33109-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To:  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Paul Burton <paulburton@kernel.org>, linux-mips@vger.kernel.org, Jiaxun
 Yang <jiaxun.yang@flygoat.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,Vladimir
  Kondratiev <vladimir.kondratiev@mobileye.com>, Tawfik Bayouk
 <tawfik.bayouk@mobileye.com>, Alexandre Belloni
 <alexandre.belloni@bootlin.com>, =?utf-8?Q?Th=C3=A9o?= Lebrun
 <theo.lebrun@bootlin.com>,
 Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v6 00/15] Add support for the Mobileye EyeQ5 SoC
In-Reply-To: <20240118155252.397947-1-gregory.clement@bootlin.com>
References: <20240118155252.397947-1-gregory.clement@bootlin.com>
Date: Mon, 22 Jan 2024 14:47:21 +0100
Message-ID: <87frypv5sm.fsf@BL-laptop>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Gregory CLEMENT <gregory.clement@bootlin.com> writes:

Hello Thomas,

> Hello,
>
> The EyeQ5 SoC from Mobileye is based on the MIPS I6500 architecture
> and features multiple controllers such as the classic UART, I2C, SPI,
> as well as CAN-FD, PCIe, Octal/Quad SPI Flash interface, Gigabit
> Ethernet, MIPI CSI-2, and eMMC 5.1. It also includes a Hardware
> Security Module, Functional Safety Hardware, and MJPEG encoder.
>
> One peculiarity of this SoC is that the physical address of the DDDR
> exceeds 32 bits. Given that the architecture is 64 bits, this is not
> an issue, but it requires some changes in how the mips64 is currently
> managed during boot.
>
> In this sixth version, I tried to fix the last two issues I found to
> merge the series. The first one is about using dedicated platform
> support while still reusing code as much as possible, following
> patches 13 and 14.The second point is about the "Fix kernel in XKPHYS"
> series I added, which has some issues reported by Thomas. At first, I
> only kept the necessary part for booting with XKPHYS, leaving out the
> clean-up and optimization. Then, I addressed two concerns in this
> series by adding an extra macro in the "MIPS: spaces: Define a couple
> of handy macros" patch. Lastly, I attempted to make the changes more
> concise and focus solely on a single purpose in the "MIPS: Allows
> relocation exception vectors everywhere" patch.

What do you think of these series? Does it match your requirements? I am
about to send a new version, taking into account the remarks from Jiaxun
about the configuration. However, before doing this, I would like to
know if more changes are needed.

Thanks,

Gregory

>
> To build and test the kernel, we need to run the following commands:
>
> make eyeq5_defconfig
> make vmlinuz.itb
>
> Changelog:
>
>  v5 -> v6:
>
>     - From series v5, patches 1 ("MIPS: Export higher/highest
>     relocation functions in uasm") and 3 ("MIPS: genex: Fix
>     except_vec_vi for kernel in XKPHYS)" have been removed as "MIPS:
>     Allow vectored interrupt handler to reside everywhere for 64bit"
>     and "MIPS: Remove unused shadow GPR support from vector irq setup"
>     address the same requirement.
>
>     - From series v5, patches 8 to 12 have been removed as they are
>     not mandatory to support EyeQ5 SoCs.
>
>     - The 1st patch of series v6 ("MIPS: spaces: Define a couple of
>     handy macros") has been modified to add the extra macros
>     CKSEG[01]ADDR_OR_64BIT.
>
>     - Patch 3 ("MIPS: Allows relocation exception vectors everywhere")
>     is a merge of patches 6 ("MIPS: Refactor mips_cps_core_entry
>     implementation) and 7 ("MIPS: Fix cache issue with
>     mips_cps_core_entry") from series v5. It has been rewritten to
>     reduce the diff stat; the 64-bit fixes have been moved to patch 5
>     ("MIPS: cps-vec: Use macros for 64-bit access").
>
>     - Patch 13 ("MIPS: Share generic kernel code with other
>     architecture)" is a new one allowing separate platform support in
>     the patch ("MIPS: Add support for Mobileye EyeQ5").
>
>  v4 -> v5:
>
>    - Improve commit messages for patch 3, 5, 12 and 13.
>
>    - Fix style in patch 9
>
>    - Really enable SPARSMEM and use correct address in
>      board-eyeq5.config in patch 21
>
>  v3 -> v4:
>
>  - Fix build warning in "MIPS: Get rid of CONFIG_NO_EXCEPT_FILL":
>    check that we are in 64bit mode before using KSEG0 that exist only
>    in this mode.
>
>  - Modify "MIPS: spaces: Define a couple of handy macros" to be
>    buildable in 32bit mode.
>
>  - Use correct format specifier to print address in "MIPS: traps: Give
>    more explanations if ebase doesn't belong to KSEG0"
>
>  - In "MIPS: generic: Add support for Mobileye EyeQ5",remove
>    CONFIG_ZBOOT_LOAD_ADDRESS from board-eyeq5.config, (as well as
>    CONFIG_USE_XKPHYS that does not exist anymore) and add
>    CONFIG_SPARSEMEM_MANUAL to enable SPARSMEM.
>
> v2 -> v3
>
>  - Added more reviewed-by and acked-by tags
>
>  - Fix sorting for cpus entries in
>
>  - Fix indentation issue in Documentation/devicetree/bindings/mips/mobileye.yaml
>
>  v1 -> v2
>
>  - Added reviewed-by and acked-by tags
>
>  - Fix typos reported
>
>  - In patch 15 use 'img' vendor string instead of mti
>
>  - In patch 16 modify licence
>
>  - In patch 17 give more explanations about the block usage.
>
>  - In patch 18, remove _ in node names, don't use anymore
>    CONFIG_BUILTIN_DTB in Makefile, remove macro, modify licence.
>
>  - In patch 19 remove most of the bootargs and only keeps earlycon. I
>    also split the memory in 2 part in the device tree.
>
>  - Integrate the series from Jiaxun Yang
>    https://lore.kernel.org/linux-mips/20231027221106.405666-1-jiaxun.yang@flygoat.com/
>
>   They are patches 2 to 6 and 8 to 12
>
>   Then I added patch 7 to fix the cache issue visible on the Mobileye
>   platform, I also add patch 13 to improve warning message when ebase
>   doesn't belong to KSEG0
>
> Regards,
>
> Gregory
>
> Gregory CLEMENT (13):
>   MIPS: spaces: Define a couple of handy macros
>   MIPS: traps: Give more explanations if ebase doesn't belong to KSEG0
>   MIPS: cps-vec: Use macros for 64bits access
>   dt-bindings: Add vendor prefix for Mobileye Vision Technologies Ltd.
>   dt-bindings: mips: cpus: Sort the entries
>   dt-bindings: mips: cpu: Add I-Class I6500 Multiprocessor Core
>   dt-bindings: mips: Add bindings for Mobileye SoCs
>   dt-bindings: mfd: syscon: Document EyeQ5 OLB
>   MIPS: mobileye: Add EyeQ5 dtsi
>   MIPS: mobileye: Add EPM5 device tree
>   MIPS: Share generic kernel code with other architecture
>   MIPS: Add support for Mobileye EyeQ5
>   MAINTAINERS: Add entry for Mobileye MIPS SoCs
>
> Jiaxun Yang (2):
>   MIPS: Fix set_uncached_handler for ebase in XKPHYS
>   MIPS: Allows relocation exception vectors everywhere
>
>  .../devicetree/bindings/mfd/syscon.yaml       |   1 +
>  .../devicetree/bindings/mips/cpus.yaml        |  13 +-
>  .../devicetree/bindings/mips/mobileye.yaml    |  32 ++
>  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>  MAINTAINERS                                   |  12 +
>  arch/mips/Kbuild                              |   1 +
>  arch/mips/Kbuild.platforms                    |   1 +
>  arch/mips/Kconfig                             |  65 ++++
>  arch/mips/boot/dts/Makefile                   |   1 +
>  arch/mips/boot/dts/mobileye/Makefile          |   4 +
>  arch/mips/boot/dts/mobileye/eyeq5-epm5.dts    |  24 ++
>  .../boot/dts/mobileye/eyeq5-fixed-clocks.dtsi | 292 ++++++++++++++++++
>  arch/mips/boot/dts/mobileye/eyeq5.dtsi        | 131 ++++++++
>  arch/mips/configs/eyeq5_defconfig             | 109 +++++++
>  arch/mips/generic/Makefile                    |   6 +-
>  arch/mips/include/asm/addrspace.h             |   5 +
>  arch/mips/include/asm/mach-generic/spaces.h   |   4 +
>  arch/mips/include/asm/mips-cm.h               |   1 +
>  arch/mips/include/asm/smp-cps.h               |   4 +-
>  arch/mips/kernel/cps-vec.S                    |  54 +---
>  arch/mips/kernel/smp-cps.c                    | 171 ++++++++--
>  arch/mips/kernel/traps.c                      |   7 +-
>  arch/mips/mobileye/Kconfig                    |  12 +
>  arch/mips/mobileye/Platform                   |  16 +
>  arch/mips/mobileye/board-epm5.its.S           |  24 ++
>  arch/mips/mobileye/vmlinux.its.S              |  32 ++
>  26 files changed, 943 insertions(+), 81 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mips/mobileye.yaml
>  create mode 100644 arch/mips/boot/dts/mobileye/Makefile
>  create mode 100644 arch/mips/boot/dts/mobileye/eyeq5-epm5.dts
>  create mode 100644 arch/mips/boot/dts/mobileye/eyeq5-fixed-clocks.dtsi
>  create mode 100644 arch/mips/boot/dts/mobileye/eyeq5.dtsi
>  create mode 100644 arch/mips/configs/eyeq5_defconfig
>  create mode 100644 arch/mips/mobileye/Kconfig
>  create mode 100644 arch/mips/mobileye/Platform
>  create mode 100644 arch/mips/mobileye/board-epm5.its.S
>  create mode 100644 arch/mips/mobileye/vmlinux.its.S
>
> -- 
> 2.43.0
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com