Received-SPF: pass (google.com: domain of linux-kernel+bounces-33118-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <c633b856c9eb20288e8bc20539692083af3127ea.camel@icenowy.me>
Subject: Re: [PATCH 4/4] ARM: dts: qcom: msm8974: Add device tree for
 Samsung Galaxy S5 China
From: Icenowy Zheng <uwu@icenowy.me>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, Rong Zhang <i@rong.moe>, Bjorn
 Andersson <andersson@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Date: Mon, 22 Jan 2024 22:01:41 +0800
In-Reply-To: <1635b0e5-df47-4918-be83-edc27c59d8cf@linaro.org>
References: <20240121154010.168440-1-i@rong.moe>
	 <20240121154010.168440-5-i@rong.moe>
	 <1635b0e5-df47-4918-be83-edc27c59d8cf@linaro.org>
Organization: Anthon Open-Source Community
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 
Precedence: bulk
MIME-Version: 1.0

=E5=9C=A8 2024-01-22=E6=98=9F=E6=9C=9F=E4=B8=80=E7=9A=84 11:50 +0100=EF=BC=
=8CKonrad Dybcio=E5=86=99=E9=81=93=EF=BC=9A
> On 21.01.2024 16:39, Rong Zhang wrote:
> > This device has little difference compared to Samsung Galaxy S5
> > (klte),
> > so the device tree is based on qcom-msm8974pro-samsung-klte.dts.
> > The
> > only difference is the gpio pins of i2c_led_gpio. With pins
> > corrected,
> > the LEDs and WiFi are able to work properly.
> >=20
> > Signed-off-by: Rong Zhang <i@rong.moe>
> > ---
>=20
> Looks like you didn't change the brcm,board-type though?

This should be intentional to allow kltechn and klte to share Wi-Fi
NVRAM file.

>=20
> [...]
>=20
> > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-kltechn.dts
> > @@ -0,0 +1,16 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +#include "qcom-msm8974pro-samsung-klte.dts"
>=20
> It's customary not to include .dts files, instead split the common
> parts
> into e.g. qcom-msm8974pro-samsung-klte-common.dtsi and include this
> in
> both the existing and the new one.
>=20
> Konrad