Received-SPF: pass (google.com: domain of linux-kernel+bounces-33137-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 22 Jan 2024 22:05:27 +0800
From: Changbin Du <changbin.du@gmail.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Changbin Du <changbin.du@huawei.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>, linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	Thomas Richter <tmricht@linux.ibm.com>, changbin.du@gmail.com,
	Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v4 3/5] perf: script: add field 'disasm' to display
 mnemonic instructions
Message-ID: <20240122140527.36j2jcd6abdbtlgm@mail.google.com>
References: <20240119104856.3617986-1-changbin.du@huawei.com>
 <20240119104856.3617986-4-changbin.du@huawei.com>
 <e840bd05-a9e0-4463-8597-b67c7627809b@intel.com>
 <20240120074009.zmywqj6irtedivqk@M910t>
 <e8e5ea25-326b-4565-b0e8-1583b09dba65@intel.com>
 <20240122104646.oqa7jnmd6ed2dzdw@M910t>
 <Za5wluB2NckwNF0S@tassilo>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Za5wluB2NckwNF0S@tassilo>

On Mon, Jan 22, 2024 at 05:41:42AM -0800, Andi Kleen wrote:
> > > >>
> > > > Updated as:
> > > > 
> > > > 	When doing instruction trace decoding, insn, disasm and insnlen give the
> > > > 	instruction bytes, disassembled instructions and the instruction length
> > > > 	of the current instruction respectively.
> > > 
> > > I wondered about mentioning that disasm needs perf to be compiled with
> > > disassembler support, but with a permissive license it seems likely
> > > that libcapstone support would generally be built into perf, so that
> > > should be fine.
> > > 
> > Yes, libcapstone has a permissive license. It's available on most Linux distros.
> 
> What I've seen in the past is that people who build perf from source
> often miss installing all the build the dependencies because perf continues
> without an error. Make sure that if that happens and someone uses the option
> there is a clear message that points to the build process.
>

Currently, perf build will show libcapstone available status at the beginning
of build and prompt user how to install it, as other dependencies do.

> -Andi

-- 
Cheers,
Changbin Du