Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp367047rdb; Mon, 22 Jan 2024 06:47:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHCCY1PRIDpO5197IfRVsllHCD0rYcVYaqMxRvb2P3aoglOQUNtY0V2X4NytD6kI9CZkQ6D X-Received: by 2002:a17:906:444e:b0:a2e:d378:7612 with SMTP id i14-20020a170906444e00b00a2ed3787612mr1177298ejp.133.1705934850058; Mon, 22 Jan 2024 06:47:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705934850; cv=pass; d=google.com; s=arc-20160816; b=hLgjMKLWz9caTvVHbFE1BSQP+ZuoezM23USFA5RHNst8GKabA7w5rAEGw5XY98XD3Z WlP+4Dr3kPG82zwkQ8EjOyP3EfdmfuyvXbr/mE3oq7hC926IYCvZtOOSYNB3VD5VLOZ0 taTfL3aSh3OL1yetROIwAa/nhrN5KlriRHEEeiUTi31+7lSsZ507As4YVE6UT/3NCTVc yyRKBGvUBF0vQ9SIQydIbIbKAwFZG3DP1MEioQnH+Nsa4GDGQ3e889RAmvdbDm9Nw7Qa BksyP74594Jqrip9zFNmtReh44+TAesny0pCSCjsXIpvc1sDUDPxfCBtrV0hGRwxJ/Ob XDGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=X5cq1EuxODeQhdqFCXRkLpFayTbScAzAvsj9Pyd7lBY=; fh=6I2rXYiXQ/VBA4ITcgIlk3nOIu272A7qjVkgOtocE+4=; b=af3w0LgrtxW2veDEH/0x/cqVAFBYXflykQVWV5YcFt7n3SerU+Hwhx2PlOqdRcaRMM WMfckmflSNmhXqLZSuQpH7AVasZke4Ftm26Yg6xSqd99u41Naww1+HYEC9lGUrQFOipG G9/wdAfZelXzIFheIQZ7k1W/KwxUTpjB/PSXygeO0qEA+v0O/4lwCXLkezd6prh6Io1k VvD7/i2DUC66JbsCARaCMNzrhupbjlTINRr7Yni3ZKzDbJXLLvmiNUHyHnfUtIIbZd4C kLIJoB0Zre197JUMGbULI/bxnDlEuLGKvMQ1tsZ+4WHTNN96HsG7XEzk0nv/dCBbeNYa G73w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uI7WtW7x; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-33187-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33187-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id l8-20020a170906230800b00a2bd212444asi10863138eja.281.2024.01.22.06.47.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 06:47:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-33187-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uI7WtW7x; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-33187-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33187-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8F01A1F242B2 for ; Mon, 22 Jan 2024 14:47:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 768F13D57F; Mon, 22 Jan 2024 14:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uI7WtW7x" Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24A603D56B for ; Mon, 22 Jan 2024 14:47:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705934837; cv=none; b=GPeKc2JMl3T6DV8W4Fuwv6wn8C666dPYHVJSAGLArhM6leNBP8plwK7DdG2MMM2OTduBogpW92MnhReicokH/sy8Dqy8J8thC+piS9AdTU+/c3rfkPt4ETdBvIJcrI77KRjZN/mw2QurCLgpSaov3qKWKG0mgsO0YtK0aBnPnbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705934837; c=relaxed/simple; bh=UIz/6i8jdBmkbtw6XO5IjUsgAcglLhZUuAQP6AhZ3l8=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=gcKMiTceuMX4GwdQ/RLBAIZ40Lb1dIwlK/IH8yhp4BIILVnW3Vopj48ASmGdDZyH+e7Cb8qId1fR9Qk+nsCBaDxEpV2DULo3sRSmwv3mYpn6Na569co6t6A2Ulq7+Q7ptQWoR4kCJ/tMq/xXwTjJCrim2bDEEscsOCz2YcR9rSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uI7WtW7x; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-7bf2a5cf9cbso160599539f.1 for ; Mon, 22 Jan 2024 06:47:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705934835; x=1706539635; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X5cq1EuxODeQhdqFCXRkLpFayTbScAzAvsj9Pyd7lBY=; b=uI7WtW7xg2qJKNM1EW+/xKz2mQglPyCDRETGeMegd5s0s0l7f6u5qVcIZCJczILzPy 89TraDikS2bSXuS9HyMt+7xNIqEaYLoZX1gmnwYPaUfdUO3m/s4h3sJCfB/o8OZ3iWYf FFBrQFWxVmotZza3u6DsPZKY9cL211kD3KYAR9wS6mXi75FIURdivAFSJHVFpmhvqVM8 vx9Yqg6c2HjVO1i9qoxGtFb/cuA9+IR5RPOdYolYwmquMuHMkWgOmbpOoGFCNhVX3X/H vayMWPyU4hCJBlhtiH9g0CB4FE6KgjDq52MQaplNmg93XAlHx7Nbpq6xHyIaGvHLWVbK C+ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705934835; x=1706539635; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X5cq1EuxODeQhdqFCXRkLpFayTbScAzAvsj9Pyd7lBY=; b=r6aPhphh24C9GIqpbPbg7OPJUDXfZ3LR7DrC6pLxh1jwBuYsM7WOOrUMdzV8bIOF+g NTsOBlTbdQSGY/oYOk0mEMKrrHzLSmorH4u0hE8GFhT433NzdV37MmRZ4YR8rX9dROAY hKk9mI6PCQkmofX3z6K/v8xQ+a6U1JrDYhFkEOiaVs0SI77YFAmpvJ+I0umHI5WlqhGR b0FdjL/IWALILiIZDS2zwujAo911t3qWpmHsZNufYllLWtHsUiBTAS59sffsYC007XcU 5CZi9nHWs6xci7tHCRNMbMDdPSDT5WVSSgBuc7mRmnsYRbnl8ztODRMK0qXD38mdUZ3D qFvA== X-Gm-Message-State: AOJu0YzPJORvLA46s36s2djv6YAXApK3y7Y8vxqEEcloEUdC4xnxKdvI bl5QyfT3UzSx9whvGWEuvBKs+12lI9FXSeVLrH8nzjqMaNK72MNHnVDKJxCvdKs= X-Received: by 2002:a05:6602:728:b0:7bf:9ab4:5978 with SMTP id g8-20020a056602072800b007bf9ab45978mr765126iox.25.1705934835264; Mon, 22 Jan 2024 06:47:15 -0800 (PST) Received: from [192.168.1.20] ([178.197.215.66]) by smtp.gmail.com with ESMTPSA id fh26-20020a056638629a00b0046eebadf3a3sm412025jab.1.2024.01.22.06.47.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 06:47:14 -0800 (PST) Message-ID: Date: Mon, 22 Jan 2024 15:47:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [3/4] dt-bindings: interconnect: Add clock property to enable QOS on SC7280 Content-Language: en-US To: Odelu Kukatla , georgi.djakov@linaro.org, Bjorn Andersson , Konrad Dybcio , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240122143030.11904-1-quic_okukatla@quicinc.com> <20240122143030.11904-4-quic_okukatla@quicinc.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240122143030.11904-4-quic_okukatla@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/01/2024 15:30, Odelu Kukatla wrote: > Added clock property to enable clocks required for accessing > qos registers. Please use standard email subjects, so with the PATCH keyword in the title. `git format-patch` helps here to create proper versioned patches. Another useful tool is b4. Skipping the PATCH keyword makes filtering of emails more difficult thus making the review process less convenient. > > Change-Id: Ie0478cc7ae9742742e2389cfa37ee57bab1aa320 Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof