Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp382307rdb; Mon, 22 Jan 2024 07:10:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGVOcPfuvrWjslYgHmsr1U4rAaJutwI7pdZlCwk6J2Qm7lCP7+VfOpyoBLPD5WJd/HzCBCJ X-Received: by 2002:a05:6a20:7f91:b0:199:fffe:a495 with SMTP id d17-20020a056a207f9100b00199fffea495mr1874722pzj.82.1705936258591; Mon, 22 Jan 2024 07:10:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705936258; cv=pass; d=google.com; s=arc-20160816; b=esvqmW2ejkzGVZb1CrXeHNVXZP8FHZC2tz0aRUvmEuwBFbRVgw0BNmIyZG8wGCjZBe E/calW6MAawq5ahFstN91sbO9fPpnyk1TdIv4rM3cdTFKvEwvCnJywfwZK2FFLDe+zZW GbUVFmRtlC5DRMhAWAiQBRPhLzeOb98ut4uJYsKDBWR78GgJTyjZ0dAryaQtGF8yq8N5 ixowjBdtC2FF9eeoTTkbaEVXTIiQ3IUBR6gLQd5+jWBd6iSiTebKNTfjbojqTNbVXGhR a9/Vbopy/MRUkCl0M3gP6UFIZW8FoC/3VsS1hk3btw+MbbrpG66+7V6Ldq2DOqvIWm90 ZMIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=9eZRduKNvGVeB9aJIyquvVMwc8fAl3YaIxTQDqo1WTg=; fh=FY/VtDjRFynKk7eP8dvh8O+gTOLfJfKYfkKMWusXdBs=; b=RdLqLu3mmGMcYRh8xFXEvsYP//rbYBLAMbaKPzHkkPuTsaYfJ6N+uHUUz5rTDT89ny Ccooj7UfyzBvoNFGt3Q6sUD1aWK0Y2L1RGTdqwDCuH9+184INhLon9BLJBMiAnodK+zX eLGEiel4Bs0PyZQtkNbnQyndtgg3sl4/+lsiBL6xStN+BD+ajuAIRD1fIzYhLMoMDGz9 1ggiS4ZsF77Btp2eWNMRlMBBYmbeSX2meLw4X3DlR/85MNFUeigTTo4ql5iptH2UQxtc B82faKNiDohAkWLYz7IvWeYBTXwjIPuvKudU9XPSbNr+bAPMmfV7Yag35K0YkgkBCGNK NAHw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=O8TnIYlY; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-33172-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33172-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id y29-20020a056a00181d00b006d9aef87840si10515679pfa.300.2024.01.22.07.10.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 07:10:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-33172-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=O8TnIYlY; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-33172-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33172-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9B5D4B2588F for ; Mon, 22 Jan 2024 14:38:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 379983D974; Mon, 22 Jan 2024 14:38:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="O8TnIYlY" Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB9083D57F; Mon, 22 Jan 2024 14:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705934297; cv=none; b=Sw/NWG+FWyvssg0tBLxW1k8YwB0Cyq9QBVKpFcoEncKQOEqbN6H6HfPVWz0sel6z56S/LO7yEF9z37RryYDiIEqFyzbGGmrxsLR6RhPeAhOvTK8LxmxVozeahyhcD1o3lhlw6oXLrl38dM9HCgyELOV9pZ5QZG3cKTYykGXNBM0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705934297; c=relaxed/simple; bh=Glti8t+ZZpqebwMo9dTlaK0QzZUNIArYm7q98n5rPbc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PtQwJy3fX2CLvghWxKmggdor2g4173Mq1cUa5/qc9lrBFLh9mQo0feA3n7+6c0NXuGfV9Z4ffyNI/Q80AS5L/8GtrG/8oTspS9ugFaFi8Z4DDuvhaoToU35P/6G6snnBlu4IztTrkXYgf3LuncvChSXN5USVgn8Qk6IGOwxWwUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=O8TnIYlY; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40MDB74L027059; Mon, 22 Jan 2024 14:37:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=9eZRduKNvGVeB9aJIyquvVMwc8fAl3YaIxTQDqo1WTg=; b=O8TnIYlYGZfyYQL8P3i0C8yxN4DRQvasrWwLr0b4OqgDmaI75iRcqmBnf3Lf51wHvqTx prcbnFbRJj/s9eg5rNrRlh1L8zxgBRYDnsrWnsOMQb6WOpQpZeEGa5BaiKxu08FOIGPd QkER6Y2zHzffdGfKmCzXaCJPvrMb/YP5ZFZF4ygTpjOoKoCiuuunx22Z6KgtXoJL0FWn Q0oWbhDZ3Ym/d9Jfq7CnIkpqpx26B8hnUROolFW2Z/1WHG2mgAmyeVDApW2U+F2uNakq XEoPnP5uIZJIK1JrBLPQkoHLvGyr8wy/3+1g6JK3SQMssybZulRVfGyZ/LuZwYEKE+Lo GQ== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vsrycjk32-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Jan 2024 14:37:40 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 40MBSVlX025636; Mon, 22 Jan 2024 14:37:39 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3vrsgnruju-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Jan 2024 14:37:39 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 40MEbcMb18285072 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Jan 2024 14:37:38 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 527DB58055; Mon, 22 Jan 2024 14:37:38 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2C46F5804B; Mon, 22 Jan 2024 14:37:35 +0000 (GMT) Received: from [9.43.53.45] (unknown [9.43.53.45]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 22 Jan 2024 14:37:34 +0000 (GMT) Message-ID: <218f08f9-bc12-47db-aa04-c2058c901986@linux.ibm.com> Date: Mon, 22 Jan 2024 20:07:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 2/3] fs: remove duplicate ifdefs To: Chandan Babu R Cc: linux-kernel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, linux-xfs@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, mingo@kernel.org, peterz@infradead.org, anton@tuxera.com References: <20240118080326.13137-1-sshegde@linux.ibm.com> <20240118080326.13137-3-sshegde@linux.ibm.com> <87cyttedjj.fsf@debian-BULLSEYE-live-builder-AMD64> Content-Language: en-US From: Shrikanth Hegde In-Reply-To: <87cyttedjj.fsf@debian-BULLSEYE-live-builder-AMD64> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: wwsiLOWQFOWpM58VonwYO5JiFtGQQtRe X-Proofpoint-GUID: wwsiLOWQFOWpM58VonwYO5JiFtGQQtRe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-22_05,2024-01-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1011 impostorscore=0 mlxscore=0 spamscore=0 adultscore=0 mlxlogscore=620 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401220099 On 1/22/24 6:20 PM, Chandan Babu R wrote: > On Thu, Jan 18, 2024 at 01:33:25 PM +0530, Shrikanth Hegde wrote: >> when a ifdef is used in the below manner, second one could be considered as >> duplicate. >> >> ifdef DEFINE_A >> ...code block... >> ifdef DEFINE_A >> ...code block... >> endif >> ...code block... >> endif >> >> There are few places in fs code where above pattern was seen. >> No functional change is intended here. It only aims to improve code >> readability. >> > > Can you please post the xfs changes as a separate patch along with Darrick's > RVB tag? This will make it easy for me to apply the resulting patch to the XFS > tree. Ok. will split the fs patches into two and send v2 soon. Thanks. >