Received-SPF: pass (google.com: domain of linux-kernel+bounces-33279-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 22 Jan 2024 15:59:37 +0100
From: Nicolas Schier <n.schier@avm.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Nicolas Schier <nicolas@fjasle.eu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kbuild: resolve symlinks for O= properly
Message-ID: <Za6C2w0QIZDayA48@buildd.core.avm.de>
Mail-Followup-To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Masahiro Yamada <masahiroy@kernel.org>,
	linux-kbuild@vger.kernel.org, Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org
References: <20231215160637.842748-1-masahiroy@kernel.org>
 <20240122141203.CWe3n5rG@linutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="M+Z3urJkjmGAoQ8z"
Content-Disposition: inline
In-Reply-To: <20240122141203.CWe3n5rG@linutronix.de>
Organization: AVM GmbH


--M+Z3urJkjmGAoQ8z
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 22 Jan 2024 15:59:37 +0100
From: Nicolas Schier <n.schier@avm.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Nicolas Schier <nicolas@fjasle.eu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kbuild: resolve symlinks for O= properly

On Mon, Jan 22, 2024 at 03:12:03PM +0100, Sebastian Andrzej Siewior wrote:
> On 2023-12-16 01:06:37 [+0900], Masahiro Yamada wrote:
> =E2=80=A6
> > Using the physical directory structure for the O=3D option seems more
> > reasonable.
> >=20
> > The comment says "expand a shell special character '~'", but it has
> > already been expanded to the home directory in the command line.
>=20
> It might have been expanded, it might have not been expanded. Having a
> shell script:
> | #!/bin/sh
> |=20
> | exec make O=3D~/scratch/mk-check defconfig
>=20
> with bin/sh =3D dash results in:
>=20
> | make[1]: Entering directory '/home/bigeasy/linux/~/scratch/mk-check'
>=20
> while bin/sh =3D bash expands the ~ properly before for O=3D. Would it be
> too much to ask, to expand the ~?

Expanding tilde expandos is traditionally a shell feature, as you
already mentioned; and bash supports also expandos like '~+' and '~-'.
I think, we should leave the shell things in shells.

Thus, please update your shell scripts to be compliant to their
interpreting shell (e.g. use '$HOME' or switch the shell).

Kind regards,
Nicolas

--M+Z3urJkjmGAoQ8z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEDv+Fiet06YHnC6RpiMa8nIiabbgFAmWugtkACgkQiMa8nIia
bbidNQ/+PChz3YchNvwJsNx1T31zdo9pMPxMfhQswSRBAXU1v6UVIogye14Tuee5
gyAZrEwjzyLMe1gt6EziHUGI46uampWwOKjYUV1I4FPXgROWjg3L8wUTzR1ntlde
Hj/c6QMJbfsYUopTaEg/wSfAdur5Jq8dPWi6H/MRgSfrv+/n2wqWhQAIV3uOskJT
UvmHeWdqeZcqQWnn+YJv1JIpkezfVObemJG5rYpNqZZ6LsGqm5CaGP1EpwJ+mTLn
5nKroGpTAAHDrvDCnAjrNeWaEEv3g1PAVCHYNFQkKqD+ajjUnVYmYaamR6RNVWcW
PnCHz6PWD7Kr3j7kV3GoEFsifTHPHazZkLS8fW/TpTbjrDxpgGyTVP4EEcjWejTh
Yog4is9E0KPXlCUCHTOB0Z6GKtKroMZAfwG3avXdyimx/XGzNkBR/vdZqhno3ARa
IClL/WnlK0vT89rnpLfd5aWfPtlSQi2Uyf2f2TNmQ/9gwUXIkBnQmpp3n0zsonYf
aed7eXPxPiAB9ISB1rFrY9KT/xGUGPjFVjK/vKzAJG6rGxoObuUlU3yE3/8MmhEV
bwbGnU/V4xGxcLLy8VFHD+9m8EEAR2XrhBr+pWqvSrxDZYApT6sv49wavXWLRi98
xTBjWToWSxEBFluzNYCIFeQuyWLatqEVEyEU2seUbIVafZ6PKK8=
=1xdJ
-----END PGP SIGNATURE-----

--M+Z3urJkjmGAoQ8z--