Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp415447rdb; Mon, 22 Jan 2024 08:04:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGKjUD27xsShStQn547us6YZl93t+9JvUNmj06n/f30VP585TqGYJNPwK64bus/2zqEb81K X-Received: by 2002:a17:902:eb90:b0:1d7:6b3:9503 with SMTP id q16-20020a170902eb9000b001d706b39503mr6063539plg.13.1705939480336; Mon, 22 Jan 2024 08:04:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705939480; cv=pass; d=google.com; s=arc-20160816; b=mzmbpyG5nw0i4jC+anDWnSbfvouOWdwxDxq8GN5JS+sOwApqgRZPsfnuErxfKksLs2 RvKEWgIz8rleZuzaUpHkL77nsA9UBBDB9qTfumiseoPn3YTIDP2u/tMW+bMxaxIYsibU 3zPaNfNsajdAqs9jiMv6t396YuXTmGyjcsT+VeD47pDdl66CnGNG7JkMqtZd14zgtrmX UYiDJ1Rc4pG7zLUOvucokobpi/l1ZVjZI2maPb20jqwn9TuPQLWM2cpKaZ6k3vh2bzWc Fnd4q8j7p6XZoQvM1Z5/dj3xHALhCgdqrODgGjbx4GgMG1w3/MqWBwulEfa2OhlomsqY CNMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=j6qCq9mjgzXIcyyu8Xldo3rtV6iy8jAQllHcjOflIOk=; fh=mKW7lbmm6PIEbJnKtwRvcb6Hly4k/YuopXl77jo7gRk=; b=EYEwFwMDoFdh7tVdTwp+n8tI6JhDW+1BKWVTfHCXIg5T7ZZPZ6HyvbUMUZxUyJE+ad sGnEc9jKYtSVyjTixLMuA/hFzN/8HQbEQxe+xcCUeYgUeCclncNNWFdJP1m57/EBg+oh v8yqjnSkR9t+z///Wdkbt5IDj73bGIekARhl2B9CWkBk8Nm/7e1iyVCObuje+zl/RX25 FOuQxaICzbWNjzuNkzMBewA/4iXRVCJlNfHZU5ZUIAvu1tXos9sshofX82cWs3q5D9hT HwVYdsUozeyFBTWGS8qKLl6IWSxKw/e9BNq/LF19up9CGz6LErZMCMKkRJLzeqbAHum/ e6MA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eKQrMPZE; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-33399-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33399-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id k14-20020a170902c40e00b001d5efe34075si8441674plk.188.2024.01.22.08.04.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 08:04:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-33399-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eKQrMPZE; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-33399-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33399-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9C2572837AB for ; Mon, 22 Jan 2024 15:56:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7B7753E488; Mon, 22 Jan 2024 15:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eKQrMPZE" Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C6563E46E for ; Mon, 22 Jan 2024 15:09:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936186; cv=none; b=hBhPrXQaf5l04XZLxkpZn/kKbw+XM/J4Zu5aHsO4OrAbJ6+eOeSd4r6scw5BQ1xEHlpDsXJ2mJtXuGniCo1YZyPi9XNMaLROB10oBCWiy9E4DMmRwHv1e2LSEcJYNMUE4f04o09synzV6YTEp6CWmbmEG8JEpC5XQh++3+AYfhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936186; c=relaxed/simple; bh=jRrHgiEv5YrpuZPjYjnGtdk6oRN9GqngHkVDqIa9fq4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=hPW9r4JS//PpQLFEAK7ih0OZiY1COLKUa8+81YCmT65fRiG2jZb3mKoTOaDitAYyvIl9tA/4U4AlVYZQzbnZTJfv5RvnOWn/IQCayK/Kv3jrv0OAyogicywhbOiLApwTT+qUIrREVGCYR3eu+qrJsgoLi+GWhrCGsDbm1fIj9lo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=eKQrMPZE; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2cd04078ebeso42062561fa.1 for ; Mon, 22 Jan 2024 07:09:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1705936183; x=1706540983; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=j6qCq9mjgzXIcyyu8Xldo3rtV6iy8jAQllHcjOflIOk=; b=eKQrMPZEGyYeZtG2vgzfUwhqS92QzC99jymhERUWJJ5uO5ohRoluqqQJOnVDyCzv8z J4CsTHr1ONmE6UPX+Z67J2E79uZK26VSSnfEguFyQcDYH9UQmA3FnwLiiqFVAKFEI77z ttK9GwubKIkz6jVYh6lIw8ZF/ASMdU8SxRAWo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705936183; x=1706540983; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j6qCq9mjgzXIcyyu8Xldo3rtV6iy8jAQllHcjOflIOk=; b=LDRjz2jYYRnvYafcvKPOacOLm4kc7Ev+Ix2D5b+m2XjO9AP14tvI9M0n/bnJ/575O0 61o9/EX8ct0Cuulw1RtGhl92U+pogOE78qlmOHsEL2KS7LVphGM6J6qcF54fNDchAQbm 3AL54lPvEyHlosbu7ojY2V/jh2YN7IAD3b5Ti1zvXsBBCqVxn6zoXZFkDrGdHAL8ePCf oABn9m1quU07Jda0M6k/CRVW2n0N8txrX+ziSUxG/zsbAt7+7VBbW5+b9STpTz/dO8cn F9720c5rXihhwmpgO73UHx8+LeUBMFeikN0PryCDh4lTIw+ozlIuOgOODHHJiRff+7mE P5Vg== X-Gm-Message-State: AOJu0Yz3uNRaW+vN5qyzPRDiVn5CRRUdllF3L4T6A3GUGP7r5WNEHGsT YuYEz8WZejlQTF/qefJ9jL7hn4QanROEnBN242iyy8bZyq2Wjdv9PuYSrZMIVoAEe3JbfbrPZE2 iFPynBc+O0HlvpGA6nnf8rT0wBultq8LtVqdV X-Received: by 2002:a2e:a408:0:b0:2ce:fd80:210b with SMTP id p8-20020a2ea408000000b002cefd80210bmr890160ljn.3.1705936183235; Mon, 22 Jan 2024 07:09:43 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240119084328.3135503-1-lma@chromium.org> <20240119084328.3135503-3-lma@chromium.org> <1e7b8590-7dc7-47a8-8105-6d01db627f85@kernel.org> In-Reply-To: <1e7b8590-7dc7-47a8-8105-6d01db627f85@kernel.org> From: =?UTF-8?Q?=C5=81ukasz_Majczak?= Date: Mon, 22 Jan 2024 16:09:32 +0100 Message-ID: Subject: Re: [PATCH v3 2/3] watchdog: Add ChromeOS EC-based watchdog driver To: Krzysztof Kozlowski Cc: Gwendal Grignou , Tzung-Bi Shih , Radoslaw Biernacki , Wim Van Sebroeck , Lee Jones , Benson Leung , Guenter Roeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 22, 2024 at 11:31=E2=80=AFAM Krzysztof Kozlowski wrote: > > + wdd =3D devm_kzalloc(&pdev->dev, sizeof(struct watchdog_device), = GFP_KERNEL); > > sizeof(*) > ACK. > > +MODULE_DEVICE_TABLE(platform, cros_ec_wdt_id); > > device_id is not placed here, please open existing drivers for > reference. Why this isn't referenced in driver structure? > ACK, I will take s3c2410_wdt.c as an example, thank you. Best regards, Lukasz