Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp422060rdb; Mon, 22 Jan 2024 08:14:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IF0gqMF4VVovhbeOgD236b4q1iVen59f1HQ0tHU2B1dtPZDMGsMuW58/vcCSBPyPJNVT1TO X-Received: by 2002:a17:90a:69a3:b0:28b:9749:c5a4 with SMTP id s32-20020a17090a69a300b0028b9749c5a4mr1533986pjj.80.1705940043322; Mon, 22 Jan 2024 08:14:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705940043; cv=pass; d=google.com; s=arc-20160816; b=j5OZvtNRhfSu03tVce54t266OQKysegMy3rMeGXo7qrfMeyKtSmpV38PjGZwtqjS2y A4yuE97IpDxT4CwJKwHsDl8JJ5j0ZPrJZ+PIm16w6qHSCEetcRcUskCF/l4Xk6UBhifI mGsWmP0ZXmYj4hXqVD2NhNpdQh4CEEO1at9phupEvIpJ78D8XsPRkfCVvC2umrmLCP0q FxWzQrVWamMjE96CldfFh9g2K0xnD3DgGgs2oLlalT8GuGAD7q+aKPUXxzt0Tui1NT8S FzRI88y/O0FTQrgvCJx/jWSxouRVwdDuqFKJYVHL7+JgBPuizNlWY8EXOnm6z68KnaWA /b4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=2xzNGcI3XjhYv4Ds+S35EHg3kqQq++C7a/CxI/zQ3uY=; fh=gov0oEJgQKBPTBNKZ818aR+H9gUc3Scmfw7IE/6CQWo=; b=vRnqCzHjcpiD0WSEf7zJLk72MulMDSIqgR9OvFr4co/Oy6NLA7hyUA7CK8DrZCoGqE FiRVVTdvS4lWb3NKis8HCNun5sNN8TGAlpTOEipH8epeBzXfrbcbLQVXUabg6TbEgcmN SGsPRQW91E5QHybdYKc8F76FR+4vrdAWqsCysVwTMxoiQutGq3C/gsp6qi00/p4xUr0P QJ7V+ZV+iVO/aHwO8WQ6wbUBwUbOMGtM0P+P84oqxAITFEBf26y328ynRfH7YlOvrOK0 UA8LU85lyKtruQ947FDdprvXwSIftok8MgRzIwodCdZbjvs0sdnHnERkrTpF6kRmyE6P YDbQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Em7h+skf; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-33446-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33446-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id n36-20020a634d64000000b005cf58862d6asi8356110pgl.223.2024.01.22.08.14.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 08:14:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-33446-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Em7h+skf; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-33446-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33446-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E4E25281E9A for ; Mon, 22 Jan 2024 16:11:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C5CC812BE9F; Mon, 22 Jan 2024 15:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Em7h+skf" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF8234F5FD; Mon, 22 Jan 2024 15:12:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936331; cv=none; b=lZVTOyrOp2VT295+vc1ynPKQNWv1TbZNRbarc6CFrKyGNUIlmTUVVX+qsoM9DWs7TYs2qeVaKQY8tw2W1VL/gJvfzgFt36F20J1HTfGxsDLM2931qdDsDByNDbHga7OvC3HE8L7QNqqYrmr1SsGR7+K+XZOsNFuZTmR4rby+R+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936331; c=relaxed/simple; bh=LExyl5tzBGy0JjA375oXsxH+2E3IeErllaNkAG9dy5k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Zb8NWGNO9+2YOUZ+t8pawzV0ENXtOn3cU23Yv3YKpuPW5e4xyEekzejZWXmvyqGHkdip0LEyztiPS6AYqelp432lXCx+eG3ObR2xxWz4rMaU8J0R0AFWbijl6hUxkMjyL8mElf6Af6EE9dd/PgaJrb1lsfyv4Cqx+bMkad+Kfes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Em7h+skf; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F8D7C433F1; Mon, 22 Jan 2024 15:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705936330; bh=LExyl5tzBGy0JjA375oXsxH+2E3IeErllaNkAG9dy5k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Em7h+skfsnTtbRNL8/QO3DQW/f3dVih9zz+ebTlqps6t5B9fLrnGbqhdq8sR4rhUK DAFt9w+777POdZ7xQTL2J0CuorACRWsH5HM9M++d/eHAuJRs/fJe1ooySizXxt5H/s j7QbdBUOGC7w2kWfHkr0FaKkoVERJsP3KfKiT4CaDrVhCiKd7kvQhZkeD/e5ejJ0CW EYUndSkgtqSqbFLR37ufTU3ioX/oSmcUWmJiTDbpd9rGv1SsMNACzj18ChB4lulfgi DcntbqUBoeLCoj5y+ce3qXfS9qIiXrOVuUsoqLS4hVyWCInVq5XcCBGfSgBpMBDa2+ EvJK4gja+cS9Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Felix Kuehling , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher , Sasha Levin , Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.1 45/53] drm/amdgpu: Let KFD sync with VM fences Date: Mon, 22 Jan 2024 10:08:46 -0500 Message-ID: <20240122150949.994249-45-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122150949.994249-1-sashal@kernel.org> References: <20240122150949.994249-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.74 Content-Transfer-Encoding: 8bit From: Felix Kuehling [ Upstream commit ec9ba4821fa52b5efdbc4cdf0a77497990655231 ] Change the rules for amdgpu_sync_resv to let KFD synchronize with VM fences on page table reservations. This fixes intermittent memory corruption after evictions when using amdgpu_vm_handle_moved to update page tables for VM mappings managed through render nodes. Signed-off-by: Felix Kuehling Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c index 090e66a1b284..54bdbd83a8cc 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c @@ -191,7 +191,8 @@ static bool amdgpu_sync_test_fence(struct amdgpu_device *adev, /* Never sync to VM updates either. */ if (fence_owner == AMDGPU_FENCE_OWNER_VM && - owner != AMDGPU_FENCE_OWNER_UNDEFINED) + owner != AMDGPU_FENCE_OWNER_UNDEFINED && + owner != AMDGPU_FENCE_OWNER_KFD) return false; /* Ignore fences depending on the sync mode */ -- 2.43.0