Received-SPF: pass (google.com: domain of linux-kernel+bounces-33580-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240118054257.200814-1-chentao@kylinos.cn>
In-Reply-To: <20240118054257.200814-1-chentao@kylinos.cn>
From: Ulf Hansson <ulf.hansson@linaro.org>
Date: Mon, 22 Jan 2024 16:21:52 +0100
Message-ID: <CAPDyKFp=s7aOnpXti=rGTri=exW7sHdH693TEz7cQTiv=2gnFw@mail.gmail.com>
Subject: Re: [PATCH] pmdomain: Add a null pointer check to the omap_prm_domain_init
To: Kunwu Chan <chentao@kylinos.cn>
Cc: nm@ti.com, ssantosh@kernel.org, linux-kernel@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Thu, 18 Jan 2024 at 06:43, Kunwu Chan <chentao@kylinos.cn> wrote:
>
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/pmdomain/ti/omap_prm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pmdomain/ti/omap_prm.c b/drivers/pmdomain/ti/omap_prm.c
> index c2feae3a634c..b8ceb3c2b81c 100644
> --- a/drivers/pmdomain/ti/omap_prm.c
> +++ b/drivers/pmdomain/ti/omap_prm.c
> @@ -695,6 +695,8 @@ static int omap_prm_domain_init(struct device *dev, struct omap_prm *prm)
>         data = prm->data;
>         name = devm_kasprintf(dev, GFP_KERNEL, "prm_%s",
>                               data->name);
> +       if (!name)
> +               return -ENOMEM;
>
>         prmd->dev = dev;
>         prmd->prm = prm;
> --
> 2.39.2
>