Received-SPF: pass (google.com: domain of linux-kernel+bounces-33604-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20231119101445.4737-1-hkallweit1@gmail.com> <20231119101445.4737-12-hkallweit1@gmail.com>
In-Reply-To: <20231119101445.4737-12-hkallweit1@gmail.com>
From: Robert Foss <rfoss@kernel.org>
Date: Mon, 22 Jan 2024 16:31:46 +0100
Message-ID: <CAN6tsi4HmKF6tnnjD6qsi=+nj_1wWhGio+WYzUs972wMCWbSNQ@mail.gmail.com>
Subject: Re: [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:
 remove I2C_CLASS_DDC support
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Wolfram Sang <wsa@kernel.org>, Andrzej Hajda <andrzej.hajda@intel.com>, 
	Maxime Ripard <mripard@kernel.org>, Neil Armstrong <neil.armstrong@linaro.org>, 
	Jonas Karlman <jonas@kwiboo.se>, dri-devel@lists.freedesktop.org, 
	linux-kernel@vger.kernel.org, Jernej Skrabec <jernej.skrabec@gmail.com>, 
	linux-i2c@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>, 
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 19, 2023 at 11:15=E2=80=AFAM Heiner Kallweit <hkallweit1@gmail.=
com> wrote:
>
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> ---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/=
bridge/synopsys/dw-hdmi.c
> index 52d91a0df..aca5bb086 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct=
 dw_hdmi *hdmi)
>         init_completion(&i2c->cmp);
>
>         adap =3D &i2c->adap;
> -       adap->class =3D I2C_CLASS_DDC;
>         adap->owner =3D THIS_MODULE;
>         adap->dev.parent =3D hdmi->dev;
>         adap->algo =3D &dw_hdmi_algorithm;
>

Acked-by: Robert Foss <rfoss@kernel.org>