Received: by 2002:a05:7412:7c14:b0:fa:6e18:a558 with SMTP id ii20csp450319rdb; Mon, 22 Jan 2024 09:04:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IF97zsn+oTiVGcZuNTzjoBs39oBVkQbOw5u61WukMzjbeVe8wYAqypFpnHhaSfMy9aCRUPY X-Received: by 2002:a2e:bc83:0:b0:2ce:d97:1450 with SMTP id h3-20020a2ebc83000000b002ce0d971450mr1504401ljf.36.1705943074688; Mon, 22 Jan 2024 09:04:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705943074; cv=pass; d=google.com; s=arc-20160816; b=oZXcEInEme7IXu+zaYQ7u/bqqhHqGi+k8SbM0K5qhZ6FRoVZZwJjOJCX10d7zzjR6Y 0R3QDeQS9UiyOF3zWizQzLjZgvRA9qWFjHbLcLNf7/piPbnKsaHD+fDLvo6SEDgmyQ3x S9ip/bpmGRGIuEUGEiwX03AJ6ABC1U0+mFuYmqCVbxcMvHEodPUxblxAhoSJWA64Qd5G 4zjG5yEPWb2BQ1mHR14djYbvzuGJIuIHwuXdVfS4nXOz9JM3kflsgHXklTJdABlAzpWh 7Bqsx1Qa0O/loId2/ywL3gNCbG2yuOQH3k2d055ZnXJyOkIVZfeRMXD4OVGHzEDgNrkA VcUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=Ei2lvyaMI7Ann2hBChjEeGGXJXFbq+XEvxyzJIWpCNM=; fh=DSIa2oa2P/FKydv662gfahzggJj0gKvyMRvvFfhs36E=; b=aTwkp+08fhQmFm4Bs2/XvOK6KhUGSBGrb+m4NvN3afJi41DacJ+/Szvf+dAi3/BfJa Lr0yphWOPFtU/85hdirNSeJVmCpLHnlc+ogiarkHiXopNQ5wIW6ojQh1OfxXq3gx5apu H2fs+jeEiB2PthGLwaZbl5Y8g1Eg8VK/s9skmcWZLFFvrepF6iwB1jwVnNbECfjPptLb w/p+J3QdcjE00vp5oepWsNJHgG1idcPJOuFDYfEBBYh7ws/QPTMMpe3Xu59P8+q0faMO 6xZHjvPTuVz/BH51t2GzFjorPnbKskwbakdi+P4I9yL/Tm0kGvguBLS2GN6dxNjMbwpJ OMBg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DfCiNC0j; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-33622-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33622-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id x6-20020a05640226c600b0055c104274f7si2025804edd.82.2024.01.22.09.04.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 09:04:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-33622-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DfCiNC0j; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-33622-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33622-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6A6EB1F26B50 for ; Mon, 22 Jan 2024 17:04:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D178260890; Mon, 22 Jan 2024 15:46:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DfCiNC0j" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05FCD487AC; Mon, 22 Jan 2024 15:46:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705938398; cv=none; b=WN1TTQ7PWfniWMrzgNKPBc1aN0iZuxvloBmRGu0ltDBpUnY6ZwSKUpD4VUUTmrVYc1GF/E8idvH0hvwaKA6Misj+lwTZ5RwbuY4qpdd4B4gzTcU2GHeOTsRjPwhHTZh9UX+Hre+KzaXqJLTw0oMCUHgur+w857M+zT60f5aWVEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705938398; c=relaxed/simple; bh=/ztACHpiqxUk1r25CugN7mqbILIN7PLYHJR4ZTnAoKQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sEYW+bkJAitnZ7nWHoK+xh1AEj3fZXyRj9owupDmkVMvzIRQdCPuTsD9YVd57cQh3NhVwP+T/qqNV8mMzZDMeM6QPZ/eEhb4KDZ0wFyd3+GykRZ4/HfaKfbSu6ks6l7WtdS2Jv94blobQofAv5WZOTqwC3xmQmp/l1I+a9VgcwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DfCiNC0j; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CECCFC433F1; Mon, 22 Jan 2024 15:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705938397; bh=/ztACHpiqxUk1r25CugN7mqbILIN7PLYHJR4ZTnAoKQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DfCiNC0jVtA50NWze3cAPh6Xns4ZPXbXJyiySigJoeTNHUdkxYPgugN2oHhmIcgbB C+Lof2wfs7ofeWKjLWLJYhLHW7i+DghKD4ffjwtqdr7ej9H0ffQM0BfF6Ag/4tZLwE XaWRZ8Mr55oQzpYBnixTR+B+8+Kjj6k6A4/Wb8RAdzToaGoGF0Iad5zqdxahNGaRqf rKhLClYbneouscncMI6GnMg8OTBZ73SnBIz9xpa/CMjTj431wakyKj4w1IF+qGpfE7 PfaGgk0QYWsr3mBnQnPrNgaddHlcBXsAhEM4wsbI6HUFnrN5++nTVBzD9bj3Hurr22 Qc2ZQgGAeUAKw== Message-ID: <4e3ee39f-2cad-4543-a505-8b0d16a01ad6@kernel.org> Date: Mon, 22 Jan 2024 16:46:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] pwm: sprd: Improve the pwm backlight control function Content-Language: en-US To: Wenhua Lin , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Orson Zhai , Baolin Wang , Chunyan Zhang , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, wenhua lin , Xiongpeng Wu , zhaochen su , Zhaochen Su , Xiaolong Wang References: <20240122081754.17058-1-Wenhua.Lin@unisoc.com> <20240122081754.17058-3-Wenhua.Lin@unisoc.com> From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240122081754.17058-3-Wenhua.Lin@unisoc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/01/2024 09:17, Wenhua Lin wrote: > + > static int sprd_pwm_probe(struct platform_device *pdev) > { > struct sprd_pwm_chip *spc; > @@ -288,6 +310,10 @@ static int sprd_pwm_probe(struct platform_device *pdev) > if (ret) > return ret; > > + ret = sprd_pwm_get_mod(pdev); > + if (ret) > + dev_err(&pdev->dev, "get pwm mod failed! Use default setting\n"); That's not an error. dev_info. Assuming that it will even stay (once you send proper version for proper review). Best regards, Krzysztof