Received-SPF: pass (google.com: domain of linux-kernel+bounces-33636-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 22 Jan 2024 10:57:00 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: George Guo <dongtai.guo@linux.dev>
Cc: Masami Hiramatsu <mhiramat@kernel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@efficios.com>, Dennis Zhou <dennis@kernel.org>, Tejun
 Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>, Andrew Morton
 <akpm@linux-foundation.org>, George Guo <guodongtai@kylinos.cn>,
 linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
 linux-mm@kvack.org
Subject: Re: [PATCH] percpu: improve percpu_alloc_percpu_fail event trace
Message-ID: <20240122105700.05e5ee46@gandalf.local.home>
In-Reply-To: <20240122073629.2594271-1-dongtai.guo@linux.dev>
References: <20240122073629.2594271-1-dongtai.guo@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 22 Jan 2024 15:36:29 +0800
George Guo <dongtai.guo@linux.dev> wrote:

> From: George Guo <guodongtai@kylinos.cn>
> 
> Add do_warn, warn_limit fields to the output of the
> percpu_alloc_percpu_fail ftrace event.
> 
> This is required to percpu_alloc failed with no warning showing.

You mean to state;

  In order to know why percpu_alloc failed but produces no warnings, the
  do_warn and warn_limit should be traced to let the user know it was
  rate-limited.

Or something like that?

Honestly, I don't think that the trace event is the proper place to do
that. The trace event just shows that it did fail. If you are confused to
why it doesn't print to dmesg, then you can simply add a kprobe to see
those values as well.

-- Steve

> 
> Signed-off-by: George Guo <guodongtai@kylinos.cn>
> ---