Received-SPF: pass (google.com: domain of linux-kernel+bounces-33822-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 22 Jan 2024 17:30:37 +0000
From: Mark Brown <broonie@kernel.org>
To: Romain Naour <romain.naour@smile.fr>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	tony@atomide.com, lgirdwood@gmail.com,
	Romain Naour <romain.naour@skf.com>
Subject: Re: [PATCH] regulator: ti-abb: don't use
 devm_platform_ioremap_resource_byname for shared interrupt register
Message-ID: <1b2b5afc-308f-48bb-924a-2c29371abfc9@sirena.org.uk>
References: <20240122170442.729374-1-romain.naour@smile.fr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="fLVcmu4sGIFI8Iwp"
Content-Disposition: inline
In-Reply-To: <20240122170442.729374-1-romain.naour@smile.fr>


--fLVcmu4sGIFI8Iwp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 22, 2024 at 06:04:42PM +0100, Romain Naour wrote:

> We can't use devm_platform_ioremap_resource_byname() to remap the
> interrupt register that can be shared between
> regulator-abb-{ivahd,dspeve,gpu} drivers instance.

=2E..

> The commit b36c6b1887ff (regulator: ti-abb: Make use of the helper
> function devm_ioremap related) overlooked the following comment
> explaining why devm_ioremap() is used in this case:

> /*
>  * We may have shared interrupt register offsets which are
>  * write-1-to-clear between domains ensuring exclusivity.
>  */

I have to say that I wouldn't infer from that comment that there is any
reason why _byname() won't work - one would generally expect that a
get_resource_by_name() followed by an ioremap() of that resource would
be equivalent to the combined helper.  Based on the commit log here I
frankly have no idea what the issue is.  You should also add something
to the code which makes it clear what the issue is so the same
conversion isn't performed again, assuming that the fix isn't in the
helper.

>=20
> Fixes:

You're missing the commit here.

> This partially reverts commit b36c6b1887ffc6b58b556120bfbd511880515247.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

--fLVcmu4sGIFI8Iwp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWupjwACgkQJNaLcl1U
h9AYCQf9GqCmATajujQku7+2xQjUQrrWF5EEd4pwN21iJ9zY7BTfqDU6T5u05IUn
PO6VW3mCs1fMkUKsmLYz8TfoDBNWNxa3CivN1oCopBmxPZT204vOrA7QUPx35NFr
Yn1N9U8XWu98yayfB2gTx9zuSW/IlPWRUnPXpzKGJMV3X7Cx/ZvGrelxeWG3DPWA
PFh4ftak5pgD5iUMFXc9cyuoRpY9gLhrbRq6kYPTVoiD8KjZ1NK3CNhk6O7ql98Z
9heSxGBFNtJgZycp72zPI8fqB/3KA6xgnVw7VL/M4SzOIVHa5LxTDB7Af3F7gOOu
uf2Ik+3X7iP/TxZ9NFuWynB9BtUG3Q==
=L5mv
-----END PGP SIGNATURE-----

--fLVcmu4sGIFI8Iwp--