Received-SPF: pass (google.com: domain of linux-kernel+bounces-33829-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <45d2891e-989a-45c9-a527-8b14ff5f8748@intel.com>
Date: Mon, 22 Jan 2024 09:34:39 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] x86/resctrl: Implement new mba_MBps throttling
 heuristic
Content-Language: en-US
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, "Peter
 Newman" <peternewman@google.com>, <x86@kernel.org>
CC: James Morse <james.morse@arm.com>, Jamie Iles <quic_jiles@quicinc.com>,
	Babu Moger <babu.moger@amd.com>, Xiaochen Shen <xiaochen.shen@intel.com>,
	<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>
References: <20231201214737.104444-1-tony.luck@intel.com>
 <20240118214213.59596-1-tony.luck@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240118214213.59596-1-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHJncTR5SUZlcWh4eUp5elJlYUk3eTI0Q2ZRL3M1K1dXY2wzZmIvK2wyN0xR?=
 =?utf-8?B?NEZWVHgrR1VhMzBNZlo3cHE5V081MFYwTEI2azEzYkpEWVFETzJEQ3A5T1dE?=
 =?utf-8?B?WWJGcDJrNFlrdXYwT2h5U2g1V3E3NEs0TEhueVNtc01WNVd1ek5XQkJXV051?=
 =?utf-8?B?TklVMStZek9VNHhPTEJ4Tnc3MjRvQzFOekRRWHcyMmpCZ3BVOXc4cE53QklJ?=
 =?utf-8?B?V2J0alNySmNtemd2OVRCd3d5ZCtETVNNRGhoTUdJVkpWdzZtcE9FeWR3Z0JF?=
 =?utf-8?B?cjhQbFdrYkFZZFZzVytSay9xd01qb0V4Z200ZGthdGtkQTZid2J1TFB6anJ0?=
 =?utf-8?B?UnI0SXFYNXlkVzRMYzRsWGFTU2RHVlpNMC9xejFFWGVBRkRmNnQ4ZUJIZTYx?=
 =?utf-8?B?MGVNbDdqd3EyM3VIb3NNaGt6dUY0amZIbVRReGwrZXVvS1YxUnpiVEF3eGFk?=
 =?utf-8?B?cUI3Wi9YKzBPTkJ0QW9iR2lTaURXUEVFZkZHTFNsbzlxeGlwZmdwWU5qQXlN?=
 =?utf-8?B?N1hucEtXcVlkbk8wVG1yQmVvbGV2aFp3b3pEaU5tT3I0VG1QbFk2RjNxbUhV?=
 =?utf-8?B?ckIxS2lCbng3MmZVZVlyZDZjV0k3V1V6TE9FNUdLTTVwd3FLZHI2K0Q2S0pL?=
 =?utf-8?B?Rkh3dVIrYm9oTm5lZmRQbjRhOVlld21KTEluQzlPSjZqalZldWlIV2Y0NlJq?=
 =?utf-8?B?T2lXSHlOWmFJb210UnY0UFFKblpFa1hURXBXSVJRQXNnSVorZVcxaE05ZXhk?=
 =?utf-8?B?TmxvWDdyeG14NThaVTQxalRvUWtEcGJsTTIyaHNRVVQ5MlFZN1RVQ3M0cVVR?=
 =?utf-8?B?YXZqNFhVTmNIMFNxZG1uMUxsRUNUWW1YM0pmTU43VnFWNHhLS3hOY1lkbTNG?=
 =?utf-8?B?VlJCZ3d1Q3FiZmxYTTFFNytVOUtVV3JpQ3pOdUphandMMFlOUzY0SXlFM1Yv?=
 =?utf-8?B?TmVUUTdCUTAyMmczdDQ3Wkd2ZzRCWTF4MXM0WkdVNlJ0c2taKzE1NEtsMkVC?=
 =?utf-8?B?Wml4UDlFRTY1amwyeUgva2FGSTIwdm9oYXlDRjkzdXJMd0lOYS81aEd2eis2?=
 =?utf-8?B?K0Y2ZHlyOEZ3QkYvTjk0d3Jaam9rUFc2RmVWbTR3S1RVeFlJSjIySjVhRjhV?=
 =?utf-8?B?d2FhV3ZMVm5UYjFLa2dzMFUxQVlicWY5TWFHd0k3c2lxWklJa2U4M3g0SktB?=
 =?utf-8?B?Z3JoeGF0MTdMcnhXdzBCNWZldEFCVmI2V1ZzdWEvakp5QXF4TFJYZjcrVjdD?=
 =?utf-8?B?amkzVVlMcUEwZFR6WGNUbm1XT09XbTZYa3dSaG9yUVNlaVhpZTZvbWJqek0r?=
 =?utf-8?B?dytoSUdkdHRBZklYZTc2Ujh3OXlxMi9yem56SHNQcVFnTTBvdnhrQUg0dldV?=
 =?utf-8?B?bm1rLzNqcXFxSVNPcld3eDR5bjZ5eldXbFMvVDNMSmlLTUpkeEZneWNzcWRj?=
 =?utf-8?B?aGFhN0lwNGczMEo2bm5OVitvT3RJMWdCVmlhTjJobzVtaXZ5NDlDSFpINjVa?=
 =?utf-8?B?MkloTDluVFhjL1FwZmV5d3hNamdGeGs2eDVXeVZ4T0ZyYlhUdzAwc0RuRTlI?=
 =?utf-8?B?dVY4cHRUM1VSQ2RaK3pYbG5mbGJRNTZsZCtlYU9oT3VFSGRZU1Z3MUhRNUU4?=
 =?utf-8?B?aVJCdGFVRy9DVVVLQ3dLWGhCUXVCL1JOSmRaZUlZYnFDVFVwODdYaHUydFVJ?=
 =?utf-8?B?cTdPRkdYQ1E1cGxZam5Vc240Y3EyUnZCZ2ZMVUdYRHNXY082RWFGK3c5eDhZ?=
 =?utf-8?B?RVdDU3hpVlBMa3VuVlJhelExSFdJYUtmTVJ1N0ZvYVFzUDh3bjhYbnFveWMw?=
 =?utf-8?B?S1RZTEl2SzZVRW5rUmxTSE9ZUGFXWmx4MDJsQkpGVEZOYzhva3l6cEVDU3h1?=
 =?utf-8?B?MzErYmh6TEd2N2Z4ajdDejZCeUlEbVBNeHJjZnRzNDRBaTRzUElWUmJ4cmdS?=
 =?utf-8?B?eEZpUmM1ZnlUSmF6VE1WVVc2T3JBWWJ5NUVoTHpkeEhoQnZDVUVEaTk5aFN3?=
 =?utf-8?B?eis1eUlWUVkwd1NXVnJWVVR3eGFaRTRraTBWUDlTVmV0WDF6MTVKN3NzQnlB?=
 =?utf-8?B?ZTVlZU9TckN1bzk2dDhlSTl1Z1FIYVVwcktTbEtmWTl2RWJnN2NCRlBOV25U?=
 =?utf-8?B?OW91UVl4NWdrTlk4RlI3WkdFWHFoT2ppN0oyS09ZSENNL1ZxTFpIb0JMS3g0?=
 =?utf-8?B?T0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 50e71317-aaa9-498d-da25-08dc1b706a8f
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2024 17:34:41.9475
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BggR4vHev7KqvFEpd/3kEUiwk4WwKIugy+pf0azHBir8tcfmQ3p79fb3gZKDTkzRTNweV2btHcYspiFi4Uv5QSvIZVVnT6twTI0eLuLt2m0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8356
X-OriginatorOrg: intel.com

Hi Tony,

On 1/18/2024 1:42 PM, Tony Luck wrote:

> @@ -520,7 +517,7 @@ static void update_mba_bw(struct rdtgroup *rgrp, struct rdt_domain *dom_mbm)
>  {
>  	u32 closid, rmid, cur_msr_val, new_msr_val;
>  	struct mbm_state *pmbm_data, *cmbm_data;
> -	u32 cur_bw, delta_bw, user_bw;
> +	u32 cur_bw, user_bw;
>  	struct rdt_resource *r_mba;
>  	struct rdt_domain *dom_mba;
>  	struct list_head *head;

I am sorry Tony, this reverse-fir breakage slipped through. I only noticed it after
trying to see how best to present all the pending work to x86 maintainers. Could
you please send a fixup with this addressed? After that I am planning to propose its
inclusion among all the other pending resctrl fixes followed by the SNC work. The SNC
work will need a rebase starting with this snippet, unless you see an easier way forward?

Reinette