Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp12458rdb; Mon, 22 Jan 2024 10:15:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IGHtbybmNV14npwmRPzTcsCQ3Jgv1CS1g/d3IUfkpx5adsWTr17AJ9ZlmuNVoLS6Hb5fLxB X-Received: by 2002:a05:6e02:1206:b0:361:96c3:2f56 with SMTP id a6-20020a056e02120600b0036196c32f56mr3572069ilq.65.1705947334955; Mon, 22 Jan 2024 10:15:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705947334; cv=pass; d=google.com; s=arc-20160816; b=G8usl/mxohK908aSvwWi3f5vqjcTIy2kvTp2p62foQmfzLqiv+cZUejJrXJ3LjVDtl W9AOnw83SPKoSmRr2kNhZxhVUi99bLjpURnfzNWe1LzNg/AaCC4Rw0+gBtatTDRT8DOS 0JowQiWs+MK+LoFLo41Vhvj/skhHLdDgCQCndx7pulaijrOxxsGgeyZImjW3c4E+JKjb m0PAzYnGqEY4GPZ4NZ1gXo8QNqdG0p4ffVI/rlWPcsZHMJ196JaynRThalqXNL14vLBo IfZmn4un6NXjLPp3hFLXWDaI7GG4AZPcp0CW1lecVcIflmonYZC+ySlNMtrs8LwivVCR v9MA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NGNHyrHMg5T+Qh7WpIiamACVfA9Z4Rcr6JKQhuA9VEY=; fh=amTJdHCCspZ3Rb2YTokeoeCfEya2/7MH7vuKhonA0D0=; b=zHaJGuZmOquhP2uGTLE04H8B77h7KDEXTlJsQZKE9tA/oA1IEs69m51120cQl/UpvH vujdFxOzwaqu6++Vm/sKpC6U/0Yf2GvxWCVNx49Eu+xB3Hr3kySCkvLRHMTHfVWTH1lO NzRKAZeVolXH77tx3aI0Xy/Tx8aJJeuvWOLqf4IND6B9/EZ4izty0F5A5jEIquERAOZx 4+/CmcC+fzuC82Xs2cLlygo2rw3CwErYMDy9PceVKIs4+uMXe+T+ehWoqDXEne0Va0+3 x6LkAqzfzFLLrrfauMeYiOjViqGXLKiYW81F8U6o9JmNjyTt7zuepiPk5VBUWKDM/PIF 2KnQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="bAHg37/D"; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-33661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33661-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id f19-20020a63de13000000b005c680fbab23si855235pgg.527.2024.01.22.10.15.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 10:15:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-33661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="bAHg37/D"; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-33661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-33661-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3832528A386 for ; Mon, 22 Jan 2024 17:19:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B52294EB4A; Mon, 22 Jan 2024 16:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="bAHg37/D" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82A173A8C3; Mon, 22 Jan 2024 16:10:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705939808; cv=none; b=sCnU0hu0YzI5piapY1+1+EYz/OI+diyCuP+dXrSgwPExLmSzKRYzmIqV14xIeQR2GEkUmdoVM5Am2sVAzZn1jEPVpB/vf2YJaldmdq3Irm2xpzrmlR0PSnlAilNuMNOup5pPjj//9GXrRp7v5rJ3lfnpphbmaCwDJEax4JmLRN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705939808; c=relaxed/simple; bh=GyxujeA6VefOMTAZlZZ4BZpsYAB+TEiG+zBG1fVfzQc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uuM7dLkrnFnBzxNXXdh6WvbyU91Np8WwVFGJQ0Kt39wbxU2ZWqUKA7Ik1s9SITbSSMzlP6kjq28oEDaeyThsWVgEq59AgYcsAUB881Upb3zFwboUixMrPyQnJBGYlqVzQKqNOHR5I0y6ia7ewBDkNzT/8acnrByZ8O5j+ksmQj0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=bAHg37/D; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NGNHyrHMg5T+Qh7WpIiamACVfA9Z4Rcr6JKQhuA9VEY=; b=bAHg37/DgOA2D7Nup2N9IoSCUf RYBdsFsEU0xkski0IK2yvU1A2OMrf/qhwna0hlIEwWl69adYPIHIu53ORHNeF2VBh5Hg6YqXlDLij QgT/abpxa9Ic03QJaHTpi1JbsPKKSfAD09GSoo5WzRD6w09XhsCKb33KdFEtAaiQroP+/MBSczuBJ PUqlXM14wca8GyUxdWtL6h281dGgW485gjFNKwYDyeOQmtaqKuC5cFXaOk2jp+fQu2XsCOZRo+WJs UhFEoChHuXUqVFkeJ67BcBHkeCQZslkJMYJKeIyQiOigfY3G+09Cq0PK3aHfIXU01a0Vs85+b2vdc ADEmH24g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rRws8-00000000Mhy-0VRc; Mon, 22 Jan 2024 16:10:04 +0000 Date: Mon, 22 Jan 2024 16:10:04 +0000 From: Matthew Wilcox To: Jeff Layton Cc: David Howells , Christian Brauner , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Subject: Re: [PATCH 01/10] netfs: Don't use certain internal folio_*() functions Message-ID: References: <20240122123845.3822570-1-dhowells@redhat.com> <20240122123845.3822570-2-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 22, 2024 at 10:38:58AM -0500, Jeff Layton wrote: > On Mon, 2024-01-22 at 12:38 +0000, David Howells wrote: > > Filesystems should not be using folio->index not folio_index(folio) and > > I think you mean "should be" here. Also these are not internal functions! They're just functions that filesystems shouldn't be using because filesystems are only exposed to their own folios. The erofs patch used the word "unnecessary", which I like better (2b872b0f466d).