Received-SPF: pass (google.com: domain of linux-kernel+bounces-33830-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 22 Jan 2024 17:35:24 +0000
From: Conor Dooley <conor@kernel.org>
To: "Paller, Kim Seer" <KimSeer.Paller@analog.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Crt Mori <cmo@melexis.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Nuno =?iso-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
Subject: Re: [PATCH v7 1/2] dt-bindings: iio: frequency: add admfm2000
Message-ID: <20240122-postbox-slimy-248a2e521896@spud>
References: <20240122090228.28363-1-kimseer.paller@analog.com>
 <20240122-legible-fossil-25349ef9ad6c@spud>
 <PH0PR03MB7141A46C8DD0041775CD0E96F9752@PH0PR03MB7141.namprd03.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="MCbfwdcDBzV4nvA+"
Content-Disposition: inline
In-Reply-To: <PH0PR03MB7141A46C8DD0041775CD0E96F9752@PH0PR03MB7141.namprd03.prod.outlook.com>


--MCbfwdcDBzV4nvA+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 22, 2024 at 11:06:08AM +0000, Paller, Kim Seer wrote:
> > > +      adi,mixer-mode:
> > > +        description:
> > > +          Enable mixer mode.
> > > +        type: boolean
> > > +
> > > +      switch-gpios:
> > > +        description: |
> > > +          GPIOs to select the RF path for the channel.
> > > +          SW-CH1   CTRL-A   CTRL-B
> > > +          SW-CH2   CTRL-A   CTRL-B    CH1 Status        CH2 Status
> > > +                   1        0         Direct IF mode    Mixer mode
> > > +                   0        1         Mixer mode        Direct IF mo=
de
> >=20
> > I cannot make sense of this table you have here, the double header row =
you
> > have going on is hard to follow. There's also no mention here of what h=
appens
> > when both GPIOs are 0 or both GPIO are 1. Are these configurations perm=
itted?
>=20
> I also feel that it's quite hard to understand without the gridlines. In =
the preliminary
> datasheet, it's a switch control table, and I'm trying to replicate the w=
ay it is presented.
>=20
> On the table, each channel has control pins (CTRL-A and CTRL-B). For a mi=
xer mode
> configuration on channel 1, CTRL-A GPIO should be 0, and CTRL-B GPIO shou=
ld be 1.
> It's not permitted when both GPIOs are 0 or both GPIOs are 1. The state f=
or the GPIO
> should strictly follow the truth table.
>=20
> I'm considering making it much easier to understand by creating two separ=
ate tables for
> each channel, just like the example below. Or is it preferred if it could=
 be discussed in=20
> a sort of paragraph form?
>=20
> SW-CH1   CTRL-A   CTRL-B    CH1 Status            CH2 Status
> 	   1              0              Direct IF mode     Mixer
>=20
> SW-CH2   CTRL-A   CTRL-B    CH1 Status            CH2 Status
>           	    0            1               Direct IF mode     Mixer

I think it would be sufficient to cut down the original table to
something like:
 CTRL-A   CTRL-B    CH1 Status        CH2 Status
 1        0         Direct IF mode    Mixer mode
 0        1         Mixer mode        Direct IF mode

And state that the configurations where A =3D=3D B are not permitted.

--MCbfwdcDBzV4nvA+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZa6nXAAKCRB4tDGHoIJi
0gftAP40Y10Z/PEZG3hrDgMfGcEP2C/NdkdxryZWr/keJTMJ6gEAhZHQWc5ETow6
nk4YRriQIquAgLUZulArlOI5DOOyWw4=
=ZKhg
-----END PGP SIGNATURE-----

--MCbfwdcDBzV4nvA+--